[ https://issues.jboss.org/browse/JBIDE-12405?page=com.atlassian.jira.plugi... ] Alexey Kazakov updated JBIDE-12405: ----------------------------------- Description: 1. Create a cdi bean class. 2. Add the following lines to any method of the class: {code} System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); {code} 3. Repeat #2 a ten times. 4. There are 0.5n(n+1) as-you-type validation thread created, where n is a nubmer of srings of the file. So if you copied a hundred strings you will have 5050 threads. was: 1. Create a cdi bean class. 2. Add the following lines to any method of the class: {code} System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); System.out.println("#{test.bytess} sf sdf " + "" + "" + ""); {code} 3. Repeat #2 a ten times. 4. There are n! as-you-type validation thread created, where n is a nubmer of srings of the file. So if you have just ten stirngs you will have 362880 threads. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12405?page=com.atlassian.jira.plugi... ] Victor Rubezhny commented on JBIDE-12405: ----------------------------------------- I've updated JavaDitryRegionProcessor due to validate all the modified strings at once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12405?page=com.atlassian.jira.plugi... ] Victor Rubezhny commented on JBIDE-12405: ----------------------------------------- I cannot reproduce it while debugging. Are you sure that there is no validation invoked for "copy-pasted" strings? Can you provide steps to reproduce? I see that all the "pasted strings" are passed to the validator, but there are no output error/warning messages returned in some cases for the according lines of text. There are many output ValidationMessages may come from the Validator to the Reporter, but mostly they aren't associated with the changed (copy/pasted) line number. For example, I'm pasting a string with EL into line 100. So I supposed that if I'm asking the validator to process a string in line 100 then it should process it and return a ValidationMessage (if some error found) that points to line 100. But validator reports many errors for completely other lines, not the line 100. This is really strange behavior of validator. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12405?page=com.atlassian.jira.plugi... ] Alexey Kazakov commented on JBIDE-12405: ---------------------------------------- 1. Create the following class: {code} package test; import javax.enterprise.inject.Produces; import javax.inject.Named; public class Bean_Broken { public void foo() { String s = "#{string.ss}"; String s2 = "#{string.ss}"; } @Named @Produces public String string() { return ""; } } {code} 3. Both ELs are marked as a problem 4. Copy String s2 = "#{string.ss}"; 5. Delete it. 6. Past String s2 = "#{string.ss}"; 7. There is no validation problem on the second EL. 8. Add " " to the second string: String s2 = "#{string.ss} "; 9. The EL has a problem annotation now. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12405?page=com.atlassian.jira.plugi... ] Victor Rubezhny commented on JBIDE-12405: ----------------------------------------- Alexey, I cannot reproduce your last case: at step 6 I see validation problem. Regarding the "EL validator shows only first 20 problems by default" - this shouldn't be an option for As-You-Type validation, IMHO. When user changes some text he(she) must be granted to see the problems in the changed part of text. This option (20 problems by default) is good only for builder validation. But, IMHO, it shouldn't play for As-You-Type at all. The following example shows that when I have inserted two lines (#31 and #32) and strings from these two lines are to be validated... But the As-You-Type validator doesn't report problems for these two lines. It reports me 22 problems for completely other lines. In my opinion it's wrong and not suitable for As-You-Type validation. {code} Partitions to validate: [Line: 32>>>""] [Line: 31>>>""] [Line: 31>>>"#{test.bytess} sf sdf "] [Line: 31>>>""] [Line: 32>>>"#{test.bytess} sf sdf "] [Line: 32>>>""] [Line: 32>>>""] [Line: 31>>>""] Validation Message: 8: Producer method or field cannot be annotated @Inject [JSR-299 §3.3.2, §3.4.2] Validation Message: 129: "test" cannot be resolved Validation Message: 76: "test" cannot be resolved Validation Message: 114: "test" cannot be resolved Validation Message: 52: "test" cannot be resolved Validation Message: 158: "test" cannot be resolved Validation Message: 16: "test" cannot be resolved Validation Message: 87: "test" cannot be resolved Validation Message: 41: "test" cannot be resolved Validation Message: 171: "test" cannot be resolved Validation Message: 30: "test" cannot be resolved Validation Message: 56: "test" cannot be resolved Validation Message: 91: "test" cannot be resolved Validation Message: 137: "test" cannot be resolved Validation Message: 110: "test" cannot be resolved Validation Message: 162: "test" cannot be resolved Validation Message: 67: "test" cannot be resolved Validation Message: 34: "test" cannot be resolved Validation Message: 125: "test" cannot be resolved Validation Message: 184: "test" cannot be resolved Validation Message: 80: "test" cannot be resolved Validation Message: 64: "test" cannot be resolved <<< validateString validateJavaElement: 0 regions <<< endProcessing: 657ms {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12405?page=com.atlassian.jira.plugi... ] Victor Rubezhny edited comment on JBIDE-12405 at 8/10/12 9:55 AM: ------------------------------------------------------------------ Alexey, I cannot reproduce your last case: at step 6 I see validation problem. Regarding the "EL validator shows only first 20 problems by default" - this shouldn't be an option for As-You-Type validation, IMHO. When user changes some text he(she) must be granted to see the problems in the changed part of text. This option (20 problems by default) is good only for builder validation. But, IMHO, it shouldn't play for As-You-Type at all. The following example (based on first test case, but more lines are copy-pasted - about 200 lines total) shows that when I have inserted two lines (#31 and #32) and strings from these two lines are to be validated... But the As-You-Type validator doesn't report problems for these two lines. It reports me 22 problems (why not 20 (as default says)?) for completely other lines. As result I don't get the problems for two problematic lines inserted. In my opinion it's wrong and not suitable for As-You-Type validation. {code} Partitions to validate: [Line: 32>>>""] [Line: 31>>>""] [Line: 31>>>"#{test.bytess} sf sdf "] [Line: 31>>>""] [Line: 32>>>"#{test.bytess} sf sdf "] [Line: 32>>>""] [Line: 32>>>""] [Line: 31>>>""] Validation Message: 8: Producer method or field cannot be annotated @Inject [JSR-299 §3.3.2, §3.4.2] Validation Message: 129: "test" cannot be resolved Validation Message: 76: "test" cannot be resolved Validation Message: 114: "test" cannot be resolved Validation Message: 52: "test" cannot be resolved Validation Message: 158: "test" cannot be resolved Validation Message: 16: "test" cannot be resolved Validation Message: 87: "test" cannot be resolved Validation Message: 41: "test" cannot be resolved Validation Message: 171: "test" cannot be resolved Validation Message: 30: "test" cannot be resolved Validation Message: 56: "test" cannot be resolved Validation Message: 91: "test" cannot be resolved Validation Message: 137: "test" cannot be resolved Validation Message: 110: "test" cannot be resolved Validation Message: 162: "test" cannot be resolved Validation Message: 67: "test" cannot be resolved Validation Message: 34: "test" cannot be resolved Validation Message: 125: "test" cannot be resolved Validation Message: 184: "test" cannot be resolved Validation Message: 80: "test" cannot be resolved Validation Message: 64: "test" cannot be resolved <<< validateString validateJavaElement: 0 regions <<< endProcessing: 657ms {code} was (Author: vrubezhny): Alexey, I cannot reproduce your last case: at step 6 I see validation problem. Regarding the "EL validator shows only first 20 problems by default" - this shouldn't be an option for As-You-Type validation, IMHO. When user changes some text he(she) must be granted to see the problems in the changed part of text. This option (20 problems by default) is good only for builder validation. But, IMHO, it shouldn't play for As-You-Type at all. The following example (based on first test case, but more lines are copy-pasted - about 200 lines total) shows that when I have inserted two lines (#31 and #32) and strings from these two lines are to be validated... But the As-You-Type validator doesn't report problems for these two lines. It reports me 22 problems (why not 20 (as default says)?) for completely other lines. In my opinion it's wrong and not suitable for As-You-Type validation. {code} Partitions to validate: [Line: 32>>>""] [Line: 31>>>""] [Line: 31>>>"#{test.bytess} sf sdf "] [Line: 31>>>""] [Line: 32>>>"#{test.bytess} sf sdf "] [Line: 32>>>""] [Line: 32>>>""] [Line: 31>>>""] Validation Message: 8: Producer method or field cannot be annotated @Inject [JSR-299 §3.3.2, §3.4.2] Validation Message: 129: "test" cannot be resolved Validation Message: 76: "test" cannot be resolved Validation Message: 114: "test" cannot be resolved Validation Message: 52: "test" cannot be resolved Validation Message: 158: "test" cannot be resolved Validation Message: 16: "test" cannot be resolved Validation Message: 87: "test" cannot be resolved Validation Message: 41: "test" cannot be resolved Validation Message: 171: "test" cannot be resolved Validation Message: 30: "test" cannot be resolved Validation Message: 56: "test" cannot be resolved Validation Message: 91: "test" cannot be resolved Validation Message: 137: "test" cannot be resolved Validation Message: 110: "test" cannot be resolved Validation Message: 162: "test" cannot be resolved Validation Message: 67: "test" cannot be resolved Validation Message: 34: "test" cannot be resolved Validation Message: 125: "test" cannot be resolved Validation Message: 184: "test" cannot be resolved Validation Message: 80: "test" cannot be resolved Validation Message: 64: "test" cannot be resolved <<< validateString validateJavaElement: 0 regions <<< endProcessing: 657ms {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12405?page=com.atlassian.jira.plugi... ] Alexey Kazakov commented on JBIDE-12405: ---------------------------------------- It does not work as expected since it should work for everyone. Not only for you ;) Regarding limitations of number of reported problems. It's another issue. Java validator has limitiation too. By default they report only first 100 problems. But JBT validator is slower then JDT so we report only first 20 by default per validator. It means that if you have for example 30 EL problems and 5 CDI problems on the file then you will get 20 EL warnings/errors and 5 CDI waarnings/errors. 25 in total. But there is a problem with random order of such problem annotations. So if you have 30 problems on the file it will mark not just 20 first but some 20 of 30 in random order. It's known issue but let's try to fix it. Let's create a new issue for that. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12405?page=com.atlassian.jira.plugi... ] Victor Rubezhny commented on JBIDE-12405: ----------------------------------------- I suppose that the As-You-Type validation performance problem is solved. So, this issue could be closed. I have reproduced the issue with not validated Java-Strings that are pasted into Java Editor - JBIDE-12418 is created for the issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12405?page=com.atlassian.jira.plugi... ] Alexey Kazakov resolved JBIDE-12405. ------------------------------------ Assignee: Victor Rubezhny (was: Alexey Kazakov) Resolution: Done fixed -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira