[ https://jira.jboss.org/browse/JBIDE-7527?page=com.atlassian.jira.plugin.s... ] Max Andersen updated JBIDE-7527: -------------------------------- Component/s: JBossAS -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7527?page=com.atlassian.jira.plugin.s... ] Max Andersen updated JBIDE-7527: -------------------------------- Fix Version/s: 3.2.0.CR1 (was: 3.2.0.Beta2) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7527?page=com.atlassian.jira.plugin.s... ] Max Andersen commented on JBIDE-7527: ------------------------------------- Note, the intended use case is that you point it to a directory with a runtime directly in root or a set of runtimes directories directly under that root...these should be found pretty fast if not instantly if our search is intelligent. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7527?page=com.atlassian.jira.plugin.s... ] Snjezana Peco commented on JBIDE-7527: -------------------------------------- I have created a new feature. It is org.jboss.tools.runtime.core.feature. The feature includes two plugins: - org.jboss.tools.runtime.core - org.jboss.tools.runtime.ui The feature requires only the base Eclipse plugins : org.eclipse.ui, org.eclipse.core.runtime and org.eclipse.core.resources and can be easily used. The org.jboss.tools.runtime.core plugin includes the org.jboss.tools.runtime.core.runtimeDetectors ext. point that serves to define a runtime detector. The following is an example: <extension point="org.jboss.tools.runtime.core.runtimeDetectors"> <runtimeDetector id="org.jboss.tools.runtime.handlers.JBossASHandler" name="JBoss Server Runtime" class="org.jboss.tools.runtime.handlers.JBossASHandler" preferenceId="org.eclipse.wst.server.ui.runtime.preferencePage"/> </extension> id - a string that identifies a runtime detector. Must be unique. name - the name used in the UI class - has to extend the AbstractRuntimeDetector class preferenceId - the ID of the preference page where the runtime is (link to the UI) - optional Detectors for JBoss AS/EAP, Seam, Drools and jBPM are defined in the existing org.jboss.tools.runtime. The Runtime Tools Runtime Detection preference page is defined in the org.jboss.tools.runtime.ui plugin. In order to define some runtime detector, a developer needs only the org.jboss.tools.runtime.core plugin. The org.jboss.tools.runtime.ui plugin is necessary to show the preference page. 2) JBoss Tools Runtime Detection (ex JBoss Tools Runtimes) preference page is shown in the JBTRuntimeDetectionPreferencePage.png screenshot. Add - opens the standard directory dialog for scanning/adding runtimes. Runtimes aren't scanned (this behavior can be changed) Edit... - opens the dialog shown in the EditRuntimeDialog1.png screenshot. The user can change the path (Browse,,,) and scan/create runtimes (Refresh). Runtimes aren't scanned and created until the user presses Refresh. Remove - removes the path. Search.. - as Refresh in the "Edit runtime detection path" dialog, scans a path for runtimes (the SearchForRuntimes.png screenshot) . The Cancel button stops searching and cancels the dialog. The OK button creates a runtime. After refreshing, the "Edit runtime detection path" dialog looks like in the EditRuntimeDialog2.png screenshot. TODO : - remember entered paths, identified runtimes and disabled/enabled runtime detectors - Scan paths that have the "Every startup" button checked, when the user starts Eclipse in an old workspace. - scan all the paths when the user starts Eclipse in a new workspace. If Eclipse finds a new runtime(s), it would show a dialog that would enable the user to open the Runtime Detection preference page where he could review and create new runtimes. - add a runtime detector for JDK (and maybe for the standard WTP runtimes) - would this need to be done in a separate plugin/feature? Suggestions: 1) If some path is scanned, we could remember the path timestamp and scan again only if the timestamp is changed. The Refresh/Search... button would ignore timestamp. This would speed up the startup. 2) We could add a table of runtimes to the JBoss Tools Runtime Detection preference page as shown in the JBTRuntimeDetectionPreferencePage1.png screenshot. 3) The Edit... action (the "Edit runtime detection path" dialog) and the Search.../Refresh actions (the "Edit runtime detection path" dialog) could be combined in one action/dialog. 4) Add a checkbox to the Runtimes viewer that would inform the user if the runtime is created or not. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7527?page=com.atlassian.jira.plugin.s... ] Snjezana Peco commented on JBIDE-7527: -------------------------------------- The above described changes aren't committed yet. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7527?page=com.atlassian.jira.plugin.s... ] Snjezana Peco commented on JBIDE-7527: -------------------------------------- Since the change includes new plugins/features, it isn't possible to create a patch. I could create an update site (including the source plugins) if you want. It would be better to create update site when I add the planed functionalities described in TODO. I would like you to comment the UI and my suggestions. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7527?page=com.atlassian.jira.plugin... ] Snjezana Peco edited comment on JBIDE-7527 at 12/9/10 2:49 PM: --------------------------------------------------------------- In order to test this feature, you can start JBDS 4.0.0.Beta2 or JBT 3.2.0.Beta2 and update the JBoss Tools Detection feature using the https://anonsvn.jboss.org/repos/jbosstools/workspace/snjeza/runtime-updat... update site. Source code: Attached is a patch (o.j.t.runtime.patch) for the org.jboss.tools.runtime plugin and the org.jboss.tools.runtime.feature feature. The patched o.j.t.runtime plugin requires the org.jboss.tools.runtime.core and org.jboss.tools.runtime.ui plugins that are included in the o.j.t.runtime.core.zip archive. All the runtime plugins and features can be imported using o.j.t.runtime.all.zip. I have added all the planned functionalities (described in my previous comment) except additional runtime detectors (JDK, WTP Runtimes ...). was (Author: snjeza): In order to test this feature, you can start JBDS 4.0.0.Beta2 or JBT 3.2.0.Beta2 and update the JBoss Tools Detection feature using the https://anonsvn.jboss.org/repos/jbosstools/workspace/snjeza/runtime-updat... update site. Source code: Attached is a patch (o.j.t.runtime.patch) for the org.jboss.tools.runtime plugin and the org.jboss.tools.runtime.feature feature. The patched o.j.t.runtime plugin requires the org.jboss.tools.runtime.core and org.jboss.tools.runtime.ui plugins that are included in the o.j.t.runtime.zip archive. All the runtime plugins and features can be imported using o.j.t.runtime_all.zip. I have added all the planned functionalities (described in my previous comment) except additional runtime detectors (JDK, WTP Runtimes ...). -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7527?page=com.atlassian.jira.plugin... ] Max Andersen commented on JBIDE-7527: ------------------------------------- Installed this using http://anonsvn.jboss.org/repos/jbosstools/workspace/snjeza/runtime-update (stripped https and plugins) Comments in no particular order: 1) Avaliable is spelled wrong ;) 2) Runtime detectors should not have "runtime" in their name 3) Shouldn't runtime detectors be ordered to know which comes first or is that implicit ? 4) Search is not enabled when not selecting an element - does it only search the selected directory ? 5) I miss a "Search" button that search all. 6) how would I search just one new directory for a one-off installation ? 7) I added a directory, switch to new workspace and a dialog say new runtimes had been detected and if I wanted to edit them. I said yes - but nothing was shown besides the preference page. I was expecting to see the list of found runtimes on the first dialog and be able to confirm if they shuold be installed or not. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7527?page=com.atlassian.jira.plugin... ] Snjezana Peco commented on JBIDE-7527: -------------------------------------- I have created a new update site and attached a new source code. I hope I have added all the functionalities you required except #6 that I don't understand. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7527?page=com.atlassian.jira.plugin... ] Snjezana Peco commented on JBIDE-7527: -------------------------------------- I think I have fixed the issues you described in our chat. I have created a new update site and attached a new source. I would have one suggestion: adding the Select all/Deselect All button to the Edit and Search Runtime Path dialog that would enable/disable all runtimes. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7527?page=com.atlassian.jira.plugin... ] Max Andersen updated JBIDE-7527: -------------------------------- Priority: Critical (was: Major) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7527?page=com.atlassian.jira.plugin... ] Snjezana Peco resolved JBIDE-7527. ---------------------------------- Labels: new_and_noteworthy (was: ) Resolution: Done Fixed. Created runtimes can be enabled/disabled when starting Eclipse in a new workspace. Fixed. Fixed. The changes have been committed to the trunk. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira