[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Tom Fennelly commented on JBIDE-5726: ------------------------------------- I don't think the current approach will work for sample messages where there are multiple possible bindings, each one of which could have a different set of decoders. If represented on the property as it is now... you can only represent one set. I think it would be to fix this one as soon as we can and solve the accessibility issue some other way e.g. by using some sort of small figure on the connection, as suggested by Brian. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Tom Fennelly commented on JBIDE-5726: ------------------------------------- Sorry... if this was sorted out for the GA I'd be happy with that. Brian, when you said "bump"... I thought "bump out past GA to next version". You really meant "bump out past CR2..." right? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Tom Fennelly commented on JBIDE-5726: ------------------------------------- So there are no bug fixes post CR2? Would be a pity to let it go out with this one in it, but not the end of th world I guess. Dart... is it a big task to fix this? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Xue Peng commented on JBIDE-5726: --------------------------------- Done , please try to use this new feature. What can it do : 1. Select at the connection line (target node is Java Bean Value Node) , Decoder configuration tab will be shown in the Properties Viewer. 2. Link source to JavaBean Value Node to create a new line , smooks editor will set a default Decoder type to Value node (If it had a decoder type already , smooks editor won't change it) 3. Delete a connection. Decoder type will be removed and all the decoder parameters will be removed too. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Xue Peng commented on JBIDE-5726: --------------------------------- why the main "properties" belongs to connection ? At least , the "Property" and "Setter Method" must belong to the bean property node. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Brian Fitzpatrick updated JBIDE-5726: ------------------------------------- Original Estimate: 0 minutes Remaining Estimate: 0 minutes Priority: Critical (was: Major) Bumping to critical so this gets fixed by the end of next week - Feb 5 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Tom Fennelly reopened JBIDE-5726: --------------------------------- I'm still seeing the Data properties on the bean properties. I thought these were going to be on the connection properties too? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Tom Fennelly commented on JBIDE-5726: ------------------------------------- Can we not fix this? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Xue Peng commented on JBIDE-5726: --------------------------------- Tom , there is a big problem with putting Data properties on connection: When user select at the connection line , then Data properties shows in PropertyViewer , it's what we want to reveal. But If user change the Data properties value , the connection will be removed , and now how will we do for the Data properties tab ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Tom Fennelly commented on JBIDE-5726: ------------------------------------- Sorry... typo in last comment... "you don't explain why the connection is removed" :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Tom Fennelly commented on JBIDE-5726: ------------------------------------- It only needs to be removed if the user changes it to something that selects a different node. If the user just makes the selector more/less specific, then it doesn't need to be removed. Example... if the selector was "order/header/customer/name" and the user changes it to: 1. "order/header/customer/address", then it should be removed. 2. "customer/name", then it doesn't need to be removed, because it is selecting the same element, but is just less "specific". In reality, the only reason a user might do #2 above is for performance reasons - a less specific selector is faster to match. I think we should just make these properties readonly (and if possible... move them to the connection where imo they belong). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Brian Fitzpatrick commented on JBIDE-5726: ------------------------------------------ I think this ultimately boils down to some things we should do for this release and others to spin off into a separate JIRA for the next release... For this release: 1) We need to move the Data elements (Name, Namespace, Default) from the Bean properties page to the properties page for the Connection. These properties are not relevant to the target bean, but are directly relevant to the connection line between source and target. 2) We need to make the Name (which is really the Selector Path) read-only. If the user needs to make this path less specific for performance reasons, they will hopefully be a more advanced user and they should be able to do that in the source XML. 3) We need to make the Property and Setter Method properties on the Bean properties page read-only for now. For the next release: 4) The Property and Setter Method properties need to be enabled/disabled based on what type of bean it is. Property should only be editable if the target property is a Map (HashMap, etc.). Setter Method should only be editable if the target property is a regular Java Bean. In all other cases, these two fields should be read-only and not editable. Tom, can you spin #4 off to its own JIRA (and probably explain it better than I did) and set it for a LATER release? Dart, can you try to fix 1-3 before you disappear on vacation? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Brian Fitzpatrick commented on JBIDE-5726: ------------------------------------------ Dart, properties look great now. Thanks for moving them. Now all that's left for this JIRA is to make those controls read only as discussed here: https://jira.jboss.org/jira/browse/JBIDE-5726?focusedCommentId=12510180#a... Thanks for taking care of all this! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5726?page=com.atlassian.jira.plu... ] Brian Fitzpatrick resolved JBIDE-5726. -------------------------------------- Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira