[
https://issues.jboss.org/browse/JBIDE-16142?page=com.atlassian.jira.plugi...
]
Ilya Buziuk commented on JBIDE-16142:
-------------------------------------
I believe it is either impossible or almost impossible to implement. It is really
intricate to implement, because:
1. buttons - how skin buttons can be detected from the image? how action listeners can be
added?
2. address bar - how to properly add an address bar?
3. detecting browser space - how browser space can be detected?
4. skin rotation - how rotation listeners can be added?
5. skin resizing - this custom skins won't be resizable
etc...
In the very best case we will get a half-baked feature. So, I'm going to reject that
issue.
Basically, adding a skin to BrowserSim requires approximately one week of work -
sometimes less, sometimes more. I don't believe that that process can be automated:
skin image should be cropped for both horizontal and vertical states; each button should
be cropped in 4 variants (horizontal / vertical / enabled / disabled); adding logic
(action listeners, rotation listeners etc...)
BrowserSim: enable use of a custom skin
---------------------------------------
Key: JBIDE-16142
URL:
https://issues.jboss.org/browse/JBIDE-16142
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: browsersim
Affects Versions: 4.1.1.CR1
Reporter: Michelle Murray
Assignee: Ilya Buziuk
Open BrowserSim simulated device. Right-click device and click Preferences. For devices,
click Add. In last field of Add Device wizard user selects a skin from a predefined list.
User should be able to select to upload a custom skin. For example they might have their
own skin for a pink iPhone 5c or some other shiny new phone.
I guess the issue in including this feature might be activating functionality for buttons
on the front of the skin? Perhaps that's why it hasn't been done?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira