[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-4703: --------------------------------------- Fix Version/s: 3.1.0.M3 any chance of these plugin actually moving into JBoss Tools "standard" svn structure and location ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-4703: -------------------------------------------- well - I would prefer not having two different builds of the same thing...plus using our existing infrastructure becomes easier if it is layed out equally ;) Anyway - if this is an externally controlled project we need to discuss how that will go release schedule wise. Nothing big - just needs to get clarified. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Denis Golovin updated JBIDE-4703: --------------------------------- Component/s: Build/Releng -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt reassigned JBIDE-4703: --------------------------------- Assignee: Nick Boldt (was: Max Rydahl Andersen) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt commented on JBIDE-4703: ----------------------------------- After much delay as I fought with Athena (and VE and WTP, and ultimately threw in the towel), I've sorta got this working, but Java is complaining about path to javac and not knowing what Object and Class are. Here's hoping an update/reboot will cure what ails. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Gary Brown commented on JBIDE-4703: ----------------------------------- The older style plugins without MANIFEST.MF files have now been updated - let me know if you still have the same problems with them. In terms of features, I have updated the versions of the plugins in svn to be 3.0, so feel free to restructure/remove the features as you need. I'll leave the older style 2.x plugins in cvs. What I also wanted to find out was whether, from a jboss tools perspective, it would be possible to start a category for Savara tools (new jboss.org project) - of which the pi4soa plugins/feature would be the first? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt commented on JBIDE-4703: ----------------------------------- After a few more tweaks and refactorings, I have pi4soa building (no tests, just runtime, sources, sdk) using the Athena harness. To run it locally, check it out from svn and rename the appropriate build.properties.example.* file for your OS, then adjust the paths for workspace, build dir , and JVM accordingly. https://pi4soa.svn.sourceforge.net/svnroot/pi4soa/trunk/releng/ --- However, integrating it into the existing JBT build will be tricky since it depends on: 1. These plugins from Eclipse Orbit: org.apache.xml.resolver, javax.xml, org.apache.xml.serializer, org.apache.xerces, org.apache.xalan 2. This plugin from Mozilla: org.mozilla.xpcom_1.8.1.3-20080312.jar I could set up a separate Hudson build for pi4soa and then later integrate the pi4soa update site zip into the JBT update site zip as a downstream step; then, the JBT uberbuild would treak pi4soa as a requirement (like the Drools runtime) rather than a build (like the Drools IDE). --- As to categorization on the JBT update site, I can easily create a new category for Savara tools, if we want to collect them and keep them separate from the core JBT runtimes. Of course if there's only ONE feature at the moment - pi4soa - does it need its own category? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Gary Brown commented on JBIDE-4703: ----------------------------------- Forgot to ask - what needs to happen to get the tests sorted? Previously it was mentioned about moving the tests out into separate plugin(s) - what is the normal convention, one test plugin per feature, or a test plugin per plugin? Were you going to be doing this change, or did you want me to? If me - what is the naming convention for the test plugin? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Gary Brown commented on JBIDE-4703: ----------------------------------- The approach you outlined sounds good. I'll let you know when the tests are separated. May not be until next week. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt commented on JBIDE-4703: ----------------------------------- Orbit does publish p2 update sites, which work quite well with Athena or could be pulled down and cached on jboss.org, like we do for m2eclipse (which recently moved their update site from .com to .org). The latest Orbit is this: http://download.eclipse.org/tools/orbit/downloads/drops/R20090825191606/ They just can't be arsed to LINK to the site, which is here: http://download.eclipse.org/tools/orbit/downloads/drops/R20090825191606/u... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Gary Brown commented on JBIDE-4703: ----------------------------------- I don't know where the xulrunner dependency would come from - its not directly referenced in any of the pi4soa plugins. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt commented on JBIDE-4703: ----------------------------------- Working on getting the tests to compile/run now. Found a bug w/ the p2 director code for installing plugins into the test runtime; fixed and respinning local build to verify. Added missing features and map file entries too. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Gary Brown commented on JBIDE-4703: ----------------------------------- Added: org.pi4soa.cdl.CDLAllTests in the org.pi4soa.cdl.tests plugin org.pi4soa.common.CommonAllTests in the org.pi4soa.common.tests plugin, and org.pi4soa.service.ServiceAllTests in the org.pi4soa.service.tests plugin. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt commented on JBIDE-4703: ----------------------------------- Got a yellow build here: http://hudson.qa.jboss.com/hudson/view/DevStudio/job/jbosstools-cbi-pi4so... 777 test failures out of 1255 tests run: http://hudson.qa.jboss.com/hudson/view/DevStudio/job/jbosstools-cbi-pi4so... Note that I'm using JDK6 to run these. Would JDK5 be better? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt updated JBIDE-4703: ------------------------------ Attachment: test.xml_3.zip Probably the difference between AntRunner w/ JUnit3.8 + ETF and AntRunner in Eclipse. Evidently there's a flaw in the way we run tests, and I want to move away from the Eclipse3.2-era test framework to something that supports JUnit4 and SWTBot, both in Eclipse and headlessly... I'm just not sure how to proceed to get your tests working as is. If that's even possible w/ the current setup. Here's how the test process runs the org.eclipse.ant.core.antRunner application: $JAVA_HOME/bin/java $Xflags -enableassertions -cp $cpAndMain -ws $ws -os $os -arch $arch \ -application org.eclipse.ant.core.antRunner -data $workspaceDir -f ${relengCommonBuilderDir}/builder/tests/test.xml $antTestTarget \ $Dflags -Dws=$ws -Dos=$os -Darch=$arch -D$installmode=true -Dbuildcfg=${buildcfg} -DdownloadsDir=${downloadsDir} -DtestingDir=${testingDir} \ -DrelengBaseBuilderDir=${relengBaseBuilderDir} -DrelengCommonBuilderDir=${relengCommonBuilderDir} -DrelengBuilderDir=${relengBuilderDir} \ $J2SE15flags $J2SE16flags \ $properties -logger org.apache.tools.ant.DefaultLogger (full script here http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.dash/athena/org.ecli...) It then runs this script: http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.dash/athena/org.ecli... which then fires up the generated test.xml for each plugin: <ant antfile=&quot;(a){testPluginNameAndID}/test.xml&quot; dir="${eclipse-home}"> <property name="eclipse-home" value="${eclipse-home}" /> </ant> I've attached the three generated test.xml files for the latest yellow build in Hudson. If you can see what might be missing from the classpath, or how I'm using the wrong/different classloaders... please let me know. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Gary Brown commented on JBIDE-4703: ----------------------------------- Do you have a debug log from Ant, to show the class loading? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Gary Brown commented on JBIDE-4703: ----------------------------------- Only just started trying this out, but when I did the build, at the point where it was compiling the org.pi4soa.cdl.test plugin, it resulted in a number of errors of the type: [build] [mkdir] Created dir: /tmp/build/N200909262214-pi4soa/eclipse/plugins/org.pi4soa.common.tests/@dot [build] [javac] Compiling 26 source files to /tmp/build/N200909262214-pi4soa/eclipse/plugins/org.pi4soa.common.tests/@dot [build] [jar] Building jar: /tmp/build/N200909262214-pi4soa/eclipse/plugins/org.eclipse.test/automated.jar [build] [delete] Deleting directory /tmp/build/N200909262214-pi4soa/eclipse/plugins/org.eclipse.test/temp.folder/automated.jar.bin [build] [javac] ---------- [build] [javac] 1. ERROR in /tmp/build/N200909262214-pi4soa/eclipse/plugins/org.pi4soa.cdl.tests/src/java/org/pi4soa/cdl/impl/AssignImplTest.java (at line 26) [build] [javac] import org.pi4soa.common.testutils.DOMTestUtils; [build] [javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [build] [javac] The import org.pi4soa.common.testutils cannot be resolved [build] [javac] ---------- and also when compiling the org.pi4soa.service.tests plugin: [javac] 1. ERROR in /tmp/build/N200909262214-pi4soa/eclipse/plugins/org.pi4soa.service.tests/src/java/org/pi4soa/service/behavior/impl/BehaviorTestBase.java (at line 52) [build] [javac] org.pi4soa.common.testutils.TestModelListener l= [build] [javac] ^^^ [javac] 1. ERROR in /tmp/build/N200909262214-pi4soa/eclipse/plugins/org.pi4soa.service.tests/src/java/org/pi4soa/service/behavior/impl/BehaviorTestBase.java (at line 52) [build] [javac] org.pi4soa.common.testutils.TestModelListener l= [build] [javac] ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [build] [javac] org.pi4soa.common.testutils cannot be resolved to a type ^^^^^^^^^^^^^^^^^^^^^^^^ [build] [javac] org.pi4soa.common.testutils cannot be resolved to a type So not sure why these errors don't occur in the hudson build? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Gary Brown commented on JBIDE-4703: ----------------------------------- Cannot reproduce now - tried removing the /tmp/build directory and it still completed (with test failures). So removed the pi4soa plugins and Eclipse dash.common.releng and releng.basebuilder plugins, and reinstalled them - and it still completed. So not sure what went wrong before. Will continue to see if I can find anything else relevant. In the meantime, is it possible to disable the tests in the hudson build and proceed with getting the plugins into the nightly builds? I know it is not ideal - but the tests all run successfully within Eclipse, and so can be manually run when any changes are made. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Gary Brown commented on JBIDE-4703: ----------------------------------- All tests should now be green - although I had to comment out one test for the moment, as I need to think more about a solution. I have tested these using Run As->JUnit Plugin Test - which gave the same errors as the headless build. However when I tried running the releng->build.xml this morning I consistently got: [build] [p2.dir] !ENTRY org.eclipse.equinox.p2.repository 4 1002 2009-09-28 09:09:40.509 [build] [p2.dir] !MESSAGE Communication with repository at http://download.eclipse.org/tools/orbit/downloads/drops/R20090825191606/u... failed. [build] [p2.dir] !STACK 0 [build] [p2.dir] java.net.SocketTimeoutException: Read timed out [build] [p2.dir] at java.net.SocketInputStream.socketRead0(Native Method) [build] [p2.dir] at java.net.SocketInputStream.read(SocketInputStream.java:129) So have been unable to confirm that the test runs ok as part of the build. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt commented on JBIDE-4703: ----------------------------------- Site is there. Unfortunately there are no mirrors of the site, and and eclipse.org is being pounded because Galileo SR1 came out on Friday. Bandwidth saturation sucks. One way around this would be to fetch a copy of the update site and store it in repository.jboss.org. I'll start on that today. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Gary Brown commented on JBIDE-4703: ----------------------------------- Yes that did it - all runs perfectly now, with all tests passing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt commented on JBIDE-4703: ----------------------------------- Using orbit zip, we get a clean build (21 mins to build)! http://hudson.qa.jboss.com/hudson/view/DevStudio/job/jbosstools-cbi-pi4so... I'm going to purge the workspace and try again to make sure everything works from an empty baseline. Fingers crossed! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt commented on JBIDE-4703: ----------------------------------- BTW, the pi4soa tests won't run on x86_64 hudson nodes. Not sure why, but I'm not going to spend any more time on the issue, since I have three blue builds on x86. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt updated JBIDE-4703: ------------------------------ Attachment: Screenshot-jbt+pi4soa-aggregate.png woo! prototype buckminster-aggregator script to merge pi4soa packed plugin update site w/ jbt uberbuilder update site works! See attached screenshot. Can't yet merge the pi4soa features into an existing category, but might have a workaround for that using a custom site.xml. For now I'm happy with "third party athena builds" contributing their own categories to the site. Are you cool with that? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt updated JBIDE-4703: ------------------------------ Attachment: Screenshot.png Using custom categories, we end up REPLACING existing categories instead of ADDING to them; back to the drawing board, sadly... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt reassigned JBIDE-4703: --------------------------------- Assignee: Max Rydahl Andersen (was: Nick Boldt) I'll let Max weigh in here. [1] https://jira.jboss.org/jira/secure/attachment/12329752/Screenshot-jbt%2Bp... an increasing # of categories, one per project (or in the case of jbpm3/jbpm4/jbpm-convert, a combined category) vs. [2] https://jira.jboss.org/jira/secure/thumbnail/12329994/12329994_Screenshot... a set # of categories where we explicitly put SDKs in one bucket, runtimes/editors in another Which model do we prefer? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt commented on JBIDE-4703: ----------------------------------- FYI, the bug I hit today re: inability to reuse an existing category when merging is https://bugs.eclipse.org/bugs/show_bug.cgi?id=294349. I see three solutions here (until Thomas fixes the aggregator bug): a) drop recategorization entirely so that each project built outside the uberbuilder gets its own category: one for pi4soa, one for jbpm3, one for jbp4, one for jmx, etc. (we'll end up with about 30 categories that way). b) explicitly list all features in the bpm, tools, and sdk categories c) build a parser which lets me use wildcards to specify includes/excludes for the categories (eg., "*.sdk.*" = JBossToolsSDK category) In order of effort/time, (a) is the easiest, then (b), then (c). IMHO the best solution is either (b) [faster now, more maintenance later] or (c) [slower now, theoretically no maintenance later], because I don't think (a) will scale very well. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Nick Boldt commented on JBIDE-4703: ----------------------------------- Integrated into JBT 3.1.0.RC1 build. Spinning now: http://hudson.qa.jboss.com/hudson/view/DevStudio/job/jbosstools-nightly-3... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4703?page=com.atlassian.jira.plu... ] Gary Brown commented on JBIDE-4703: ----------------------------------- No, don't need a separate update zip. Thanks for all the hard work. Will point people at it to test it out. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira