[ https://issues.jboss.org/browse/JBIDE-10541?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10541: --------------------------------------------- I would even say/consider we should just add/show the egit commit dialog UI to let user choose what gets committed/added. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10541?page=com.atlassian.jira.plugi... ] Rob Stryker commented on JBIDE-10541: ------------------------------------- Here are the categories of files that we can choose to commit on the commit operation: - getAdded() - getChanged() - getConflicting() - getMissing() - getModified() - getRemoved() - getUntracked() The question then is which of these should be added to the commit list. "Added" does not actually count as new files, as the initial state of any new file is "untracked". However automatically adding any and all "untracked" resources seems like a bad idea in general. However I, of course, am willing to do whatever makes sense here. If you all tell me it only makes sense that the default behaviour is to commit *EVERYTHING*, then I will have it commit any and all changes. I believe the most logical behaviour is to commit files that were added, changed, modified, or removed. I believe conflicting, missing, and untracked, should not be added by our publish method by default. The other option, of course, is to have options for this in the server adapter somewhere, either in the editor or in a properties page. I would also be ok with this solution, but this, of course, depends on our server editor / properties UI modifications, which seek to find out if settings such as these belong in the server editor or in the properties page. Either way, passing this list of files to the CommitOperation is not a hard task. We need only to discover what the proper default behaviour should be, and what level of control is available to the user. I vote for no UI dialog during a commit (annoying), these settings with checkboxes listed in the PROPERTIES page, etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10541?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10541: --------------------------------------------- There is already an UI showed today - adding a "next" page on this that have the commit UI in this is not a bad thing IMO. And "raw speed" is not a concern for this publish operation. We should *not* be autoadding files - that's just wrong IMO. And the git ui is fine to do this with. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10541?page=com.atlassian.jira.plugi... ] Rob Stryker commented on JBIDE-10541: ------------------------------------- Showing the non-added files commit dialog was not part of the design spec you put over at https://issues.jboss.org/secure/attachment/12350063/openshift_new_project... Furthermore, if there are any files you do not want committed (like .settings/file1, .settings/file2), this dialog will come up over and over and over. If you don't add these files, and don't specifically gitignore them, then there will be 2 unadded files. The dialog will come up. The next publish, the same. The next publish, the same. Let's also realize that a new openshift app, imported and organized using m2e-wtp, will have a .settings folder with 9 files in it, a .project file, and other files. The dialog will appear over and over until the user gets infuriated enough to specifically gitignore the file. In the event a user doesn't want to git-ignore the file (since that's official) but they just perhaps wanted a temporary file in the folder during dev time and they were just keeping notes in it, this dialog will endlessly annoy the user. As mentioned above, the .settings folder in a new openshift app will cause this dialog to appear every single time. So in short, the issue was rejected because the issue is titled "if i add a file to my project, the openshift adapter will not add / commit it", and this is not a bug. This is a design decision. New files are not to be automatically added by the server adapter. Users are expected to manually add them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10541?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10541: --------------------------------------------- most will add use ignore and we already show a dialog today to certify they want to commit. I'm not asking for adding a new dialog, asking to evolve the dialog we have to evolve to use the egit view to allow users to control these things. Also not asking to add new files. Could also be done by in the dialog showing a line saying "2 non-added/committed files - will not be deployed" and then have a link on these to show the egit dialog to commit them or similar. Could also show a two page simplified wizard. On first page show what we got now and "finish" starts the publish, but I can go to next page which will have the egit dialog page showing and users can then add/remove what is needed there. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10541?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-10541: ---------------------------------------- Summary: If I add a file to my project, the OpenShift server adapter does not handle it well (was: If I add a file to my project, the OpenShift server adapter will not add/commit it) Priority: Blocker (was: Major) updated title to be more correct. issue is more about the dialog "lying" to the user about no changes to commit since there obviously are. Should at least make the dialog actually mention the untracked files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10541?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-10541: ---------------------------------------- Fix Version/s: 3.3.0.CR1 (was: 3.3.0.Beta3) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10541?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-10541: --------------------------------------------- Ran out of time - we can fix this in 3.3.x. Setting descripton to be better -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10541?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-10541: ------------------------------------- Steps to Reproduce: # EXEC: launch OpenShift Application wizard # EXEC: provide valid credentials # EXEC: select/create application # EXEC: create new project/use existing project # EXEC: add a new file to your OpenShift enabled project # EXEC: tell the OpenShift server adapter to publish Result: The adapter tells you that you dont have any changes to push Expected: The adapter should notice the new file, that was not added to the git index yet, and add & commit before publishing was: # EXEC: launch OpenShift Application wizard # EXEC: provide valid credentials # EXEC: select/create application # EXEC: create new project/use existing project # EXEC: add a new file to your OpenShift enabled project #EXEC: tell the OpenShift server adapter to publish Result: The adapter tells you that you dont have any changes to push Expected: The adapter should notice the new file, that was not added to the git index yet, and add & commit before publishing -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10541?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-10541: ------------------------------------- Fix Version/s: 4.0.x (was: 4.0.0.Alpha2) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira