[ https://jira.jboss.org/jira/browse/JBIDE-5700?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-5700: -------------------------------------- Since a project example can contain more than one project that can have runtime, we can do the following: - add the following declarations to the project_examples.xml file (optional) : <runtimes> <asRuntime projectName="project1" runtimeType="org.jboss.ide.eclipse.as.51, org.jboss.ide.eclipse.as.50, org.jboss.ide.eclipse.as.60, any" /> <asRuntime projectName="project2" runtimeType="org.jboss.ide.eclipse.as.60" /> <seamRuntime projectName="project1" runtimeVersion="2.2.0, 2.1.2, any" /> <seamRuntime projectName="project2" runtimeVersion="2.1.0", "2.1.1", "2.1.2" /> </runtimes> The Project Examples engine would work in the following way: - if the workspace would contain the same runtime name as the project in the project example does, the engine wouldn't do anything (in case of Seam and AS runtime) - for the first declaration, PE would try to find the JBoss AS 5.1 Runtime, then JBoss AS 5.0 and finally JBoss AS 6.0. If it wouldn't find any, it would choose the first available runtime and set it to the project1 - for the second declaration, PE would set the server runtime to the project2 if there is the JBoss AS 6.0 Runtime - declarations for Seam would be similar. The only difference would be using versions instead of types. This would be done before bringing up the Quick Fix dialog. We would have to add the JBoss Tools AS and Seam dependencies. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5700?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-5700: -------------------------------------- We could add ESB, Drools and other runtimes. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5700?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-5700: -------------------------------------- "Seam 2.2 Booking Example - EAR (including a tutorial)" in https://anonsvn.jboss.org/repos/jbosstools/workspace/examples/project-exa... can serve as an example of this feature. The following fixes are defined: <projects> ... <project> ... <fixes> <fix type="wtpruntime"> <property name="allowed-types">org.jboss.ide.eclipse.as.runtime.eap.50</property> <property name="short-description">Missing WTP Runtime</property> <property name="eclipse-projects">booking22,booking22-ejb,booking22-ear</property> <property name="description">This project example requires the JBoss EAP 5.0</property> </fix> <fix type="seam"> <property name="allowed-versions">2.2.0</property> <property name="short-description">Missing Seam Runtime</property> <property name="eclipse-projects">booking22</property> <property name="description">This project example requires Seam version 2.2.0</property> </fix> <fix type="plugin"> <property name="id">org.testng.eclipse</property> <property name="versions">5.8.0, 5.9.0</property> <property name="short-description">Missing TestNG plugin</property> <property name="description">The TestNG plugin is required if you want to run Seam tests. You can install it using the following update site: http://beust.com/eclipse</property> </fix> </fixes> ... </project> ... </projects> When the Project Examples wizard is called in the workspace that doesn't have the JBoss EAP 5.0, Sean Runtime 2.2.0 and TestNG plugin, the user will get a dialog as shown in the pexamples1.png screenshot. When clicking the Details button, the user will get a dialog as shown in the pexamples2.png screenshot. The user can finish the wizard. After adding the JBoss EAP 5.0, Sean Runtime 2.2.0 and TestNG plugin, the user will get a dialog as shown in the pexamples3.png screenshot. It does not matter how the JBoss EAP 5.0 Runtime and Seam 2.2 Runtime are named, the Project Examples wizard will fix the project settings and set the corresponding runtime. I have created fixes for a missing WTP Runtime, Seam Runtime and plugin. We can also add fixes for Drools, ESB, jBPM, connection profiles... However, each fix adds new dependencies to the Project Examples plugin. To avoid those dependencies, we could define the fixes as extension points which would mean that we would have to add at least one new feature and plugin. Max, what is your opinion about this? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5700?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-5700: -------------------------------------------- 1) Generally looks good. 2) Shouldn't these just be merged with the quick fixes dialog ? Otherwise there are always two steps for the user or ? But for now its fine I guess, since we can change the ui later on as long as the metadata is correct. 3) Shouldn't the short-description/description messages be part of the fix-extension instead of part of each project example declaration ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5700?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-5700: -------------------------------------------- 2) Of course, you are right. I didn't realized the first time around that this are shown during the selection of the project examples. 3) I could see the benefit in being able to add/redefine the description field, but when would the content of those fields be different between examples ? Adding a "Fix" button would be what the user would be presented for anyway when importing the project, right ? Maybe also reword the "facing problem" segment to "This example has some requirements that could not be automatically configured. When importing the example you might see some errors which would need fixing manually or via Quick Fixes. Click "Details" to see more." And could we put a yellow warning icon on this project example in this case ? And Yes, I think "Fixing requirements" would be a better name. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5700?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-5700: -------------------------------------- I have made changes according to your suggestions. See pexamples4.png and pexamples5.png. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5700?page=com.atlassian.jira.plu... ] Brian Fitzpatrick commented on JBIDE-5700: ------------------------------------------ Snjeza, I tried bringing up the Project Examples wizard this morning with the latest build (JBossTools-Update-3.1.0.v201002100509N-H226-CR2.zip) and all that shows up is the BPEL examples now. Are changes required for all examples before things will work again? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5700?page=com.atlassian.jira.plu... ] Brian Fitzpatrick commented on JBIDE-5700: ------------------------------------------ That's what I'm saying though... The latest build doesn't work with project examples. None of them come up but the BPEL examples. So is it possible that something isn't backward compatible with what was there? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5700?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-5700: -------------------------------------- Done. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5700?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-5700: --------------------------------------- Labels: new_and_noteworthy (was: ) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira