[
https://issues.jboss.org/browse/JBIDE-18724?page=com.atlassian.jira.plugi...
]
Victor Rubezhny commented on JBIDE-18724:
-----------------------------------------
The fix for the Upstream issue (
https://bugs.eclipse.org/bugs/show_bug.cgi?id=444545) is
split into two separated Core and UI (
https://bugs.eclipse.org/bugs/show_bug.cgi?id=448152
is created for the UI part) patches and the only its Core part will be included into WTP
3.6.2 release. As such we have to adapt it locally in JBT.
There are number of cases are possible in order to adopt JBT to the upstream fix:
1. Since no UI part will be added to WTP to control the tag name ignorance preferences, we
can force the default values (and/or even the actual values) for the Syntax Validator to
ignore all the names that match ion-* pattern. No UI is requires with this fix, all the
WTP installations are to use these preference values, but it will be impossible to change
the preferences. So, the list of tag name patterns is to be carefully defined.
2. The second solution is to create an additional preference page for the WTP Syntax
Validator preferences as well as QuickFix that allows to add tag names into ignorance list
in JBT's Ionic plug-in. This will give a user the possibility to ignore any tag names
on his own. I'd like not force the change of the default/actual values for these
preferences because otherwise it will be a behaviour opposite to the WTP one and as such
it might confuse the users.
WDYT? My +1 is for the case 1.
HTML Validation: Ability to ignore custom htm tags (e.g.
<ion-*>)
-----------------------------------------------------------------
Key: JBIDE-18724
URL:
https://issues.jboss.org/browse/JBIDE-18724
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: jsp/jsf/xml/html source editing, upstream
Reporter: Victor Rubezhny
Assignee: Victor Rubezhny
Labels: new_and_noteworthy
Fix For: 4.2.1.Final
WTP HTML validator marks any custom html tags as unknown. It's possible to disable
this validation at all: Window->Preferences->Web->HTML Files->Validation
==> Set Elements -> Unknown tag name severity to "Ignore":
!00001262.png!
But it would be useful to have ability to make HTML validator ignore some particular tags
only.
I suggest to contribute a patch to WTP to fix it.
We have already did it for attributes, so lets do it for tags too:
- New preferences with a list of ignored tags (a mask can be used)
- A new preference page to set these preferences
- QuickFix for validation problem which will add the tag name/mask to this
list/preferences
- Extension in our angular/ionic plugin which will disable validation for <ion-*>
tags.
I've filed it to bugzilla -
https://bugs.eclipse.org/bugs/show_bug.cgi?id=444545 but
we have to provide a patch for it if we want to have it done ;)
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)