[ https://issues.jboss.org/browse/JBIDE-12836?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-12836: ------------------------------------ Bounce to [~maxandersen] to discuss w/ [~mickael_istria] next week at EclipseCon Europe. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12836?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-12836: --------------------------------------------- Notes: mvn -Dtycho.mode=true help:all-profiles Profile Id: osx (Active: true , Source: pom) Profile Id: jbosstools-nightly-staging-composite (Active: false , Source: pom) Profile Id: jbosstools-nightly-staging-composite-soa-tooling (Active: false , Source: pom) Profile Id: jbosstools-staging-aggregate (Active: false , Source: pom) Profile Id: local.requirements (Active: false , Source: pom) Profile Id: local.composite (Active: false , Source: pom) Profile Id: jboss-requirements-composite-mirror (Active: false , Source: pom) Profile Id: jboss-requirements-composite-extras-mirror (Active: false , Source: pom) Profile Id: multiple.target (Active: false , Source: pom) Profile Id: unified.target (Active: false , Source: pom) Profile Id: jenkins.target (Active: false , Source: pom) Profile Id: local.target (Active: false , Source: pom) Profile Id: local.site (Active: false , Source: pom) Profile Id: applejdk (Active: false , Source: pom) Profile Id: hudson (Active: false , Source: pom) Profile Id: default (Active: false , Source: pom) Profile Id: mavenTestSkip (Active: false , Source: pom) we should get these documented, split up in "systemprofiles" i.e. applejdk/osx are autodtected., "helpers" i.e. mavenTestSkip (how is that different from normal -D props?) and those .target / mirror profiles seems to be overlapping ...which can be used together, not together? Answer questions like, why is there both an applejdk and osx profile? why is there a hudson when the system is running on jenkins ? is this profile unique for jboss servers? then should have another name. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12836?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-12836: --------------------------------------------- Found a few additional reasons for confusion/differences across dev/os's. When you run help:all-profiles you get *All* profiles, incl. what is defined in parent, but help:active-profiles only shows from settings + local pom.xml. It does *not* include the profiles enabled in the parent. The effects of the profile is though visible in the pom listed via help:effective-pom. So knowing that you realized you have to use help:effective-pom to know what is actually going on and I had a hard time figuring out why I could not see any diff when using -Punified-target or -P!unified-target or -Plocal.target and other plugins that redefines tycho-platform-configuration. The reason is that the profile named "osx" *always* defines this and it always wins because its "early" in the parent. Long explanation short: We should not redefine tycho-platform-configuration in osx and we should *not* redefine plugin setup when overriding properties would be sufficient. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12836?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-12836: --------------------------------------------- Q: Why do we set both artifactid AND classifier for target platform configuration ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12836?page=com.atlassian.jira.plugi... ] Mickael Istria commented on JBIDE-12836: ---------------------------------------- Fixing those 2 issues would remove need for any osx profile: * https://issues.jboss.org/browse/JBIDE-5418 * https://bugs.eclipse.org/bugs/show_bug.cgi?id=388084 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12836?page=com.atlassian.jira.plugi... ] Martin Malina commented on JBIDE-12836: --------------------------------------- {quote}Answer questions like, why is there both an applejdk and osx profile?{quote} I would just like to point out that these two are not exactly the same. applejdk is for Apple JDK (vendor = apple) whereas is for mac platform (os family = mac) - this could be Oracle JDK at the same time. But I'm not sure if -XstartOnFirstThread is really needed for all mac or just Apple JDK. -d32 on the other hand is only relevant for Apple JDK 1.6 which (usually) is both 32bit and 64bit (based on -d32, -d64 with an unpredictable default). Oracle JDK 1.7 on mac would fail right away with -d32 so "os family" cannot be used here. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12836?page=com.atlassian.jira.plugi... ] Martin Malina commented on JBIDE-12836: --------------------------------------- {quote}-XstartOnFirstThread is required for Carbon & Cocoa, whatever JVM is used.{quote} Ok, then it is correctly set up in the osx profile. {quote}-d32 is necessary because we don't have a 64-bits XulRunner for Mac OS X (yet). How does VPE behave on an Oracle JDK 1.7 without setting 32-bits execution?{quote} Oracle JDK 1.7 is 64bit-only. So VPE doesn't work if you use it (because of the missing 64-bit XULRunner). If you need 32bit, then you simply need to use Apple JDK 1.6. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12836?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-12836: ------------------------------------ Maybe we want to stop refactoring stuff this close to GA, and delay further improvements until we release? Or, at the very least, stop changing the parent pom in the 4.0.x branch, and reserve future hackery for master? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12836?page=com.atlassian.jira.plugi... ] Mickael Istria commented on JBIDE-12836: ---------------------------------------- @Nick Boldt: Most of the refactoring is already done. What's remaining? IMHO, we can close this issue since I can't find any new idea to improve it (yet). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12836?page=com.atlassian.jira.plugi... ] Nick Boldt resolved JBIDE-12836. -------------------------------- Resolution: Done Per [~mickael_istria]'s comments, bumping back to CR1 target and resolving. I'll let [~maxandersen] review it and close it when satisfied. Can of course do more in trunk for 4.1 release (starting in January?) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira