[ https://issues.jboss.org/browse/JBIDE-25118?page=com.atlassian.jira.plugi... ] Mat Booth commented on JBIDE-25118: ----------------------------------- * Desktop file sanity: Always waive * Elflint/Binary stripping: Usually it's because there is some unstripped or oddly built native binary in a test suite that's used to test IDE debugging functions, but seeing this error in any other case indicates a packaging error that should be fixed. I would probably leave these for manual inspection. * RPM requires/provides: Maybe leave these for manual inspection -- they usually happen due to changes in a package in response to a bug, I'm not sure how you'd programmatically give a sensible reason for the waiver. * Shell syntax: This specific case is always a false positive that could always be waived -- IMO it's probably a bug in rpmdiff mistaking tcl scripts for shell scripts. * Execshield: This may only be waived by the security response team, so may as well ignore it An extra one: * RPM changelog: https://errata.devel.redhat.com/rpmdiff/show/182461?result_id=5039897 -- Alway waive with the reason I gave there "This change is ok because package was resynchronised with the Fedora upstream" -- it turned out to be a non-trivial exercise to merge upstream and downstream changelogs without violating some arbitrary constraint that RPM imposes about changelog entry ordering, so when importing from Fedora, the changelog is simply overwritten. I don't think anyone cares because all history is still in git anyway. -- This message was sent by Atlassian JIRA (v7.2.3#72005)