[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-12999: ------------------------------------------ It turns out that Eclipse is registering its very own Authenticator (Authenticator#setDefault()). HttpUrlConnection is then invoking it if the Http response is 401. Apparently doing HttpUrlConnection#setAllowUserinteraction(false) has no effect, it does not prevent the auth dialog from popping up. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-12999: ------------------------------------- Fix Version/s: 4.0.0.CR1 (was: 4.0.0.Beta2) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-12999: ------------------------------------------ The connection dialog is *UserValidationDialog*, It is invoked by *org.eclipse.ui.internal.net.auth.NetAuthenticator*. The NetAuthenticator is contributed by *org.eclipse.ui.net* plugin to the *org.eclipse.core.net.authenticator* extension point. *org.eclipse.core.internal.net.ProxyManager* is looking for extension to this extension-point and takes the first extension it finds: {code} private Authenticator getPluggedInAuthenticator() { IExtension[] extensions = RegistryFactory.getRegistry().getExtensionPoint(Activator.ID, Activator.PT_AUTHENTICATOR).getExtensions(); if (extensions.length == 0) return null; IExtension extension = extensions[0]; IConfigurationElement[] configs = extension.getConfigurationElements(); if (configs.length == 0) { Activator.log(IStatus.ERROR, NLS.bind("Authenticator {0} is missing required fields", (new Object[] {extension.getUniqueIdentifier()})), null);//$NON-NLS-1$ return null; } try { IConfigurationElement config = configs[0]; return (Authenticator) config.createExecutableExtension("class");//$NON-NLS-1$ } catch (CoreException ex) { Activator.log(IStatus.ERROR, NLS.bind("Unable to instantiate authenticator {0}", (new Object[] {extension.getUniqueIdentifier()})), ex);//$NON-NLS-1$ return null; } } {code} and registers it as Authenticator to the HttpUrlConnection: {code} private void registerAuthenticator() { Authenticator a = getPluggedInAuthenticator(); if (a != null) { Authenticator.setDefault(a); } } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-12999: ------------------------------------------ There is an extensive discussion about the shortcomings in NetAuthenticator in the following unresolved Eclipse bugzilla: https://bugs.eclipse.org/bugs/show_bug.cgi?id=196780 It turns out that the current Eclipse implementation was done to provide transparent support for proxies. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-12999 at 11/6/12 3:40 PM: ------------------------------------------------------------------- I paused the running threads and catched the following stack-trace: {code} Object.wait(long) line: not available [native method] Semaphore.acquire(long) line: 43 UISynchronizer.syncExec(Runnable) line: 168 Display.syncExec(Runnable) line: 4291 UserValidationDialog.getAuthentication(String, String) line: 55 NetAuthenticator.getPasswordAuthentication() line: 41 Authenticator.requestPasswordAuthentication(String, InetAddress, int, String, String, String, URL, Authenticator$RequestorType) line: 300 HttpURLConnection$1.run() line: 359 [local variables unavailable] AccessController.doPrivileged(PrivilegedAction<T>) line: not available [native method] HttpURLConnection.privilegedRequestPasswordAuthentication(String, InetAddress, int, String, String, String, URL, Authenticator$RequestorType) line: 355 DelegateHttpsURLConnection(HttpURLConnection).getServerAuthentication(AuthenticationHeader) line: 1922 DelegateHttpsURLConnection(HttpURLConnection).getInputStream() line: 1282 [local variables unavailable] HttpsURLConnectionImpl.getInputStream() line: 234 [local variables unavailable] UrlConnectionHttpClient.get(URL) line: 94 RestService.request(URL, HttpMethod, Map<String,Object>) line: 139 RestService.request(String, HttpMethod, Map<String,Object>) line: 97 RestService.request(Link, Map<String,Object>) line: 91 RestService.request(Link, ServiceParameter...) line: 76 APIResource$GetUserRequest(AbstractOpenShiftResource$ServiceRequest).execute(ServiceParameter...) line: 137 APIResource$GetUserRequest.execute() line: 234 APIResource.getUser() line: 93 Connection.createUser() line: 239 Connection.connect() line: 218 ConnectionWizardPageModel.connect() line: 244 ConnectionWizardPage$ConnectJob.run(IProgressMonitor) line: 455 Worker.run() line: 53 {code} was (Author: adietish): It paused the running threads and catched the following stack-trace: {code} Object.wait(long) line: not available [native method] Semaphore.acquire(long) line: 43 UISynchronizer.syncExec(Runnable) line: 168 Display.syncExec(Runnable) line: 4291 UserValidationDialog.getAuthentication(String, String) line: 55 NetAuthenticator.getPasswordAuthentication() line: 41 Authenticator.requestPasswordAuthentication(String, InetAddress, int, String, String, String, URL, Authenticator$RequestorType) line: 300 HttpURLConnection$1.run() line: 359 [local variables unavailable] AccessController.doPrivileged(PrivilegedAction<T>) line: not available [native method] HttpURLConnection.privilegedRequestPasswordAuthentication(String, InetAddress, int, String, String, String, URL, Authenticator$RequestorType) line: 355 DelegateHttpsURLConnection(HttpURLConnection).getServerAuthentication(AuthenticationHeader) line: 1922 DelegateHttpsURLConnection(HttpURLConnection).getInputStream() line: 1282 [local variables unavailable] HttpsURLConnectionImpl.getInputStream() line: 234 [local variables unavailable] UrlConnectionHttpClient.get(URL) line: 94 RestService.request(URL, HttpMethod, Map<String,Object>) line: 139 RestService.request(String, HttpMethod, Map<String,Object>) line: 97 RestService.request(Link, Map<String,Object>) line: 91 RestService.request(Link, ServiceParameter...) line: 76 APIResource$GetUserRequest(AbstractOpenShiftResource$ServiceRequest).execute(ServiceParameter...) line: 137 APIResource$GetUserRequest.execute() line: 234 APIResource.getUser() line: 93 Connection.createUser() line: 239 Connection.connect() line: 218 ConnectionWizardPageModel.connect() line: 244 ConnectionWizardPage$ConnectJob.run(IProgressMonitor) line: 455 Worker.run() line: 53 {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-12999: ------------------------------------------ Egit uses it's own Authenticator that does not pop up a auth dialog. It tries to get the proxy-credentials from preferences (IProxyData: {code:title=org.eclipse.egit.ui.EclipseAuthenticator} class EclipseAuthenticator extends Authenticator { private final IProxyService service; EclipseAuthenticator(final IProxyService s) { service = s; } @Override protected PasswordAuthentication getPasswordAuthentication() { final IProxyData[] data = service.getProxyData(); if (data == null) return null; for (final IProxyData d : data) { if (d.getUserId() == null || d.getHost() == null) continue; if (d.getPort() == getRequestingPort() && hostMatches(d)) return auth(d); } return null; } private PasswordAuthentication auth(final IProxyData d) { final String user = d.getUserId(); final String pass = d.getPassword(); final char[] passChar = pass != null ? pass.toCharArray() : new char[0]; return new PasswordAuthentication(user, passChar); } private boolean hostMatches(final IProxyData d) { try { final InetAddress dHost = InetAddress.getByName(d.getHost()); InetAddress rHost = getRequestingSite(); if (rHost == null) rHost = InetAddress.getByName(getRequestingHost()); return dHost.equals(rHost); } catch (UnknownHostException err) { return false; } } } {code} It registers it when the EGit UI plugin gets activated: {code:title=org.eclipse.egit.ui.Activator} private void setupProxy(final BundleContext context) { final ServiceReference proxy; proxy = context.getServiceReference(IProxyService.class.getName()); if (proxy != null) { ProxySelector.setDefault(new EclipseProxySelector( (IProxyService) context.getService(proxy))); Authenticator.setDefault(new EclipseAuthenticator( (IProxyService) context.getService(proxy))); } } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-12999 at 11/6/12 4:00 PM: ------------------------------------------------------------------- Egit uses it's own Authenticator that overrides the NetAuthenticator installed by org.eclipse.ui. This Authenticator does not pop up a auth dialog, it tries to get the proxy-credentials from preferences (IProxyData): {code:title=org.eclipse.egit.ui.EclipseAuthenticator} class EclipseAuthenticator extends Authenticator { private final IProxyService service; EclipseAuthenticator(final IProxyService s) { service = s; } @Override protected PasswordAuthentication getPasswordAuthentication() { final IProxyData[] data = service.getProxyData(); if (data == null) return null; for (final IProxyData d : data) { if (d.getUserId() == null || d.getHost() == null) continue; if (d.getPort() == getRequestingPort() && hostMatches(d)) return auth(d); } return null; } private PasswordAuthentication auth(final IProxyData d) { final String user = d.getUserId(); final String pass = d.getPassword(); final char[] passChar = pass != null ? pass.toCharArray() : new char[0]; return new PasswordAuthentication(user, passChar); } private boolean hostMatches(final IProxyData d) { try { final InetAddress dHost = InetAddress.getByName(d.getHost()); InetAddress rHost = getRequestingSite(); if (rHost == null) rHost = InetAddress.getByName(getRequestingHost()); return dHost.equals(rHost); } catch (UnknownHostException err) { return false; } } } {code} It registers it when the EGit UI plugin gets activated: {code:title=org.eclipse.egit.ui.Activator} private void setupProxy(final BundleContext context) { final ServiceReference proxy; proxy = context.getServiceReference(IProxyService.class.getName()); if (proxy != null) { ProxySelector.setDefault(new EclipseProxySelector( (IProxyService) context.getService(proxy))); Authenticator.setDefault(new EclipseAuthenticator( (IProxyService) context.getService(proxy))); } } {code} Since we're using EGit it could be simply enough to ensure EGit UI plugin is started. was (Author: adietish): Egit uses it's own Authenticator that does not pop up a auth dialog. It tries to get the proxy-credentials from preferences (IProxyData: {code:title=org.eclipse.egit.ui.EclipseAuthenticator} class EclipseAuthenticator extends Authenticator { private final IProxyService service; EclipseAuthenticator(final IProxyService s) { service = s; } @Override protected PasswordAuthentication getPasswordAuthentication() { final IProxyData[] data = service.getProxyData(); if (data == null) return null; for (final IProxyData d : data) { if (d.getUserId() == null || d.getHost() == null) continue; if (d.getPort() == getRequestingPort() && hostMatches(d)) return auth(d); } return null; } private PasswordAuthentication auth(final IProxyData d) { final String user = d.getUserId(); final String pass = d.getPassword(); final char[] passChar = pass != null ? pass.toCharArray() : new char[0]; return new PasswordAuthentication(user, passChar); } private boolean hostMatches(final IProxyData d) { try { final InetAddress dHost = InetAddress.getByName(d.getHost()); InetAddress rHost = getRequestingSite(); if (rHost == null) rHost = InetAddress.getByName(getRequestingHost()); return dHost.equals(rHost); } catch (UnknownHostException err) { return false; } } } {code} It registers it when the EGit UI plugin gets activated: {code:title=org.eclipse.egit.ui.Activator} private void setupProxy(final BundleContext context) { final ServiceReference proxy; proxy = context.getServiceReference(IProxyService.class.getName()); if (proxy != null) { ProxySelector.setDefault(new EclipseProxySelector( (IProxyService) context.getService(proxy))); Authenticator.setDefault(new EclipseAuthenticator( (IProxyService) context.getService(proxy))); } } {code} Since we're using EGit it could be simply enough to ensure EGit UI plugin is started. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-12999: ------------------------------------- Workaround Description: * cancel auth dialog * go to Console->Host OSGI Console. At the command prompt, start EGit UI plugin manually: start org.eclipse.egit.ui was: * cancel auth dialog * go to Console->Host OSGI Console. At the command prompt, start EGit UI plugin: start org.eclipse.egit.ui -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-12999: ------------------------------------------ btw. Eclipse Scout (https://dev.eclipse.org/svnroot/technology/org.eclipse.scout/scout.rt/bra...) also installs the EclipseAuthenticator when it's plugin gets started. The actually use their own copy EclipseAuthenticator. {code:title=org.eclipse.scout.net.NetActivator} public void start(BundleContext context) throws Exception { super.start(context); plugin = this; String debugText = context.getProperty(PLUGIN_ID + ".debug"); DEBUG = (debugText != null && debugText.equalsIgnoreCase("true")); String proxyDetectionText = context.getProperty(PLUGIN_ID + ".proxy.autodetect"); PROXY_AUTODETECTION = (proxyDetectionText == null || proxyDetectionText.equalsIgnoreCase("true")); // setup java.net m_oldProxySelector = ProxySelector.getDefault(); m_oldCookieHandler = CookieHandler.getDefault(); if (PROXY_AUTODETECTION) { ProxySelector.setDefault(m_newProxySelector = new EclipseProxySelector()); } CookieManager.setDefault(m_newCookieHandler = new CookieManager(null, CookiePolicy.ACCEPT_ALL)); Authenticator.setDefault(new EclipseAuthenticator()); } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-12999: ------------------------------------------ @Max: please review my pull-request -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim reassigned JBIDE-12999: ---------------------------------------- Assignee: Max Rydahl Andersen (was: Andre Dietisheim) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-12999: ------------------------------------------ There's another variant of overriding the org.eclipse.ui NetAuthenticator: ECF does this, too. It overrides any Authenticator that may be present in Eclipse and installs its own that would not lookup the eclipse proxy preferences: {code:title=org.eclipse.ecf.provider.filetransfer.browse.URLFileSystemBrowser} protected void setupAuthentication() throws IOException, UnsupportedCallbackException { if (connectContext == null) return; final CallbackHandler callbackHandler = connectContext.getCallbackHandler(); if (callbackHandler == null) return; final NameCallback usernameCallback = new NameCallback(USERNAME_PREFIX); final ObjectCallback passwordCallback = new ObjectCallback(); // Call callback with username and password callbacks callbackHandler.handle(new Callback[] {usernameCallback, passwordCallback}); username = usernameCallback.getName(); Object o = passwordCallback.getObject(); if (!(o instanceof String)) throw new UnsupportedCallbackException(passwordCallback, Messages.UrlConnectionRetrieveFileTransfer_UnsupportedCallbackException); password = (String) passwordCallback.getObject(); // Now set authenticator to our authenticator with user and password Authenticator.setDefault(new UrlConnectionAuthenticator()); } class UrlConnectionAuthenticator extends Authenticator { /* (non-Javadoc) * @see java.net.Authenticator#getPasswordAuthentication() */ protected PasswordAuthentication getPasswordAuthentication() { return new PasswordAuthentication(username, password.toCharArray()); } } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim reassigned JBIDE-12999: ---------------------------------------- Assignee: Andre Dietisheim (was: Max Rydahl Andersen) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-12999: ------------------------------------------ the EclipseAuthenticator in EGit is using the proxy credentials from the preferences. The default NetAuthenticator is not using them, it simply pops up a dialog for the user to provide thos. I'm not very sure about ECF doing the same, I couldn't spot them looking up. The only shortcoming I spot for OpenShift (since we're using the EGit EclipseAuthenticator) is that you can't be sure that noone overrides the EGit Authenticator. We simply make sure EGit UI is started when we pop up the connection dialog since EGit UI bundle activator installs the EclipseAuthenticator when it starts. Given it's already started another bundle with its very own Authenticator could override the EclipseAuthenticator. The user would then get stuck again if that Authenticator does funky stuff... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-12999 at 11/8/12 5:12 AM: ------------------------------------------------------------------- The connection dialog is *UserValidationDialog*, It is invoked by *org.eclipse.ui.internal.net.auth.NetAuthenticator*. The NetAuthenticator is contributed by *org.eclipse.ui.net* plugin to the *org.eclipse.core.net.authenticator* extension point. *org.eclipse.core.internal.net.ProxyManager* is looking for extension to this extension-point and takes the first extension it finds: {code:title=org.eclipse.core.internal.net.ProxyManager} private Authenticator getPluggedInAuthenticator() { IExtension[] extensions = RegistryFactory.getRegistry().getExtensionPoint(Activator.ID, Activator.PT_AUTHENTICATOR).getExtensions(); if (extensions.length == 0) return null; IExtension extension = extensions[0]; IConfigurationElement[] configs = extension.getConfigurationElements(); if (configs.length == 0) { Activator.log(IStatus.ERROR, NLS.bind("Authenticator {0} is missing required fields", (new Object[] {extension.getUniqueIdentifier()})), null);//$NON-NLS-1$ return null; } try { IConfigurationElement config = configs[0]; return (Authenticator) config.createExecutableExtension("class");//$NON-NLS-1$ } catch (CoreException ex) { Activator.log(IStatus.ERROR, NLS.bind("Unable to instantiate authenticator {0}", (new Object[] {extension.getUniqueIdentifier()})), ex);//$NON-NLS-1$ return null; } } {code} and registers it as Authenticator to the HttpUrlConnection: {code} private void registerAuthenticator() { Authenticator a = getPluggedInAuthenticator(); if (a != null) { Authenticator.setDefault(a); } } {code} was (Author: adietish): The connection dialog is *UserValidationDialog*, It is invoked by *org.eclipse.ui.internal.net.auth.NetAuthenticator*. The NetAuthenticator is contributed by *org.eclipse.ui.net* plugin to the *org.eclipse.core.net.authenticator* extension point. *org.eclipse.core.internal.net.ProxyManager* is looking for extension to this extension-point and takes the first extension it finds: {code} private Authenticator getPluggedInAuthenticator() { IExtension[] extensions = RegistryFactory.getRegistry().getExtensionPoint(Activator.ID, Activator.PT_AUTHENTICATOR).getExtensions(); if (extensions.length == 0) return null; IExtension extension = extensions[0]; IConfigurationElement[] configs = extension.getConfigurationElements(); if (configs.length == 0) { Activator.log(IStatus.ERROR, NLS.bind("Authenticator {0} is missing required fields", (new Object[] {extension.getUniqueIdentifier()})), null);//$NON-NLS-1$ return null; } try { IConfigurationElement config = configs[0]; return (Authenticator) config.createExecutableExtension("class");//$NON-NLS-1$ } catch (CoreException ex) { Activator.log(IStatus.ERROR, NLS.bind("Unable to instantiate authenticator {0}", (new Object[] {extension.getUniqueIdentifier()})), ex);//$NON-NLS-1$ return null; } } {code} and registers it as Authenticator to the HttpUrlConnection: {code} private void registerAuthenticator() { Authenticator a = getPluggedInAuthenticator(); if (a != null) { Authenticator.setDefault(a); } } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-12999?page=com.atlassian.jira.plugi... ] Pavol Srna closed JBIDE-12999. ------------------------------ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira