[ https://jira.jboss.org/jira/browse/JBIDE-4514?page=com.atlassian.jira.plu... ] Julien Kronegg commented on JBIDE-4514: --------------------------------------- A workaround is to disable the Seam Validator for Expression language: 1. Project -> Properties -> Seam Validator 2. check "Enable project specific settings" 3. for "Expression language", set all levels to "Ignore" Note: this works because as of JBIDE-604, the Seam Validator phase is optimized if all levels are set to "Ignore" for a given type (e.g. Expression language). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4514?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-4514: --------------------------------------- Even if you enable all EL validation rules in preferences? If you disabled some of them but have enabled at least one then the validator keep validating unresolved EL but just doesn't add any markers on pages. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4514?page=com.atlassian.jira.plu... ] Julien Kronegg commented on JBIDE-4514: --------------------------------------- Enabling all EL validation rules: you were right. The "Context variable cannot be resolved" validation rule was set to "Ignore". I set it back to "Warning" and warnings about parameters defined in the pages.xml appeared (BTW I think this is a bug). Having an option to disable re-validation of unresolved ELs would be useful. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4514?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-4514: -------------------------------------------- Currently we scan all .xhtml with unresolved variables when we save a file, correct ? Could we limit that scan to those .xhtml who actually have unresolved variables that matches the names that are in the .java file being saved ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4514?page=com.atlassian.jira.plu... ] Alexey Kazakov resolved JBIDE-4514. ----------------------------------- Resolution: Done Fixed. Julien, please let us know if it helps. Btw I commited changes for this issue with comments for JBIDE-4512 by mistake. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4514?page=com.atlassian.jira.plu... ] Alexey Kazakov updated JBIDE-4514: ---------------------------------- Attachment: screenshot-1.jpg -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4514?page=com.atlassian.jira.plu... ] Julien Kronegg commented on JBIDE-4514: --------------------------------------- Ok, understood. But I still cannot find the new parameter in 3.1.0.M2-N200906231801-H289. As of your screenshot-1.jpg, I expected to find commits in the org.jboss.tools.seam.ui plugin, e.g. http://fisheye.jboss.org/browse/JBossTools/trunk/seam/plugins/org.jboss.t... or http://fisheye.jboss.org/browse/JBossTools/trunk/seam/plugins/org.jboss.t... Am I wrong, or are some commits missing? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4514?page=com.atlassian.jira.plu... ] Julien Kronegg commented on JBIDE-4514: --------------------------------------- I tested on CRUD application with 360 .xhtml/.page.xml files, and edited one Java file without Seam component, then edited one Java file with a Seam component (EntityHome) . The EntityHome @Name and its @In properties (3 of them) are referred in 52 page.xml files and 8 xhtml files. There are 183 xhtml files with "Context variable cannot be resolved". Before each test, the project is cleaned and all files are automatically validated (validation duration is taken into account at this point. 3.0.1.GA-R200905070146-H18 (default Seam Validator configuration) When editing/saving the Java file without Seam component: 25 seconds When editing/saving the Java file with EntityHome: 25 seconds 3.1.0.M2-N200906231801-H289 (default Seam Validator configuration) When editing/saving the Java file without Seam component: almost immediate validation (less than one second) When editing/saving the Java file with EntityHome: 5 seconds 3.1.0.M2-N200906241801-H293 (default Seam Validator configuration) When editing/saving the Java file without Seam component: almost immediate validation (less than one second) When editing/saving the Java file with EntityHome: 5 seconds After unchecking "Revalidate unresolved ELs automatically", the Seam Validator duration did not change. After unchecking all checkboxes and setting each level to Ignore in "Expression language"; when editing/saving the Java file with EntityHome: almost immediate validation (less than one second) Thank you Alexey for the fix. You saved our team a lot of time. But the 5 seconds is still a lot for a simple save operation. Let's have a try for some days, then we can come back to the workaround of disabling "Expression language" validations. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-4514?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-4514: --------------------------------------- Julien, please look at https://jira.jboss.org/jira/browse/JBIDE-4545. The fix for that issue should help to improve performance of Seam validator. If you will have an opportunity to verify the latest 3.1.0M3 build (I'm not sure if it's avaliable right now) it woulb be grate. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira