[ https://jira.jboss.org/jira/browse/JBIDE-5920?page=com.atlassian.jira.plu... ] Yura Zhishko updated JBIDE-5920: -------------------------------- Attachment: Patch.patch Patch is attached. Slava, please, check it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5920?page=com.atlassian.jira.plu... ] Viacheslav Kabanovich commented on JBIDE-5920: ---------------------------------------------- I think the patch proposed does not solve the problem correctly. Web descriptor for the project defines two url-patterns, *.jsf and /faces/*. In this case JSFUrlPattern created by PatternLoader is CompoundPattern that contains both PostfixUrlPattern (for *.jsf) and PrefixUrlPattern (for /faces/). So, method getJSFPaths(String url) should be implemented in CompoundPattern by collecting results returned by this method on member patterns. CompoundPattern: public List<String> getJSFPaths(String url) { List<String> result = new ArrayList<String>(); for (JSFUrlPattern pattern: patterns) { result.addAll(pattern.getJSFPaths(url)); } return result; } As to PrefixUrlPattern, its getJSFPaths method, of course, should be implemented, however, not by adding variable url as is, but by making use of getJSFPath method: PrefixUrlPattern: public List<String> getJSFPaths(String url) { List<String> result = new ArrayList<String>(); String path = getJSFPath(url); if(path != null && path.length() > 0) result.add(path); return result; } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5920?page=com.atlassian.jira.plu... ] Yura Zhishko commented on JBIDE-5920: ------------------------------------- I have checked a patch and found one more situation when an OpenOn doesn't work. 1) Use the same project from description 2) Open index.jsp page 3) Make an OpenOn on welcome.jsf ASSERT: welcome.xhtml page should be opened. ASSERT FAILED: welcome.xhtml isn't opened. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5920?page=com.atlassian.jira.plu... ] Maxim Areshkau reassigned JBIDE-5920: ------------------------------------- Assignee: Yura Zhishko (was: Viacheslav Kabanovich) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5920?page=com.atlassian.jira.plu... ] Maxim Areshkau commented on JBIDE-5920: --------------------------------------- Start progress is usefull to click when start work on issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira