[ https://jira.jboss.org/jira/browse/JBIDE-6248?page=com.atlassian.jira.plu... ] Vlado Pakan updated JBIDE-6248: ------------------------------- Description: .brl files from Guvnor Repository examples are opened as read-only but it's possible to modified them via .brl file editor in JBT. It's even possible to save modified file and everything looks correctly saved. But when file is reopened there are no changes saved. It should not be possible to edit read-only .brl file. 1. deploy guvnor to server and start server 2. open guvnor perspective 3. add default guvnor repository connection using Guvnor Repositories view 4. right click on newly created Guvnor connection and open Guvnor Console 5. choose ok to empty login dialog and click yes to install Guvnor examples 6. open <Guvnor connection> > pacakges > mortages > CheckBoxDslRule.brl file from Guvnor Repositories view 7. add new free form drl to condition save button gets enabled file looks like modified 8. save file everything looks like file is saved 9. Reopen the file and changes are not saved was: .dsl files from Guvnor Repository examples are opened as read-only but it's possible to modified them via .dsl file editor in JBT. When trying to save this read-only file JBT display this error: Save Failed org.guvnor.tools.utils.StringInput cannot be cast to org.eclipse.ui.part.FileEditorInput It should not be possible to modify read-only .dsl file. Steps to reproduce: 1. deploy guvnor to server and start server 2. open guvnor perspective 3. add default guvnor repository connection using Guvnor Repositories view 4. right click on newly created Guvnor connection and open Guvnor Console 5. choose ok to empty login dialog and click yes to install Guvnor examples 6. open <Guvnor connection> > pacakges > mortages > ApplicantDsl.dsl file from Guvnor Repositories view 7. select first expresion in opened ApplicantDsl.dsl file and click on edit button 8. click on OK button in Edit Language Mappiing dialog. It's not necessary to make any changes. 9. Choose save for ApplicantDsl.dsl file and error mentioned above is displayed -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-6248?page=com.atlassian.jira.plu... ] Denny Xu commented on JBIDE-6248: --------------------------------- I think there are three optional solutions: 1. change the rule editor to make the .brl files in remote Guvnor Repository to accept the changes from Rule editor, so the file is not read-only any more 2. Disabled the Save button when editing .brl file from Repository 3. Don't disabled the Save button, when the user try to save the read-only file, pop up a warning message dialog tell the user that the file is not saveable. which option is correct, or is there any other options for it? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-6248?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-6248: -------------------------------------------- isnt JBIDE-6248 and JBIDE-6245 the exact same issue ? Simply mimick what is done for Java editors in Eclipse. If you start typing it will prompt you for if you want to make the file writeable and if that is not possible it will fail and inform you about it and won't let you edit the content. if it is doable then it will toggle the read only attribute and you can edit the file. (I was actually expecting this to be builtin by default into eclipse so should investigate if it is the specific editor that is having problems or the FileInputStorage from Guvnor that is simply reporting false information) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-6248?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-6248: -------------------------------------------- i.e. what shouldn't happen is that editors have to know about Guvnor repositories. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6248?page=com.atlassian.jira.plugin.s... ] Kris Verlaenen updated JBIDE-6248: ---------------------------------- Fix Version/s: LATER (was: 3.2.x) (was: 3.1.x) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira