[ https://jira.jboss.org/browse/JBIDE-7532?page=com.atlassian.jira.plugin.s... ] Dmitry Geraskov edited comment on JBIDE-7532 at 11/11/10 9:07 AM: ------------------------------------------------------------------ I think it will be useful if I describe all the fixed errors(they all related to ant tests); 1. In AntHibernateToolTest we should check log for exceptions after calling of "executeTarget(target)" because for ex. SQLExceptions were added to the log but aren't thrown and we are not informed about the problems. 2. When we called <delete dir="../../testdb".../> it often was not deleted because of the file lock and db became broken. This broke all the next junits with error "User SA not found". That is why the function was extracted from "cleanup" and moved to "removeDirs" so we could call it in the circle. 3. There was a missprint in AntHibernateToolTest#testJPABogusPUnit. "jpa-boguspunit" should be executed. 4. Libraries and classpathes were updated for current versions. 5. Sql's contained the following errors: a) "Insert table" replaced with "insert into" b) Double quotes were changed to sinle quotes in "insert into" otherwise the queries are wrong. c) there is no table "column" but there was "drop table colum;", from other side there was no "drop table topdown;" 6. Javac task couldn't find javac compiler when tests are run from maven, but worked for Eclipse. Added "fork="true"" attribute so it use external compiler. 7. Version.properties was copied from "hibernate" repository. was (Author: dgeraskov): I think it will be useful if I describe all the fixed errors(they all related to ant tests); 1. In AntHibernateToolTest we should check log for exceptions after calling of "executeTarget(target)" because for ex. SQLExceptions added to the log but aren't thrown and we are not informed about the problems. 2. When we called <delete dir="../../testdb" failonerror="true"/> it often was not deleted because of the file lock and db became broken. This broken all the next junits with error "User SA not found". That is why the function was extracted from "cleanup" and moved to "removeDirs" so we could call it in the circle. 3. There was a missprint in AntHibernateToolTest#testJPABogusPUnit. "jpa-boguspunit" should be executed. 4. Libraries and classpathes were updated for current versions. 5. Sql's contained the following errors: a) "Insert table" replaced with "insert into" b) Double quotes were changed to sinle quotes in "insert into" otherwise the queries are wrong. c) there is no table "column" but there was "drop table colum;", from other side there was no "drop table topdown;" 6. Javac task couldn't find javac compiler when tests are run from maven, but worked for Eclipse. Added "fork="true"" attribute so it use external compiler. 7. Version.properties was copied from "hibernate" repository. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7532?page=com.atlassian.jira.plugin.s... ] Max Andersen resolved JBIDE-7532. --------------------------------- Resolution: Done this was committed last night! -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira