[JBoss JIRA] Created: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
1:44 p.m.
Filter wizard/Database Collector should correctly identify catalog, schema, and tables
even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Reporter: Michael Walker
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in the
fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be the
case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the incorrect
naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:44 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Michael Walker updated JBIDE-6396:
----------------------------------
Attachment: JBIDE-tablename-with-dots-patch-mpw.txt
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Reporter: Michael Walker
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:21 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Vitali Yemialyanchyk updated JBIDE-6396:
----------------------------------------
Affects Version/s: 3.1.0.GA
Component/s: Hibernate
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:21 p.m.
New subject: [JBoss JIRA] Assigned: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Vitali Yemialyanchyk reassigned JBIDE-6396:
-------------------------------------------
Assignee: Max Rydahl Andersen
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Max Rydahl Andersen
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:25 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Vitali Yemialyanchyk commented on JBIDE-6396:
---------------------------------------------
note: this patch for Hibernate Tools core - so right jira is here ->
http://opensource.atlassian.com/projects/hibernate/browse/HBX
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Max Rydahl Andersen
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:55 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Max Rydahl Andersen commented on JBIDE-6396:
--------------------------------------------
Michael, doesn't this patch breaks down if catalog or schema has .'s in them ?
btw. Fixing qualifier method wouldn't be the right solution since that is qualifier in
the java package sense used many other places where its correct.
should be relaying the qualifiication to the metadatadialect I guess.
...and shouldn't these things be quoted to be deterministic ? (trying to understand
how MetaMatrix detects this properly)
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Max Rydahl Andersen
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:31 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Michael Walker commented on JBIDE-6396:
---------------------------------------
Agreed -- this would break down if the catalog or schema contains dots. For MetaMatrix, it
just so happens that only table names can contain dots, so this fix works.
I also agree that a better fix would add quotes around the catalog and schema name to be
deterministic.
And, as you suggest, the very best fix should actually use MetaDataDialect to determine
the proper naming, since the implementation of 'dot' and 'quote' can
actually be database-specific, and may or may not be supported by the database.
Ideally, we should be referring to the JDBC methods
DatabaseMetadata.getIdentifierQuoteString() to determine the 'quote', and
DatabaseMetaData.getCatalogSeparator() to determine the 'dot'.
SquirrelSQL's source code has one example of how to do it:
http://squirrel-sql.svn.sourceforge.net/viewvc/squirrel-sql/trunk/sql12/f...
Perhaps we could add a new method to (JDBC)MetaDataDialect to produce the qualified name.
Then, JDBCReader would pass the qualified name along to
DefaultDatabaseCollection.addTable. AbstractMetaDataDialect does have a
"needQuote" method, but it doesn't currently examine the DBMD, nor does it
provide the quote character that should be used.
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Max Rydahl Andersen
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:21 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Max Rydahl Andersen updated JBIDE-6396:
---------------------------------------
Fix Version/s: 3.2.0.M2
in M2 since this sounds like being need for Teeid?
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Max Rydahl Andersen
Fix For: 3.2.0.M2
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:47 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Max Rydahl Andersen updated JBIDE-6396:
---------------------------------------
Assignee: Dmitry Geraskov (was: Max Rydahl Andersen)
dimitry, can you take a look at this one?
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Fix For: 3.2.0.M2
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:59 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Denis Golovin updated JBIDE-6396:
---------------------------------
Fix Version/s: 3.2.0.Beta
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Fix For: 3.2.0.M2, 3.2.0.Beta
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:19 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Denis Golovin updated JBIDE-6396:
---------------------------------
Fix Version/s: (was: 3.2.0.M2)
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Fix For: 3.2.0.Beta
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:36 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Dmitry Geraskov commented on JBIDE-6396:
----------------------------------------
There are many problems which should be fixed by one shot:
1. AbstractMetaDataDialect#needQuote() should be altered with line
if(name.indexOf('.')>0) return true;
2. JDBCReader calls DefaultDatabaseCollector#addTable with quoted schema and table name
(after fix point1) and that is why Table.qualify(catalog, schema, name) also returns
quoted key,
but DefaultDatabaseCollector#getTable() called everywhere with non-quoted strings.
Note the code expects quoted schema and table, but not expects quoted catalog.
3. The fix of Michael
4. I didn't find any references for DefaultDatabaseCollector#getQualifierEntries, but
the key of the map is also potentially quoted
5. Plugins - most likely some changes in TableFilterView are also required
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Fix For: 3.2.0.Beta
Attachments: JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:44 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Dmitry Geraskov updated JBIDE-6396:
-----------------------------------
Attachment: JBIDE-6396.txt
Fix with unitests attached.
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Fix For: 3.2.0.Beta
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:03 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Dmitry Geraskov commented on JBIDE-6396:
----------------------------------------
Seems AutoQuoteTest failed with this patch, so need to fix.
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Fix For: 3.2.0.Beta
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:31 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Dmitry Geraskov updated JBIDE-6396:
-----------------------------------
Fix Version/s: 3.2.0.Beta2
(was: 3.2.0.Beta1)
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Fix For: 3.2.0.Beta2
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:41 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Dmitry Geraskov updated JBIDE-6396:
-----------------------------------
Attachment: Patch2.zip
I added to implementations of DatabaseCollector
(AbstractDatabaseCollector/DefaultDatabaseCollector/MappingsDatabaseCollector) dependency
from MetaDataDialect. This allowed me to use it to calculate always the same key for
triple(catalog,schema,name).
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Fix For: 3.2.0.Beta2
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:16 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Dmitry Geraskov commented on JBIDE-6396:
----------------------------------------
Another solution is to use unquote() method in DatabaseCollector implementations to
generate always the same key for the triple (catalog,schema,name).(only names with dots
will have potentially non-unique problem)
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Fix For: 3.2.0.Beta2
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:01 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Dmitry Geraskov updated JBIDE-6396:
-----------------------------------
Attachment: patch3.txt
patch2.zip is a wrong attachement. See patch3.txt
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Fix For: 3.2.0.CR1
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip,
patch3.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:01 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://jira.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin.s...
]
Dmitry Geraskov updated JBIDE-6396:
-----------------------------------
Fix Version/s: 3.2.0.CR1
(was: 3.2.0.Beta2)
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://jira.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Fix For: 3.2.0.CR1
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip,
patch3.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:42 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://issues.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin...
]
Max Andersen commented on JBIDE-6396:
-------------------------------------
marked as critical since if autoquote test fails many db schemas are no longer possible to
reverse engineer
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://issues.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Max Andersen
Priority: Critical
Fix For: 3.2.0.CR1
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip,
patch3.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:42 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://issues.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin...
]
Max Andersen updated JBIDE-6396:
--------------------------------
Priority: Critical (was: Major)
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://issues.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Max Andersen
Priority: Critical
Fix For: 3.2.0.CR1
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip,
patch3.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:54 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://issues.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin...
]
Max Rydahl Andersen updated JBIDE-6396:
---------------------------------------
Assignee: Dmitry Geraskov (was: Max Rydahl Andersen)
assigned to Dima for reexamination.
if patch3.txt is what we go for then the quote method should at least be protected.
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://issues.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Priority: Critical
Fix For: 3.2.0.CR1
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip,
patch3.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:41 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://issues.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin...
]
Dmitry Geraskov resolved JBIDE-6396.
------------------------------------
Resolution: Done
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://issues.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Priority: Critical
Fix For: 3.2.0.CR1
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip,
patch3.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:46 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://issues.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin...
]
Vitali Yemialyanchyk commented on JBIDE-6396:
---------------------------------------------
the fix result is -> JBIDE-8155
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://issues.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Priority: Critical
Fix For: 3.2.0.CR1
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip,
patch3.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:24 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://issues.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin...
]
Jiri Peterka commented on JBIDE-6396:
-------------------------------------
Michael, could you please verify fixed version against any MetaMatrix db?
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://issues.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Priority: Critical
Fix For: 3.2.0.CR1
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip,
patch3.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:44 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://issues.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin...
]
Dmitry Geraskov updated JBIDE-6396:
-----------------------------------
Fix Version/s: 3.3.x
Updated fix version
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://issues.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Priority: Critical
Fix For: 3.2.0.CR1, 3.3.x
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip,
patch3.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:26 a.m.
New subject: [JBoss JIRA] Closed: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://issues.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin...
]
Jiri Peterka closed JBIDE-6396.
-------------------------------
Closing this jira. Michael, if you still have issues here, please reopen
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://issues.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Priority: Critical
Fix For: 3.2.0.CR1, 3.3.x
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip,
patch3.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:19 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://issues.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin...
]
Dmitry Geraskov resolved JBIDE-6396.
------------------------------------
Fix Version/s: 3.3.0.M1
(was: 3.3.x)
Resolution: Done
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://issues.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Priority: Critical
Fix For: 3.3.0.M1, 3.2.0.CR1
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip,
patch3.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:20 a.m.
New subject: [JBoss JIRA] Closed: (JBIDE-6396) Filter wizard/Database Collector should correctly identify catalog, schema, and tables even when tables contain dots (".") in the name
[
https://issues.jboss.org/browse/JBIDE-6396?page=com.atlassian.jira.plugin...
]
Jiri Peterka closed JBIDE-6396.
-------------------------------
Filter wizard/Database Collector should correctly identify catalog,
schema, and tables even when tables contain dots (".") in the name
--------------------------------------------------------------------------------------------------------------------------------------
Key: JBIDE-6396
URL: https://issues.jboss.org/browse/JBIDE-6396
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Hibernate
Affects Versions: 3.1.0.GA
Reporter: Michael Walker
Assignee: Dmitry Geraskov
Priority: Critical
Fix For: 3.2.0.CR1, 3.3.0.M1
Attachments: JBIDE-6396.txt, JBIDE-tablename-with-dots-patch-mpw.txt, Patch2.zip,
patch3.txt
The DefaultDatabaseCollector uses StringHelper.qualifier(String) to determine the catalog
and schema name for each table, given the fully-qualified name.
StringHelper.qualifier() assumes that everything proceeding the final "." in
the fully-qualified name represents the qualifier.
This assumption breaks down if a table contains a dot in the name. This is found to be
the case when working with MetaMatrix (and possibly Teiid).
The result is that the Filter Wizard will generate invalid filters, based on the
incorrect naming of catalog and schema for each table.
As a fix, I modified DefaultDatabaseCollector to form the qualifier by using the known
catalog and schema, rather than by using the StringHelper.qualifier method. I rebuilt
tools and verified that this fixed the problem when working with MetaMatrix.
This may be better addressed by changing the behavior of StringHelper.qualifier() itself.
See forum discussion for details.
Patch attached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5385
days inactive
5766
days old
jbosstools-issues@lists.jboss.org
28 comments
7 participants
participants (7)
-
Denis Golovin (JIRA) -
Dmitry Geraskov (JIRA)
-
Jiri Peterka (JIRA)
-
Max Andersen (JIRA)
-
Max Rydahl Andersen (JIRA)
-
Michael Walker (JIRA)
-
Vitali Yemialyanchyk (JIRA)