[ https://jira.jboss.org/jira/browse/JBIDE-2561?page=com.atlassian.jira.plu... ] Vitali Yemialyanchyk commented on JBIDE-2561: --------------------------------------------- Anton why do you think this is bug? what is the expected behavior? No sense to save it - cause this is not a file editor, this is only means to test some criteria and then incorporate it into java code. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2561?page=com.atlassian.jira.plu... ] Vitali Yemialyanchyk commented on JBIDE-2561: --------------------------------------------- Once more - this is not a file editor - so if the user press save button or not - if he close the editor - he lost his changes. In general case there is no reason to save the editor content - this is obvious for anyone who will use the editor in his everyday work. So please close the issue :) If you are so details meticulous and think it's so important - I'll fix it, but please provide me expected behavior in case of "not a file editor with temporal content". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2561?page=com.atlassian.jira.plu... ] Dima Geraskov commented on JBIDE-2561: -------------------------------------- Really? Guys, don't you think that HQL editor logically the same as Criteria editor? So, if you think so, then use the following steps: 1. Open HQL Editor for any element (or input query by hand, select console configuration) 2. Go to File-> Save as 3. Select folder, enter file name 'Test.hql' and save file. 4. Close HQL editor 5. Find saved file 6. Dbl click on it Observe that HQL Editor opens with your query(console configuration can't be saved, so it is not selected) Do you agree that Criteria editor should have the same functional? His file extension is 'crit', but he can't open his files like HQL Editor. It is a bug. Aloso I think that Ctrl+S doesn't call action like File-Save As... when file save first. This is second bug. (For both editors). When we fix this bug Anton's bug becomes actual. If you agree, then, Anton, create please 2 additional bugs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2561?page=com.atlassian.jira.plu... ] Vitali Yemialyanchyk updated JBIDE-2561: ---------------------------------------- Assignee: Anton Klimkovich (was: Vitali Yemialyanchyk) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2561?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-2561: -------------------------------------------- guys! you broke this long lived functionallity. Saving the editor automatically saves back to a workspace scoped data. If you close eclipse with the edtor open and starts eclipse again the editors come back. Now Ctlr+S calls the Save As... dialog - that is not what it is supposed to do. Save As... shuold give a dialog, but ctrl+s on a non file based editing should just do as it did before. The other fixes aboout fixing .crit files and having better defaults for the save as is good. Please bring back the save to workspace - thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2561?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-2561: --------------------------------------- Fix Version/s: 3.0.0.beta1 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2561?page=com.atlassian.jira.plu... ] Max Rydahl Andersen resolved JBIDE-2561. ---------------------------------------- Fix Version/s: 3.0.0.alpha (was: 3.0.0.beta1) Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira