]
Nick Boldt commented on JBIDE-21657:
------------------------------------
p2diff will simply show which features or plugins in a given project were changed by the
PR. You could get the same information looking at the PR. Bear in mind too that each
plugin will be shown as different because its Source-Reference in MANIFEST.MF will show a
different SHA.
So, a p2diff would in fact show that ALL the features and plugins were different since
they'd have different versions in their qualifier. And if we exclude versions from the
p2diff, you'd only ever see when a NEW feature/plugin is added or a new dependency is
included in the update site.
As to not keeping these things forever...
if I put everything into /snapshots/pulls/ then the automated cleanup scripts could be
adjusted such that no more than 1 past pull request build would ever be retained, as we do
currently for builds from the branch. Self-cleaning means you'd get to see your
pull-request builds for a few days, but they'd disappear when they got sufficiently
old.
set up jobs to handle building from PRs
---------------------------------------
Key: JBIDE-21657
URL:
https://issues.jboss.org/browse/JBIDE-21657
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: build
Affects Versions: 4.3.1.Beta2, 4.4.0.Alpha1
Reporter: Nick Boldt
Assignee: Nick Boldt
Fix For: 4.3.1.CR1, 4.4.0.Alpha1
First experimental build:
https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sit...
Output:
http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-bui...
{code}
"revision" : {
"HEAD" : "bfe76fb3f3c34d68b873d0acf715e2145e4cb805",
"currentBranch" : "HEAD",
"knownReferences" : [{
"name" : "origin",
"url" :
"git://github.com/jbosstools/jbosstools-build-sites.git",
"ref" : "pr/221/merge"
}]
},
{code}
http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-bui...
{code}
#Fri Feb 05 16:42:42 EST 2016
null\:merge=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
HEAD=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
{code}
build log:
{code}
Started by upstream project
"jbosstools-build-sites.aggregate.child-sites__pull-request_master" build number
1
originally caused by:
GitHub pull request #221 of commit 50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge
conflicts.
...
Fetching upstream changes from
git://github.com/jbosstools/jbosstools-build-sites.git
> git -c core.askpass=true fetch --tags --progress
git://github.com/jbosstools/jbosstools-build-sites.git +refs/heads/*:refs/remotes/origin/*
+refs/pull/*:refs/remotes/origin/pr/*
Checking out Revision bfe76fb3f3c34d68b873d0acf715e2145e4cb805
(refs/remotes/origin/pr/221/merge)
> git config core.sparsecheckout # timeout=10
> git checkout -f bfe76fb3f3c34d68b873d0acf715e2145e4cb805
{code}
vars:
{code}
-DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
-DghprbPullId=221
-Dsha1=origin/pr/221/merge
"-DghprbPullDescription=GitHub pull request #221 of commit
50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge conflicts."
-DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
{code}