[ https://jira.jboss.org/jira/browse/JBIDE-5184?page=com.atlassian.jira.plu... ] Snjezana Peco commented on JBIDE-5184: -------------------------------------- There are a few issues that cause this memory leak: 1) JSPMultiPageEditorSite The constructor creates serviceLocator that isn't disposed. 2) The XulRunnerBrowser.dispose() method removes progressListener; it is too late because all SWT objects/controls (webBrowser too) are already disposed when calling the dispose method of an Eclipse editor. 3) MozillaEditor.getEditor() makes the Mozilla window editable using nsIEditingSession.setupEditorOnWindow() It is necessary to remove objects created by this method using nsIEditingSession.tearDownEditorOnWindow(). 4) The biggest issue is that the createPartControl() method in the MozillaEditor and MozillaPreview class creates XulRunnerEditor as an inner class. The XulRunnerEditor class is the gcroot class and retains a reference to MozillaEditor (MozillaPreview) causing MozillaEditor (MozillaPreview) not to be released. They retain references to many WST/EMF classes (about 600-700kb). I have fixed all these issues in my tree. The fix changes the following plugins: org.jboss.tools.vpe org.jboss.tools.vpe.xulrunner org.jboss.tools.jst.jsp I have tested memory leak when opening/closing the VPE editor and changing the Visual/Source page to the Preview page. Haven't tested a possibly memory leak when editing. This memory leak isn't caused by https://bugs.eclipse.org/bugs/show_bug.cgi?id=207206#c21 Max, do you agree that I commit the fix ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5184?page=com.atlassian.jira.plu... ] Snjezana Peco updated JBIDE-5184: --------------------------------- Attachment: JBIDE5184.patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5184?page=com.atlassian.jira.plu... ] Maxim Areshkau updated JBIDE-5184: ---------------------------------- Attachment: MemUsageWhenRunVPETestWithoutPatch.png eclipse mem usage diagram during VPE tests without patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5184?page=com.atlassian.jira.plu... ] Maxim Areshkau updated JBIDE-5184: ---------------------------------- Attachment: MemUsageWithPatchApplied.png eclipse mem usage diagram during VPE tests with patch applied. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5184?page=com.atlassian.jira.plu... ] Maxim Areshkau resolved JBIDE-5184. ----------------------------------- Resolution: Done Patch has been reviewed and applied. Memory has been fixed in patch. Have test for memory leaks when editing in vpe, leaks hasn't been founded. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira