[JBoss JIRA] Created: (JBIDE-7913) Top-Down ws wizard is overwriting existing unrelated ws impl classes
9:59 a.m.
Top-Down ws wizard is overwriting existing unrelated ws impl classes
--------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Brian Fitzpatrick
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:07 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-7913) Top-Down ws wizard is overwriting existing unrelated ws impl classes
[
https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin...
]
Lukas Jungmann updated JBIDE-7913:
----------------------------------
Priority: Blocker (was: Major)
Top-Down ws wizard is overwriting existing unrelated ws impl classes
--------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Brian Fitzpatrick
Priority: Blocker
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:02 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7913) Top-Down ws wizard is overwriting existing unrelated ws impl classes
[
https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin...
]
Lukas Jungmann commented on JBIDE-7913:
---------------------------------------
re myself: Bottom up case is not affected
note 1: as of now all existing implementation classes which were rewritten by ws wizard
contains wrong @WebService.serviceName and targetNamespace attributes (apart from cleaned
method implementations)
note 2: all java classes containing '@WebService(' string somewhere (can be even
in the comment, javadoc) in default java source root are being overwritten by the top-down
ws wizard if user let the wizard to use "default" package; the fix for
JBIDE-7681 eliminates some cases but real fix for this should happen in
JBossWSCreationUtils.findInPackageFragment where
'unit.getSource().contains(annotation)' (where
annotation="@WebService(") call should be replaced by something more
sophisticated - don't know if there's some API which would allow asking if a class
contains annotation of given type
Top-Down ws wizard is overwriting existing unrelated ws impl classes
--------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Brian Fitzpatrick
Priority: Blocker
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:04 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-7913) Top-Down ws wizard overwrites all java classes containing '@WebService(' string anywhere in the code
[
https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin...
]
Lukas Jungmann updated JBIDE-7913:
----------------------------------
Summary: Top-Down ws wizard overwrites all java classes containing
'@WebService(' string anywhere in the code (was: Top-Down ws wizard is
overwriting existing unrelated ws impl classes)
Top-Down ws wizard overwrites all java classes containing
'@WebService(' string anywhere in the code
----------------------------------------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Brian Fitzpatrick
Priority: Blocker
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:39 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7913) Top-Down ws wizard overwrites all java classes containing '@WebService(' string anywhere in the code
[
https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin...
]
Brian Fitzpatrick commented on JBIDE-7913:
------------------------------------------
Grid, do you have any ideas on this one?
Top-Down ws wizard overwrites all java classes containing
'@WebService(' string anywhere in the code
----------------------------------------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Feng Qian
Priority: Blocker
Fix For: 3.2.0.CR1
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:39 p.m.
New subject: [JBoss JIRA] Updated: (JBIDE-7913) Top-Down ws wizard overwrites all java classes containing '@WebService(' string anywhere in the code
[
https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin...
]
Brian Fitzpatrick updated JBIDE-7913:
-------------------------------------
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
Assignee: Feng Qian (was: Brian Fitzpatrick)
Fix Version/s: 3.2.0.CR1
Top-Down ws wizard overwrites all java classes containing
'@WebService(' string anywhere in the code
----------------------------------------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Feng Qian
Priority: Blocker
Fix For: 3.2.0.CR1
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:39 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7913) Top-Down ws wizard overwrites all java classes containing '@WebService(' string anywhere in the code
[
https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin...
]
Feng Qian commented on JBIDE-7913:
----------------------------------
Yes, to find a class by a String ' @WebService' is not good enough, but I
don't know if there is api for annotation for this. I will look into this problem to
find it.
But for note 1,
the wsconsume runtime command will generate ZwsImpl for interface Zws if you use default
package. On UI side, as if we can't resist it.
Top-Down ws wizard overwrites all java classes containing
'@WebService(' string anywhere in the code
----------------------------------------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Feng Qian
Priority: Blocker
Fix For: 3.2.0.CR1
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:53 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7913) Top-Down ws wizard overwrites all java classes containing '@WebService(' string anywhere in the code
[
https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin...
]
Lukas Jungmann commented on JBIDE-7913:
---------------------------------------
re note 1 - I'm sorry Grid but that's not true - wsconsume itself, when it is
being run from command line, does not touch anything out side of scope of packages and
sources it generates[*] and it is also not generating any implementation class. It is our
tooling who is doing that and the tooling is wrongly assuming that 'default package ==
""', it should assume that 'default package ==
toJavaPkg(/definitions[@targetNamespace])' (and the patch I attached to JBIDE-7681 is
trying to fix just this assumption). As soon as the assumption will be fixed, ZwsImpl
class won't be rewritten nor created (in case it would not exist)
[*] if user does not pass target package to it (and there are really good real world
reasons to not to do it), wsconsume simply calculates the package name from the value of
'targetNamespace' attribute in definitions element in WSDL. Although this
attribute is optional per WSDL definition, WS-I Basic Profile makes it 'required'
(and I assume that wsconsume requires it too), therefore it is unlikely that it won't
be set in the WSDL.
(http://osdir.com/ml/web.services.general/2004-02/msg00014.html)
Top-Down ws wizard overwrites all java classes containing
'@WebService(' string anywhere in the code
----------------------------------------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Feng Qian
Priority: Blocker
Fix For: 3.2.0.CR1
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:28 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7913) Top-Down ws wizard overwrites all java classes containing '@WebService(' string anywhere in the code
[
https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin...
]
Feng Qian commented on JBIDE-7913:
----------------------------------
Hi Lukas,
I have committed some codes to partly fix the problem of finding classes by String.
And
Yes, you are right, the ws impl class is generated by tools. It is my carelessness. What I
had wanted to say was like the comments in JBIDE-7681, I am thinking about how handle the
package overwrited, the class oeverwrited, and the web.xml overwrited. The packages and
classes are generated by runtime, for now I have no idea to handle them.
Yes, at the scene of this issue, we can do as you said, make the default package as
/definitions@targetNamespace. But if there is already the same name package in the
project, and there are classes in the package, how should we do?
And there are some other issues when I looked into this issue. I will go on for these
issues.
Top-Down ws wizard overwrites all java classes containing
'@WebService(' string anywhere in the code
----------------------------------------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Feng Qian
Priority: Blocker
Fix For: 3.2.0.CR1
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:38 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7913) Top-Down ws wizard overwrites all java classes containing '@WebService(' string anywhere in the code
[
https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin...
]
Lukas Jungmann commented on JBIDE-7913:
---------------------------------------
Hi Grid,
I think that the best we can do is:
-for sources generated by under lied tools (by wsconsume in particular) keep the behaviour
as it is now (in the other words let it overwrite code related to the WSDL, unrelated
sources will remain untouched), only try to add some warning (ie "Package x.y already
exists, some sources may be overwritten") for the case when to be generated package
is the same as some already existing package
-for ws implementation class generated by the IDE - if the to be generated class already
exists in the project ask user if he wants to regenerate it
-for entry in web.xml - if there is already related entry there either ask user if he
wants to replace it or automagically add new one of form <name>_1 (perhaps former
would be better)
What do you think?
Top-Down ws wizard overwrites all java classes containing
'@WebService(' string anywhere in the code
----------------------------------------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Feng Qian
Priority: Blocker
Fix For: 3.2.0.CR1
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:59 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-7913) Top-Down ws wizard overwrites all java classes containing '@WebService(' string anywhere in the code
[
https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin...
]
Feng Qian commented on JBIDE-7913:
----------------------------------
>-for sources generated by under lied tools (by wsconsume in
particular) keep the behaviour as it is now (in the other words let it overwrite code
related to the WSDL, unrelated sources will remain untouched), only >>try to add
some warning (ie "Package x.y already exists, some sources may be overwritten")
for the case when to be generated package is the same as some already existing package
the generated package would not overwrite the existing package, just generate
classes in the existing package. But the classes is truely overwrited.
And we have not a method to know the name of the package before we run the commandline
except you set a packagename. But users sometimes won't give package name, then we
don't know the name.
>for ws implementation class generated by the IDE - if the to be
generated class already exists in the project ask user if he wants to regenerate it
It's ok
>for entry in web.xml - if there is already related entry there
either ask user if he wants to replace it or automagically add new one of form
<name>_1 (perhaps former would be better)
It's ok. But when the generated
classes are some, and the servlet names are same too. If we generated a servlet with
name_1, that's means there two servlet 'name_1' and 'name' preference
a same class.
Top-Down ws wizard overwrites all java classes containing
'@WebService(' string anywhere in the code
----------------------------------------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Feng Qian
Priority: Blocker
Fix For: 3.2.0.CR1
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:04 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-7913) Top-Down ws wizard overwrites all java classes containing '@WebService(' string anywhere in the code
[
https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin...
]
Feng Qian resolved JBIDE-7913.
------------------------------
Resolution: Done
fixed.
Top-Down ws wizard overwrites all java classes containing
'@WebService(' string anywhere in the code
----------------------------------------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Feng Qian
Priority: Blocker
Fix For: 3.2.0.CR1
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:54 a.m.
New subject: [JBoss JIRA] Closed: (JBIDE-7913) Top-Down ws wizard overwrites all java classes containing '@WebService(' string anywhere in the code
[
https://issues.jboss.org/browse/JBIDE-7913?page=com.atlassian.jira.plugin...
]
Lukas Jungmann closed JBIDE-7913.
---------------------------------
v. in v20110121-0004-H124-CR1
Top-Down ws wizard overwrites all java classes containing
'@WebService(' string anywhere in the code
----------------------------------------------------------------------------------------------------
Key: JBIDE-7913
URL: https://issues.jboss.org/browse/JBIDE-7913
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Webservices
Affects Versions: 3.2.0.Beta2
Reporter: Lukas Jungmann
Assignee: Feng Qian
Priority: Blocker
Fix For: 3.2.0.CR1
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
this came up as a result of JBIDE-7681 (see comment from 12/15/10)
-create a new Dynamic web project
-create following interface there:
package x;
import javax.jws.WebService;
@WebService()
public interface Zws {
String test();
}
-create following class there:
package x;
import javax.jws.WebService;
@WebService()
public class ZwsImpl {
public String test() {
return "Hello Dolly!";
}
}
-create some Top-Down ws there using default settings package (use default package)
-open ZwsImpl.java in the editor
=>
Current: ZwsImpl class is rewritten
Expected: the class remains untouched
Note for myself: Check this also for Bottom up case
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5553
days inactive
5593
days old
jbosstools-issues@lists.jboss.org
12 comments
3 participants
participants (3)
-
Brian Fitzpatrick (JIRA) -
Feng Qian (JIRA)
-
Lukas Jungmann (JIRA)