NPE when executing JUnit tests for VPE -------------------------------------- Key: JBIDE-2074 URL: http://jira.jboss.com/jira/browse/JBIDE-2074 Project: Tools (JBoss Tools) Issue Type: Feature Request Components: Visual Page Editor Affects Versions: 2.1.0.beta1 Reporter: Snjezana Peco Assigned To: Snjezana Peco Priority: Minor Fix For: 2.1.0.cr1 The following code causes NPE in JUnit tests: // Wait while visual part is loaded Display.getCurrent().syncExec( new Runnable() { public void run() { while( Display.getCurrent().readAndDispatch() && getController()==null) { } } }); I have got the exception in the testJbideMultiple test and in some other tests. VpeTest.java, line 153 XulRunnerEditor xulRunnerEditor = vpeController.getXulRunnerEditor(); vpeController is null because the above mentioned code doesn't work correctly. The Display.getCurrent().readAndDispatch() reads and dispatches events and returns false if there isn't any. It isn't related to loading page in the XULRunner browser. The correct code that waits for the page has been loaded is the following: loaded = false; xulRunnerEditor.getBrowser().addProgressListener(new ProgressListener() { public void changed(ProgressEvent event) { } public void completed(ProgressEvent event) { loaded = true; xulRunnerEditor.getBrowser().removeProgressListener(this); } }); xulRunnerEditor.setURL(INIT_URL); // Wait while visual part is loaded while (!loaded) { if (!Display.getCurrent().readAndDispatch()) Display.getCurrent().sleep(); } Max, would you like me to commit this code? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira