[Design of JBoss Web Services] - Re: JBossWS Test Approach
by alessio.soldano@jboss.com
My point of view here is that we're evaluating this still a bit early. Let me explain, the problem here is that the AS is not completely mavenized yet. In particular the AS testsuite is not run against maven artifacts yet and that's IMHO one of the reasons why almost nobody besides us cares about updoading snapshots of the org.jboss.jbossas artifacts to the repo. Once the process will be completed (don't know when, but the work is being done even while we discuss this here now), I think we will be pretty sure we're testing against the right artifacts.
This said, the specific failures that made us to stop and think about our testing approach were caused by some mistakes we actually did in the webservice module pom.xml in the AS. IOW it didn't have the right dependencies which were instead specified in the container integration pom.xml files. Of course this caused the trunk and 5_x branch only to fail, but I fixed that. The whole "exclusion game" in the stacks' testsuite pom.xml is not required anymore, there're few dependencies still specified there and they're quite straightforward.
Finally, considering we're using maven for the project, I think it's important to run tests using surefire. IOW my point of view is that either we use this tool (maven) completely or we don't use it (which currently is not an option given the direction taken 1 year ago by the whole AS development).
Basing the tests on maven dependencies was the most natural solution when the mavenization took place, what would you suggest instead of that? I don't like that much the idea of specifying the surefire additionalClasspath with a list of jar from the curent AS... any other idea? After all, we also get advantages from using maven dependencies to build test classpath, otherwise we need keep track of jar changes (names, position), addition of jars (while we simply get the new dependency for free when somebody updates the dependency in an artifact we include), etc.
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4215771#4215771
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4215771