I just quickly wanted to run my changes for JBWS-2704 past you before I commit: - https://jira.jboss.org/jira/browse/JBWS-2704 I am also planning to follow the same pattern for JBWS-2703: - https://jira.jboss.org/jira/browse/JBWS-2703 Essentially for both of these issues the logic in DOMUtils does not take into account the specific details for each of the getElementsByTagName methods add to this the affected methods are used in many locations it is quite risky modifying the DOMUtils further without introducing other regressions. The proposed solution is to use the getChildElements method from DOMUtils to obtain all child elements and then filter the response as required by the relevent getElementsByTagName method, these changes can be seen here: - http://fisheye.jboss.org/changelog/JBossWS/?cs=10336 (The System.out.println calls have been removed :-) ) Alternatively I think the solution would be to refactory the DOMUtils implementation with a getChildElements method that takes a filter as a parameter, the filter would then be used by search to compare each element as it is visited to decide if it should be accepted by the specific rules in the filter. Regards, Darran Lofthouse. _______________________________________________ jbossws-dev mailing list jbossws-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jbossws-dev

Hi Darran, the proposed solution if fine with me. Thanks Alessio Darran Lofthouse wrote: > I just quickly wanted to run my changes for JBWS-2704 past you before > I commit: - > > https://jira.jboss.org/jira/browse/JBWS-2704 > > I am also planning to follow the same pattern for JBWS-2703: - > > https://jira.jboss.org/jira/browse/JBWS-2703 > > Essentially for both of these issues the logic in DOMUtils does not > take into account the specific details for each of the > getElementsByTagName methods add to this the affected methods are used > in many locations it is quite risky modifying the DOMUtils further > without introducing other regressions. > > The proposed solution is to use the getChildElements method from > DOMUtils to obtain all child elements and then filter the response as > required by the relevent getElementsByTagName method, these changes > can be seen here: - > > http://fisheye.jboss.org/changelog/JBossWS/?cs=10336 > (The System.out.println calls have been removed :-) ) > > Alternatively I think the solution would be to refactory the DOMUtils > implementation with a getChildElements method that takes a filter as a > parameter, the filter would then be used by search to compare each > element as it is visited to decide if it should be accepted by the > specific rules in the filter. > > Regards, > Darran Lofthouse. > _______________________________________________ > jbossws-dev mailing list > jbossws-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jbossws-dev