[JBoss JIRA] (MODCLUSTER-531) Eliminate automagic
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-531?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-531:
--------------------------------------
Fix Version/s: 1.4.0.Alpha1
> Eliminate automagic
> -------------------
>
> Key: MODCLUSTER-531
> URL: https://issues.jboss.org/browse/MODCLUSTER-531
> Project: mod_cluster
> Issue Type: Feature Request
> Components: Core & Container Integration (Java), Documentation & Demos, Native (httpd modules)
> Affects Versions: 1.2.0.Final, 1.3.0.Final
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Priority: Blocker
> Fix For: 1.4.0.Alpha1, 2.0.0.Alpha1
>
>
> I am proposing we abandon automagic as much as possible.
> h1. Problem
> The main idea for automagic is to make deployment simple and easy to migrate/transfer and provide great user experience out of box. Unfortunately, this IMHO often backfires quite significantly resulting in configurations that are:
> # insecure (listening on all interfaces, allow from all, default security key "changeme!")
> # difficult to debug (not clear what is the actual configuration)
> # unstable installations (seemingly unrelated aspects like adding an interface or connector break the previously working configuration)
> h1. Areas
> There are several areas where automagic happens.
> h5. Advertised address of the proxy
> There were multiple bugs in the past, where 0.0.0.0 would be sent in the advertise mesages, now if its not explcit in the VirtualHost or passed in to ServerAdvertise, it automagically picks a non-local interface. Such configurations should be disallowed.
> h5. Advertise interfaces - Java
> -The interfaces are not explicit and advertise messages could be sent/received on more interfaces and is subject to interface configuration which can change. This is also problematic when trying to move to DatagramChannel interface, which requires interfaces to be defined explicitly (MODCLUSTER-502). We can need to require this explicitly.- DONE
> h5. Advertise interfaces - Native
> The interfaces are not explicit and advertise messages could be sent/received on more interfaces (see MODCLUSTER-487).
> h5. Connector address
> If bound to any-address, the address is inferred from the proxy connection as the local address. This is solved in the default WildFly configuration as its explicitly bound to a interface.
> h5. Connector selection
> -This is solved in WildFly where selection is explicit. In tomcat this causes problems like MODCLUSTER-457 when WS requires http yet ajp is automatically selected by default. We can make this explicit.- DONE
> h5. Route generation
> Remove setJvmRoute from the SPI.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (MODCLUSTER-531) Eliminate automagic
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-531?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-531:
--------------------------------------
Issue Type: Feature Request (was: Enhancement)
> Eliminate automagic
> -------------------
>
> Key: MODCLUSTER-531
> URL: https://issues.jboss.org/browse/MODCLUSTER-531
> Project: mod_cluster
> Issue Type: Feature Request
> Components: Core & Container Integration (Java), Documentation & Demos, Native (httpd modules)
> Affects Versions: 1.2.0.Final, 1.3.0.Final
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Priority: Blocker
> Fix For: 2.0.0.Alpha1
>
>
> I am proposing we abandon automagic as much as possible.
> h1. Problem
> The main idea for automagic is to make deployment simple and easy to migrate/transfer and provide great user experience out of box. Unfortunately, this IMHO often backfires quite significantly resulting in configurations that are:
> # insecure (listening on all interfaces, allow from all, default security key "changeme!")
> # difficult to debug (not clear what is the actual configuration)
> # unstable installations (seemingly unrelated aspects like adding an interface or connector break the previously working configuration)
> h1. Areas
> There are several areas where automagic happens.
> h5. Advertised address of the proxy
> There were multiple bugs in the past, where 0.0.0.0 would be sent in the advertise mesages, now if its not explcit in the VirtualHost or passed in to ServerAdvertise, it automagically picks a non-local interface. Such configurations should be disallowed.
> h5. Advertise interfaces - Java
> -The interfaces are not explicit and advertise messages could be sent/received on more interfaces and is subject to interface configuration which can change. This is also problematic when trying to move to DatagramChannel interface, which requires interfaces to be defined explicitly (MODCLUSTER-502). We can need to require this explicitly.- DONE
> h5. Advertise interfaces - Native
> The interfaces are not explicit and advertise messages could be sent/received on more interfaces (see MODCLUSTER-487).
> h5. Connector address
> If bound to any-address, the address is inferred from the proxy connection as the local address. This is solved in the default WildFly configuration as its explicitly bound to a interface.
> h5. Connector selection
> -This is solved in WildFly where selection is explicit. In tomcat this causes problems like MODCLUSTER-457 when WS requires http yet ajp is automatically selected by default. We can make this explicit.- DONE
> h5. Route generation
> Remove setJvmRoute from the SPI.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (MODCLUSTER-531) Eliminate automagic
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-531?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-531:
--------------------------------------
Description:
I am proposing we abandon automagic as much as possible.
h1. Problem
The main idea for automagic is to make deployment simple and easy to migrate/transfer and provide great user experience out of box. Unfortunately, this IMHO often backfires quite significantly resulting in configurations that are:
# insecure (listening on all interfaces, allow from all, default security key "changeme!")
# difficult to debug (not clear what is the actual configuration)
# unstable installations (seemingly unrelated aspects like adding an interface or connector break the previously working configuration)
h1. Areas
There are several areas where automagic happens.
h5. Advertised address of the proxy
There were multiple bugs in the past, where 0.0.0.0 would be sent in the advertise mesages, now if its not explcit in the VirtualHost or passed in to ServerAdvertise, it automagically picks a non-local interface. Such configurations should be disallowed.
h5. Advertise interfaces - Java
-The interfaces are not explicit and advertise messages could be sent/received on more interfaces and is subject to interface configuration which can change. This is also problematic when trying to move to DatagramChannel interface, which requires interfaces to be defined explicitly (MODCLUSTER-502). We can need to require this explicitly.- DONE
h5. Advertise interfaces - Native
The interfaces are not explicit and advertise messages could be sent/received on more interfaces (see MODCLUSTER-487).
h5. Connector address
If bound to any-address, the address is inferred from the proxy connection as the local address. This is solved in the default WildFly configuration as its explicitly bound to a interface.
h5. Connector selection
-This is solved in WildFly where selection is explicit. In tomcat this causes problems like MODCLUSTER-457 when WS requires http yet ajp is automatically selected by default. We can make this explicit.- DONE
h5. Route generation
Remove setJvmRoute from the SPI.
was:
I am proposing we abandon automagic as much as possible.
h1. Problem
The main idea for automagic is to make deployment simple and easy to migrate/transfer and provide great user experience out of box. Unfortunately, this IMHO often backfires quite significantly resulting in configurations that are:
# insecure (listening on all interfaces, allow from all, default security key "changeme!")
# difficult to debug (not clear what is the actual configuration)
# unstable installations (seemingly unrelated aspects like adding an interface or connector break the previously working configuration)
h1. Areas
There are several areas where automagic happens.
h5. Advertised address of the proxy
There were multiple bugs in the past, where 0.0.0.0 would be sent in the advertise mesages, now if its not explcit in the VirtualHost or passed in to ServerAdvertise, it automagically picks a non-local interface. Such configurations should be disallowed.
h5. Advertise interfaces
The interfaces are not explicit and advertise messages could be sent/received on more interfaces (related MODCLUSTER-487). This is also problematic when trying to move to DatagramChannel interface, which requires interfaces to be defined explicitly (MODCLUSTER-502). We can require this explicitly.
h5. Connector address
If bound to any-address, the address is inferred from the proxy connection as the local address. This is solved in the default WildFly configuration as its explicitly bound to a interface.
h5. Connector selection
-This is solved in WildFly where selection is explicit. In tomcat this causes problems like MODCLUSTER-457 when WS requires http yet ajp is automatically selected by default. We can make this explicit.- DONE MODCLUSTER-457
h5. Route generation
Remove setJvmRoute from the SPI.
> Eliminate automagic
> -------------------
>
> Key: MODCLUSTER-531
> URL: https://issues.jboss.org/browse/MODCLUSTER-531
> Project: mod_cluster
> Issue Type: Enhancement
> Components: Core & Container Integration (Java), Documentation & Demos, Native (httpd modules)
> Affects Versions: 1.2.0.Final, 1.3.0.Final
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Priority: Blocker
> Fix For: 2.0.0.Alpha1
>
>
> I am proposing we abandon automagic as much as possible.
> h1. Problem
> The main idea for automagic is to make deployment simple and easy to migrate/transfer and provide great user experience out of box. Unfortunately, this IMHO often backfires quite significantly resulting in configurations that are:
> # insecure (listening on all interfaces, allow from all, default security key "changeme!")
> # difficult to debug (not clear what is the actual configuration)
> # unstable installations (seemingly unrelated aspects like adding an interface or connector break the previously working configuration)
> h1. Areas
> There are several areas where automagic happens.
> h5. Advertised address of the proxy
> There were multiple bugs in the past, where 0.0.0.0 would be sent in the advertise mesages, now if its not explcit in the VirtualHost or passed in to ServerAdvertise, it automagically picks a non-local interface. Such configurations should be disallowed.
> h5. Advertise interfaces - Java
> -The interfaces are not explicit and advertise messages could be sent/received on more interfaces and is subject to interface configuration which can change. This is also problematic when trying to move to DatagramChannel interface, which requires interfaces to be defined explicitly (MODCLUSTER-502). We can need to require this explicitly.- DONE
> h5. Advertise interfaces - Native
> The interfaces are not explicit and advertise messages could be sent/received on more interfaces (see MODCLUSTER-487).
> h5. Connector address
> If bound to any-address, the address is inferred from the proxy connection as the local address. This is solved in the default WildFly configuration as its explicitly bound to a interface.
> h5. Connector selection
> -This is solved in WildFly where selection is explicit. In tomcat this causes problems like MODCLUSTER-457 when WS requires http yet ajp is automatically selected by default. We can make this explicit.- DONE
> h5. Route generation
> Remove setJvmRoute from the SPI.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (MODCLUSTER-633) AdvertiseListenerImplTestCase fails intermittently
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-633?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-633:
--------------------------------------
Description:
This is because org.jboss.modcluster.TestUtils#generateAdvertisePacketData generates wrong packet: after converting to java.lang.String#format(java.lang.String, java.lang.Object...) if the md5 hash begins with 0-es, its not padded.
Affected version 8ccb6f3aac71899777347e595bf48626fd948db8
was:This is because org.jboss.modcluster.TestUtils#generateAdvertisePacketData generates wrong packet: after converting to java.lang.String#format(java.lang.String, java.lang.Object...) if the md5 hash begins with 0-es, its not padded.
> AdvertiseListenerImplTestCase fails intermittently
> --------------------------------------------------
>
> Key: MODCLUSTER-633
> URL: https://issues.jboss.org/browse/MODCLUSTER-633
> Project: mod_cluster
> Issue Type: Bug
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Priority: Minor
> Fix For: 2.0.0.Alpha1
>
>
> This is because org.jboss.modcluster.TestUtils#generateAdvertisePacketData generates wrong packet: after converting to java.lang.String#format(java.lang.String, java.lang.Object...) if the md5 hash begins with 0-es, its not padded.
> Affected version 8ccb6f3aac71899777347e595bf48626fd948db8
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (MODCLUSTER-633) AdvertiseListenerImplTestCase fails intermittently
by Radoslav Husar (JIRA)
Radoslav Husar created MODCLUSTER-633:
-----------------------------------------
Summary: AdvertiseListenerImplTestCase fails intermittently
Key: MODCLUSTER-633
URL: https://issues.jboss.org/browse/MODCLUSTER-633
Project: mod_cluster
Issue Type: Bug
Reporter: Radoslav Husar
Assignee: Radoslav Husar
Priority: Minor
Fix For: 2.0.0.Alpha1
This is because org.jboss.modcluster.TestUtils#generateAdvertisePacketData generates wrong packet: after converting to java.lang.String#format(java.lang.String, java.lang.Object...) if the md5 hash begins with 0-es, its not padded.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (MODCLUSTER-469) Tomcat 8 container integration does not add jvm-route to JSESSIONID when generated by UUIDJvmRouteFactory
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/MODCLUSTER-469?page=com.atlassian.jira.pl... ]
Radoslav Husar updated MODCLUSTER-469:
--------------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Merged now, thank you for the report and solution Eric!
> Tomcat 8 container integration does not add jvm-route to JSESSIONID when generated by UUIDJvmRouteFactory
> ---------------------------------------------------------------------------------------------------------
>
> Key: MODCLUSTER-469
> URL: https://issues.jboss.org/browse/MODCLUSTER-469
> Project: mod_cluster
> Issue Type: Bug
> Components: Core & Container Integration (Java)
> Affects Versions: 1.3.1.Final, 1.4.0.Alpha1
> Environment: Apache 2.4, ModCluster 1.3.1, Tomcat 8.0 standalone
> Reporter: Eric Vernier
> Assignee: Radoslav Husar
> Priority: Critical
> Fix For: 1.4.0.Alpha2, 2.0.0.Alpha1
>
>
> If jvmRoute attribute is not set in server.xml on engine element, ModClusterService generates a jvmRoute (UUID). This UUID is not added in the value of the cookie "jsessionid", so the sticky session doesn't work. When the jvmRoute is defined in the server.xml all works fine.
> I known no much about lifecyle in Catalina, but my feeling is that ModClusterService generates the jvmRoute (with JvmRouteFactory)
> after the creation of SessionIdGenerator by the org.apache.catalina.Manager. When ModClusterService injects the generated jvmRoute it's too, the SessionIdGenerator is already created.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months