[JBoss JIRA] (TEIID-3233) Getting NPE in test integration when calling AdminFactory.getDomainAwareList
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-3233?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIID-3233.
-----------------------------------
Resolution: Cannot Reproduce Bug
There may be an NPE yet lurking, but for now this is not reproducible and it appears that getDomainAwareList cannot return null.
> Getting NPE in test integration when calling AdminFactory.getDomainAwareList
> ----------------------------------------------------------------------------
>
> Key: TEIID-3233
> URL: https://issues.jboss.org/browse/TEIID-3233
> Project: Teiid
> Issue Type: Bug
> Components: Server
> Affects Versions: 8.7.1, 9.x
> Reporter: Van Halbert
> Assignee: Steven Hawkins
>
> When getVDB's is being called in AdminFactory, an NPE occurs. Here's the diff for the fix:
> try {
> ModelNode outcome = this.connection.execute(request);
> if (Util.isSuccess(outcome)) {
> - return getDomainAwareList(outcome, VDBMetadataMapper.INSTANCE);
> + List<VDBMetaData> list = getDomainAwareList(outcome, VDBMetadataMapper.INSTANCE);
> + if (list != null) {
> + return list;
> + }
> }
> } catch (IOException e) {
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
10 years, 1 month
[JBoss JIRA] (TEIID-3233) Getting NPE in test integration when calling AdminFactory.getDomainAwareList
by Van Halbert (JIRA)
[ https://issues.jboss.org/browse/TEIID-3233?page=com.atlassian.jira.plugin... ]
Work on TEIID-3233 stopped by Van Halbert.
------------------------------------------
> Getting NPE in test integration when calling AdminFactory.getDomainAwareList
> ----------------------------------------------------------------------------
>
> Key: TEIID-3233
> URL: https://issues.jboss.org/browse/TEIID-3233
> Project: Teiid
> Issue Type: Bug
> Components: Server
> Affects Versions: 8.7.1, 9.x
> Reporter: Van Halbert
> Assignee: Van Halbert
>
> When getVDB's is being called in AdminFactory, an NPE occurs. Here's the diff for the fix:
> try {
> ModelNode outcome = this.connection.execute(request);
> if (Util.isSuccess(outcome)) {
> - return getDomainAwareList(outcome, VDBMetadataMapper.INSTANCE);
> + List<VDBMetaData> list = getDomainAwareList(outcome, VDBMetadataMapper.INSTANCE);
> + if (list != null) {
> + return list;
> + }
> }
> } catch (IOException e) {
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
10 years, 1 month
[JBoss JIRA] (TEIID-3233) Getting NPE in test integration when calling AdminFactory.getDomainAwareList
by Van Halbert (JIRA)
[ https://issues.jboss.org/browse/TEIID-3233?page=com.atlassian.jira.plugin... ]
Van Halbert updated TEIID-3233:
-------------------------------
Assignee: Steven Hawkins (was: Van Halbert)
> Getting NPE in test integration when calling AdminFactory.getDomainAwareList
> ----------------------------------------------------------------------------
>
> Key: TEIID-3233
> URL: https://issues.jboss.org/browse/TEIID-3233
> Project: Teiid
> Issue Type: Bug
> Components: Server
> Affects Versions: 8.7.1, 9.x
> Reporter: Van Halbert
> Assignee: Steven Hawkins
>
> When getVDB's is being called in AdminFactory, an NPE occurs. Here's the diff for the fix:
> try {
> ModelNode outcome = this.connection.execute(request);
> if (Util.isSuccess(outcome)) {
> - return getDomainAwareList(outcome, VDBMetadataMapper.INSTANCE);
> + List<VDBMetaData> list = getDomainAwareList(outcome, VDBMetadataMapper.INSTANCE);
> + if (list != null) {
> + return list;
> + }
> }
> } catch (IOException e) {
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
10 years, 1 month
[JBoss JIRA] (TEIID-3233) Getting NPE in test integration when calling AdminFactory.getDomainAwareList
by Van Halbert (JIRA)
[ https://issues.jboss.org/browse/TEIID-3233?page=com.atlassian.jira.plugin... ]
Work on TEIID-3233 started by Van Halbert.
------------------------------------------
> Getting NPE in test integration when calling AdminFactory.getDomainAwareList
> ----------------------------------------------------------------------------
>
> Key: TEIID-3233
> URL: https://issues.jboss.org/browse/TEIID-3233
> Project: Teiid
> Issue Type: Bug
> Components: Server
> Affects Versions: 8.7.1, 9.x
> Reporter: Van Halbert
> Assignee: Van Halbert
>
> When getVDB's is being called in AdminFactory, an NPE occurs. Here's the diff for the fix:
> try {
> ModelNode outcome = this.connection.execute(request);
> if (Util.isSuccess(outcome)) {
> - return getDomainAwareList(outcome, VDBMetadataMapper.INSTANCE);
> + List<VDBMetaData> list = getDomainAwareList(outcome, VDBMetadataMapper.INSTANCE);
> + if (list != null) {
> + return list;
> + }
> }
> } catch (IOException e) {
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
10 years, 1 month
[JBoss JIRA] (TEIID-3233) Getting NPE in test integration when calling AdminFactory.getDomainAwareList
by Van Halbert (JIRA)
[ https://issues.jboss.org/browse/TEIID-3233?page=com.atlassian.jira.plugin... ]
Van Halbert reassigned TEIID-3233:
----------------------------------
Assignee: Van Halbert (was: Steven Hawkins)
> Getting NPE in test integration when calling AdminFactory.getDomainAwareList
> ----------------------------------------------------------------------------
>
> Key: TEIID-3233
> URL: https://issues.jboss.org/browse/TEIID-3233
> Project: Teiid
> Issue Type: Bug
> Components: Server
> Affects Versions: 8.7.1, 9.x
> Reporter: Van Halbert
> Assignee: Van Halbert
>
> When getVDB's is being called in AdminFactory, an NPE occurs. Here's the diff for the fix:
> try {
> ModelNode outcome = this.connection.execute(request);
> if (Util.isSuccess(outcome)) {
> - return getDomainAwareList(outcome, VDBMetadataMapper.INSTANCE);
> + List<VDBMetaData> list = getDomainAwareList(outcome, VDBMetadataMapper.INSTANCE);
> + if (list != null) {
> + return list;
> + }
> }
> } catch (IOException e) {
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
10 years, 1 month
[JBoss JIRA] (TEIID-3233) Getting NPE in test integration when calling AdminFactory.getDomainAwareList
by Van Halbert (JIRA)
Van Halbert created TEIID-3233:
----------------------------------
Summary: Getting NPE in test integration when calling AdminFactory.getDomainAwareList
Key: TEIID-3233
URL: https://issues.jboss.org/browse/TEIID-3233
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 8.7.1, 9.x
Reporter: Van Halbert
Assignee: Steven Hawkins
When getVDB's is being called in AdminFactory, an NPE occurs. Here's the diff for the fix:
try {
ModelNode outcome = this.connection.execute(request);
if (Util.isSuccess(outcome)) {
- return getDomainAwareList(outcome, VDBMetadataMapper.INSTANCE);
+ List<VDBMetaData> list = getDomainAwareList(outcome, VDBMetadataMapper.INSTANCE);
+ if (list != null) {
+ return list;
+ }
}
} catch (IOException e) {
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
10 years, 1 month
[JBoss JIRA] (TEIID-3227) Add support for sub-expression pushing of must pushdown functions
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-3227?page=com.atlassian.jira.plugin... ]
Steven Hawkins edited comment on TEIID-3227 at 11/24/14 12:19 PM:
------------------------------------------------------------------
Detecting this is also a little different than the existing must pushdown logic in RuleAssignOutputElements in that we're actually dealing with the grouping node and not a project node when this determination needs to be made. Although we could rationalize this by inserting an explicit project node, rather than the current logic in the grouping processing node that performs the necessary projection.
was (Author: shawkins):
If the function is deterministic, then it's valid to create the pushdown form but we would need to add an aggregate such as first/last or add the function to the grouping (although that wouldn't quite be correct for rollups).
So more than likely this would look like:
SELECT AAA, SUM(first\(x)) AS BBB_ALIAS FROM (select AAA, custom_function(BBB) as x from some_table WHERE some_table.CCC = 'VAL') as v GROUP BY AAA ORDER BY AAA
Detecting this is also a little different than the existing must pushdown logic in RuleAssignOutputElements in that we're actually dealing with the grouping node and not a project node when this determination needs to be made. Although we could rationalize this by inserting an explicit project node, rather than the current logic in the grouping processing node that performs the necessary projection.
> Add support for sub-expression pushing of must pushdown functions
> -----------------------------------------------------------------
>
> Key: TEIID-3227
> URL: https://issues.jboss.org/browse/TEIID-3227
> Project: Teiid
> Issue Type: Feature Request
> Components: Query Engine
> Affects Versions: 8.9
> Reporter: Michał Warecki
> Assignee: Steven Hawkins
> Priority: Minor
>
> As a user I'd like to have a possibility to push down sub-expressions of must pushdown functions.
> Example:
> Input query with not supported group by:
> SELECT AAA, SUM(custom_function(BBB)) AS BBB_ALIAS FROM some_table WHERE some_table.CCC = 'VAL' GROUP BY AAA ORDER BY AAA
>
> Output query (processed by teiid):
> SELECT AAA, BBB AS BBB_ALIAS FROM some_table.CCC = 'VAL'
>
> What I think it should looks like:
> SELECT AAA, custom_function(BBB) AS BBB_ALIAS FROM some_table.CCC = 'VAL'
> https://developer.jboss.org/message/910926#910926
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
10 years, 1 month
[JBoss JIRA] (TEIID-3227) Add support for sub-expression pushing of must pushdown functions
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-3227?page=com.atlassian.jira.plugin... ]
Steven Hawkins edited comment on TEIID-3227 at 11/24/14 12:16 PM:
------------------------------------------------------------------
If the function is deterministic, then it's valid to create the pushdown form but we would need to add an aggregate such as first/last or add the function to the grouping (although that wouldn't quite be correct for rollups).
So more than likely this would look like:
SELECT AAA, SUM(first\(x)) AS BBB_ALIAS FROM (select AAA, custom_function(BBB) as x from some_table WHERE some_table.CCC = 'VAL') as v GROUP BY AAA ORDER BY AAA
Detecting this is also a little different than the existing must pushdown logic in RuleAssignOutputElements in that we're actually dealing with the grouping node and not a project node when this determination needs to be made. Although we could rationalize this by inserting an explicit project node, rather than the current logic in the grouping processing node that performs the necessary projection.
was (Author: shawkins):
If the function is deterministic, then it's valid to create the pushdown form but we would need to add an aggregate such as first/last or add the function to the grouping (although that wouldn't quite be correct for rollups).
So more than likely this would look like:
SELECT AAA, SUM(first(x)) AS BBB_ALIAS FROM (select AAA, custom_function(BBB) as x from some_table WHERE some_table.CCC = 'VAL') as v GROUP BY AAA ORDER BY AAA
Detecting this is also a little different than the existing must pushdown logic in RuleAssignOutputElements in that we're actually dealing with the grouping node and not a project node when this determination needs to be made. Although we could rationalize this by inserting an explicit project node, rather than the current logic in the grouping processing node that performs the necessary projection.
> Add support for sub-expression pushing of must pushdown functions
> -----------------------------------------------------------------
>
> Key: TEIID-3227
> URL: https://issues.jboss.org/browse/TEIID-3227
> Project: Teiid
> Issue Type: Feature Request
> Components: Query Engine
> Affects Versions: 8.9
> Reporter: Michał Warecki
> Assignee: Steven Hawkins
> Priority: Minor
>
> As a user I'd like to have a possibility to push down sub-expressions of must pushdown functions.
> Example:
> Input query with not supported group by:
> SELECT AAA, SUM(custom_function(BBB)) AS BBB_ALIAS FROM some_table WHERE some_table.CCC = 'VAL' GROUP BY AAA ORDER BY AAA
>
> Output query (processed by teiid):
> SELECT AAA, BBB AS BBB_ALIAS FROM some_table.CCC = 'VAL'
>
> What I think it should looks like:
> SELECT AAA, custom_function(BBB) AS BBB_ALIAS FROM some_table.CCC = 'VAL'
> https://developer.jboss.org/message/910926#910926
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
10 years, 1 month