[JBoss JIRA] (TEIID-5521) Add build plugins used by basepom to help with dependency handling
by Ramesh Reddy (Jira)
[ https://issues.jboss.org/browse/TEIID-5521?page=com.atlassian.jira.plugin... ]
Ramesh Reddy commented on TEIID-5521:
-------------------------------------
I think with WildFly modules in the mix this would be hard proposition to solve. Let's leave as is for master, I think places like "teiid-komodo" is where we need to start to fix more issues like this IMO.
Another crazy idea I been thinking is moving the "teiid-jboss-integration" and connector projects out into "teiid-wildfly" project that will be all this based on jboss-parent-pom and then we have a clean Teiid engine based on basepom, where on which spring-boot, thorntail, hangout off. With all the complexity of featurepacks, modules etc it has really becoming unmanagable dependencies wise.
> Add build plugins used by basepom to help with dependency handling
> ------------------------------------------------------------------
>
> Key: TEIID-5521
> URL: https://issues.jboss.org/browse/TEIID-5521
> Project: Teiid
> Issue Type: Task
> Components: Build/Kits
> Affects Versions: 12.x
> Reporter: Van Halbert
> Assignee: Van Halbert
> Priority: Major
> Fix For: 12.0
>
>
> Utilize plugins that basebom uses, which will help reduce half the headaches you go though during the productization with versions.
> plugins:
> * duplicate-finder-maven-plugin
> * maven-dependency-plugin
> * maven-dependency-versions-check-plugin
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months
[JBoss JIRA] (TEIID-5521) Add build plugins used by basepom to help with dependency handling
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5521?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-5521:
---------------------------------------
There are some other issues with the dependency analysis. Something that we need transitively for embedded like jboss-vfs, basepom does not like that it is explicitly declared as a dependency. If we remove the explicit dependency on xerces we see the issue mentioned in TEIID-5225.
So I committed what I could of the initial cleanup to master. We should probably at least pull back the kitting change to remove unneeded stuff from dataquality.
With the jboss-parent we also just inherit the warnings:
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequirePluginVersions warned with message:
Some plugins are missing valid versions:(LATEST RELEASE SNAPSHOT are not allowed )
org.apache.maven.plugins:maven-clean-plugin. The version currently in use is 3.1.0
org.codehaus.mojo:buildnumber-maven-plugin. The version currently in use is 1.4
org.apache.maven.plugins:maven-install-plugin. The version currently in use is 2.5.2
org.apache.maven.plugins:maven-source-plugin. The version currently in use is 3.0.1
org.apache.maven.plugins:maven-site-plugin. The version currently in use is 3.7.1
org.apache.maven.plugins:maven-deploy-plugin. The version currently in use is 2.8.2
org.apache.maven.plugins:maven-enforcer-plugin. The version currently in use is 3.0.0-M2
Which seems odd at first glance as those plugin version are defined in the parent...
[~van.halbert] or [~rareddy] do either of you want to pursue this further in 12.0, or are you good with picking this back up later?
> Add build plugins used by basepom to help with dependency handling
> ------------------------------------------------------------------
>
> Key: TEIID-5521
> URL: https://issues.jboss.org/browse/TEIID-5521
> Project: Teiid
> Issue Type: Task
> Components: Build/Kits
> Affects Versions: 12.x
> Reporter: Van Halbert
> Assignee: Van Halbert
> Priority: Major
> Fix For: 12.0
>
>
> Utilize plugins that basebom uses, which will help reduce half the headaches you go though during the productization with versions.
> plugins:
> * duplicate-finder-maven-plugin
> * maven-dependency-plugin
> * maven-dependency-versions-check-plugin
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months
[JBoss JIRA] (TEIID-5521) Add build plugins used by basepom to help with dependency handling
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5521?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-5521:
---------------------------------------
I have worked through this up to the connector. The connectors will be a pain to correct as we declare lots of dependencies in the connector parent pom.
I'll see how much of a hassle it would be to bring over just the corrects, but no usage yet of basepom.
> Add build plugins used by basepom to help with dependency handling
> ------------------------------------------------------------------
>
> Key: TEIID-5521
> URL: https://issues.jboss.org/browse/TEIID-5521
> Project: Teiid
> Issue Type: Task
> Components: Build/Kits
> Affects Versions: 12.x
> Reporter: Van Halbert
> Assignee: Van Halbert
> Priority: Major
> Fix For: 12.0
>
>
> Utilize plugins that basebom uses, which will help reduce half the headaches you go though during the productization with versions.
> plugins:
> * duplicate-finder-maven-plugin
> * maven-dependency-plugin
> * maven-dependency-versions-check-plugin
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months
[JBoss JIRA] (TEIID-5556) Re-resolving a query with common tables breaks projection minimization
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5556?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIID-5556.
-----------------------------------
Resolution: Done
Updated the resolving logic to reuse the id if already resolved.
> Re-resolving a query with common tables breaks projection minimization
> ----------------------------------------------------------------------
>
> Key: TEIID-5556
> URL: https://issues.jboss.org/browse/TEIID-5556
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 12.0
>
>
> While I don't see a case where this would happen in practice we should guard against it.
> The issue is that we create a new temp group for the with clause, but then reuse the old metadata ids where referenced. The projection logic works off of equality, so it needs the references to be updated or the original to stay in use.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months
[JBoss JIRA] (TEIID-5556) Re-resolving a query with common tables breaks projection minimization
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5556?page=com.atlassian.jira.plugin... ]
Steven Hawkins updated TEIID-5556:
----------------------------------
Description:
While I don't see a case where this would happen in practice we should guard against it.
The issue is that we create a new temp group for the with clause, but then reuse the old metadata ids where referenced. The projection logic works off of equality, so it needs the references to be updated or the original to stay in use.
was:While I don't see a case where this would happen in practice we should guard against it.
> Re-resolving a query with common tables breaks projection minimization
> ----------------------------------------------------------------------
>
> Key: TEIID-5556
> URL: https://issues.jboss.org/browse/TEIID-5556
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 12.0
>
>
> While I don't see a case where this would happen in practice we should guard against it.
> The issue is that we create a new temp group for the with clause, but then reuse the old metadata ids where referenced. The projection logic works off of equality, so it needs the references to be updated or the original to stay in use.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 11 months