[JBoss JIRA] (TEIID-5849) Merge the admin and api sub-modules
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5849?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIID-5849.
-----------------------------------
Resolution: Done
Merged the modules and updated the docs. I see what consolidation could be done in time for 13.0 .
> Merge the admin and api sub-modules
> -----------------------------------
>
> Key: TEIID-5849
> URL: https://issues.jboss.org/browse/TEIID-5849
> Project: Teiid
> Issue Type: Task
> Components: AdminApi, Connector API
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.0
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> There isn't a compelling reason to keep the admin and api submodules separate any longer.
> api depends on admin already and keeping api code out of admin makes it difficult to evolve the vdb structural components into regular api objects - or at least hold resolved references.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (TEIID-5849) Merge the admin and api sub-modules
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5849?focusedWorklogId=12448103&page... ]
Steven Hawkins logged work on TEIID-5849:
-----------------------------------------
Author: Steven Hawkins
Created on: 20/Nov/19 8:26 AM
Start Date: 20/Nov/19 8:26 AM
Worklog Time Spent: 2 hours
Issue Time Tracking
-------------------
Remaining Estimate: 0 minutes (was: 2 hours)
Time Spent: 2 hours
Worklog Id: (was: 12448103)
> Merge the admin and api sub-modules
> -----------------------------------
>
> Key: TEIID-5849
> URL: https://issues.jboss.org/browse/TEIID-5849
> Project: Teiid
> Issue Type: Task
> Components: AdminApi, Connector API
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.0
>
> Original Estimate: 2 hours
> Time Spent: 2 hours
> Remaining Estimate: 0 minutes
>
> There isn't a compelling reason to keep the admin and api submodules separate any longer.
> api depends on admin already and keeping api code out of admin makes it difficult to evolve the vdb structural components into regular api objects - or at least hold resolved references.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (TEIID-5848) views in vertica not found by teiid
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5848?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIID-5848.
-----------------------------------
Resolution: Explained
Resolving as explained - if there is no unique key associated with a table / view, then one needs to be added virtually for it to be an entity in odata.
> views in vertica not found by teiid
> -----------------------------------
>
> Key: TEIID-5848
> URL: https://issues.jboss.org/browse/TEIID-5848
> Project: Teiid
> Issue Type: Bug
> Components: JDBC Connector
> Reporter: Renat Eskenin
> Assignee: Steven Hawkins
> Priority: Major
>
> We created view in vertica DB
> Example project with vertica translator+odata not found this view
> {code}
> src 1 Varchar 4 [NULL] true false false [NULL] false [NULL]
> src_id 2 Varchar 18 [NULL] true false false [NULL] false [NULL]
> src_name 3 Varchar 363 [NULL] true false false [NULL] false [NULL]
> account_id 4 Varchar 18 [NULL] true false false [NULL] false [NULL]
> name 5 Varchar 765 [NULL] true false false [NULL] false [NULL]
> billing_country 6 Varchar 240 [NULL] true false false [NULL] false [NULL]
> root_domain 7 Varchar 192 [NULL] true false false [NULL] false [NULL]
> sales_team 8 Varchar 240 [NULL] true false false [NULL] false [NULL]
> {code}
> {
> "error": {
> "code": null,
> "message": "Cannot find EntitySet, Singleton, ActionImport or FunctionImport with name 'funnel_leads'."
> }
> }
> But regular tables works properly
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (TEIIDSB-137) The resource-name concept seems unused
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIIDSB-137?page=com.atlassian.jira.plugi... ]
Steven Hawkins commented on TEIIDSB-137:
----------------------------------------
Also removed examples of TYPE 'NONE'
> The resource-name concept seems unused
> --------------------------------------
>
> Key: TEIIDSB-137
> URL: https://issues.jboss.org/browse/TEIIDSB-137
> Project: Teiid Spring Boot
> Issue Type: Quality Risk
> Components: datasource, documentation
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 1.3.0
>
> Original Estimate: 2 hours
> Time Spent: 2 hours
> Remaining Estimate: 0 minutes
>
> Most examples show the usage of the resource-name option on create server - however this is not used anywhere in the code. It seems like the intention was to possibly use that name instead of the server name as the bean name, but everywhere makes the assumption that they match.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (TEIIDSB-137) The resource-name concept seems unused
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIIDSB-137?page=com.atlassian.jira.plugi... ]
Steven Hawkins resolved TEIIDSB-137.
------------------------------------
Assignee: Steven Hawkins
Resolution: Done
That's all the references I could find. The only minor issue is that the way we hold server references on the teiid side is not case sensitive, so that corner case would require the use of the resource-name in spring boot. Otherwise we'll expect that server name to match.
> The resource-name concept seems unused
> --------------------------------------
>
> Key: TEIIDSB-137
> URL: https://issues.jboss.org/browse/TEIIDSB-137
> Project: Teiid Spring Boot
> Issue Type: Quality Risk
> Components: datasource, documentation
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 1.3.0
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Most examples show the usage of the resource-name option on create server - however this is not used anywhere in the code. It seems like the intention was to possibly use that name instead of the server name as the bean name, but everywhere makes the assumption that they match.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (TEIIDSB-137) The resource-name concept seems unused
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIIDSB-137?focusedWorklogId=12448096&pag... ]
Steven Hawkins logged work on TEIIDSB-137:
------------------------------------------
Author: Steven Hawkins
Created on: 18/Nov/19 4:14 PM
Start Date: 18/Nov/19 4:14 PM
Worklog Time Spent: 2 hours
Issue Time Tracking
-------------------
Remaining Estimate: 0 minutes (was: 2 hours)
Time Spent: 2 hours
Worklog Id: (was: 12448096)
> The resource-name concept seems unused
> --------------------------------------
>
> Key: TEIIDSB-137
> URL: https://issues.jboss.org/browse/TEIIDSB-137
> Project: Teiid Spring Boot
> Issue Type: Quality Risk
> Components: datasource, documentation
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 1.3.0
>
> Original Estimate: 2 hours
> Time Spent: 2 hours
> Remaining Estimate: 0 minutes
>
> Most examples show the usage of the resource-name option on create server - however this is not used anywhere in the code. It seems like the intention was to possibly use that name instead of the server name as the bean name, but everywhere makes the assumption that they match.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (TEIIDSB-137) The resource-name concept seems unused
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIIDSB-137?page=com.atlassian.jira.plugi... ]
Steven Hawkins updated TEIIDSB-137:
-----------------------------------
Original Estimate: 2 hours
Remaining Estimate: 2 hours
> The resource-name concept seems unused
> --------------------------------------
>
> Key: TEIIDSB-137
> URL: https://issues.jboss.org/browse/TEIIDSB-137
> Project: Teiid Spring Boot
> Issue Type: Quality Risk
> Components: datasource, documentation
> Reporter: Steven Hawkins
> Priority: Major
> Fix For: 1.3.0
>
> Original Estimate: 2 hours
> Remaining Estimate: 2 hours
>
> Most examples show the usage of the resource-name option on create server - however this is not used anywhere in the code. It seems like the intention was to possibly use that name instead of the server name as the bean name, but everywhere makes the assumption that they match.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (TEIID-5852) views are resolved twice in the metadata validator
by Steven Hawkins (Jira)
Steven Hawkins created TEIID-5852:
-------------------------------------
Summary: views are resolved twice in the metadata validator
Key: TEIID-5852
URL: https://issues.jboss.org/browse/TEIID-5852
Project: Teiid
Issue Type: Quality Risk
Components: Query Engine
Reporter: Steven Hawkins
Assignee: Steven Hawkins
Fix For: 13.1
There is an initial resolve to run the Validation visitor, then another resolve in resolveView. This should be combined as much as possible.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month
[JBoss JIRA] (TEIID-5850) DDL server and foreign data wrapper handling is unclear
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5850?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-5850:
---------------------------------------
> CREATE FOREIGN DATA WRAPPER salesforce ...
The options clause is currently not used. This statement is mostly for compliance with the spec as we use a set of well-known names and/or the name is defined by the custom translator.
However the options clause should mean "apply these properties to all such instances of salesforce in this vdb" - but currently does not as that does not line up to our old design. We should probably make that change as ddl deployment docs suggests it already works this way.
> CREATE FOREIGN DATA WRAPPER mysalesforce TYPE salesforce ...
This is specific to Teiid and is effectively the same as a translator override in our old terminology. Here the options are applied as execution properties. This is documented on our Translator Properties page. However ideally it should be combined most of the time with the first statement.
> CREATE SERVER salesforce FOREIGN DATA WRAPPER salesforce OPTIONS ("resource-name" 'salesforce' ...
Here as well the options are currently not applied as execution properties. In fact the only property that is used is resource-name. By the spec this could include resource adapter / source config properties if/when we allow for direct configuration in the vdb. Need to document that execution properties do not apply here.
Import properties can be specified either on the import statement or on the schema (which seems clear enough).
> DDL server and foreign data wrapper handling is unclear
> -------------------------------------------------------
>
> Key: TEIID-5850
> URL: https://issues.jboss.org/browse/TEIID-5850
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Critical
> Fix For: 13.0, 12.2.2, 12.3.1
>
> Original Estimate: 6 hours
> Remaining Estimate: 6 hours
>
> CREATE server statements in DDL are effectively ignored in the conversion to runtime state - they are simply validated. Similarly a CREATE foreign data wrapper statement that does not specify a type is ignored.
> Attempting to do something like:
> {code}
> CREATE FOREIGN DATA WRAPPER salesforce;
> CREATE SERVER salesforce FOREIGN DATA WRAPPER salesforce OPTIONS ("resource-name" 'salesforce', supportsOrderBy true);
> {code}
> or
> {code}
> CREATE FOREIGN DATA WRAPPER salesforce OPTIONS (supportsOrderBy true);
> CREATE SERVER salesforce FOREIGN DATA WRAPPER salesforce OPTIONS ("resource-name" 'salesforce');
> {code}
> will not result in supportsOrderBy being set on the translator.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 1 month