[JBoss JIRA] (TEIIDSB-95) Remove the implicit spring vdb when an explicit vdb is used
by Steven Hawkins (Jira)
Steven Hawkins created TEIIDSB-95:
-------------------------------------
Summary: Remove the implicit spring vdb when an explicit vdb is used
Key: TEIIDSB-95
URL: https://issues.jboss.org/browse/TEIIDSB-95
Project: Teiid Spring Boot
Issue Type: Quality Risk
Reporter: Steven Hawkins
Assignee: Ramesh Reddy
Fix For: 1.1.0
Time is being spent in classpath scanning and loading/creating the implicit spring vdb, which is not needed when there is an explicit vdb. Also the spring vdb is still accessible over the transports.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 7 months
[JBoss JIRA] (TEIIDSB-94) Target a Java 11 build/image
by Steven Hawkins (Jira)
Steven Hawkins created TEIIDSB-94:
-------------------------------------
Summary: Target a Java 11 build/image
Key: TEIIDSB-94
URL: https://issues.jboss.org/browse/TEIIDSB-94
Project: Teiid Spring Boot
Issue Type: Component Upgrade
Reporter: Steven Hawkins
Assignee: Steven Hawkins
Fix For: 1.1.0
The build/image are targeted to 1.8, we should update to Java 11. I had looked at adding Java 11 travis build, but it failed during codegen so I'll see about resolving that first.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 7 months
[JBoss JIRA] (TEIIDSB-92) Provide an openshfit example of a secure transport
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIIDSB-92?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIIDSB-92.
-----------------------------------
Resolution: Done
> Provide an openshfit example of a secure transport
> --------------------------------------------------
>
> Key: TEIIDSB-92
> URL: https://issues.jboss.org/browse/TEIIDSB-92
> Project: Teiid Spring Boot
> Issue Type: Sub-task
> Components: OpenShift
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Attachments: screenshot-1.png
>
>
> Until we have kerberos support, usage of the pg transport will likely need to be secure to prevent plain-text username/password being sent unencrypted.
> It should also be a general option to enable secure transports from our ui. External exposure is covered in TEIIDSB-86.
> We should use the private key from either based upon a self-signed certificate or using service signing certificates. I'll provide an example demonstrating one of those approaches.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 7 months
[JBoss JIRA] (TEIIDSB-92) Provide an openshfit example of a secure transport
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIIDSB-92?page=com.atlassian.jira.plugin... ]
Steven Hawkins updated TEIIDSB-92:
----------------------------------
Fix Version/s: 1.1.0
> Provide an openshfit example of a secure transport
> --------------------------------------------------
>
> Key: TEIIDSB-92
> URL: https://issues.jboss.org/browse/TEIIDSB-92
> Project: Teiid Spring Boot
> Issue Type: Sub-task
> Components: OpenShift
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 1.1.0
>
> Attachments: screenshot-1.png
>
>
> Until we have kerberos support, usage of the pg transport will likely need to be secure to prevent plain-text username/password being sent unencrypted.
> It should also be a general option to enable secure transports from our ui. External exposure is covered in TEIIDSB-86.
> We should use the private key from either based upon a self-signed certificate or using service signing certificates. I'll provide an example demonstrating one of those approaches.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 7 months
[JBoss JIRA] (TEIID-5744) Teiid pg does not handle empty prepared sql
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5744?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIID-5744.
-----------------------------------
Resolution: Done
Updated the logic to not create a statement nor get the metadata when the prepared sql is empty.
> Teiid pg does not handle empty prepared sql
> -------------------------------------------
>
> Key: TEIID-5744
> URL: https://issues.jboss.org/browse/TEIID-5744
> Project: Teiid
> Issue Type: Bug
> Components: ODBC
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 12.3, 12.2.1
>
>
> If a client issues something like:
> s = c.prepareStatement("");
> s.executeUpdate();
> The current logic will throw an exception on prepare.
> It's expected for the prepare to complete an an empty statement response to be returned from execute.
> This is the logic that is used by the PG JDBC driver for connection.isValid.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 7 months
[JBoss JIRA] (TEIID-5744) Teiid pg does not handle empty prepared sql
by Steven Hawkins (Jira)
Steven Hawkins created TEIID-5744:
-------------------------------------
Summary: Teiid pg does not handle empty prepared sql
Key: TEIID-5744
URL: https://issues.jboss.org/browse/TEIID-5744
Project: Teiid
Issue Type: Bug
Components: ODBC
Reporter: Steven Hawkins
Assignee: Steven Hawkins
Fix For: 12.3, 12.2.1
If a client issues something like:
s = c.prepareStatement("");
s.executeUpdate();
The current logic will throw an exception on prepare.
It's expected for the prepare to complete an an empty statement response to be returned from execute.
This is the logic that is used by the PG JDBC driver for connection.isValid.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 7 months
[JBoss JIRA] (TEIIDSB-92) Provide an openshfit example of a secure transport
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIIDSB-92?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIIDSB-92:
---------------------------------------
The f-m-p issue is already known. The suggestion is either to use the spring-boot name, or remove the explicit name from the fragment (it will still be spring-boot in that case).
I've swtiched this over to pg, but am running into issues. With the simple jdbc client, it's using the connection.isvalid method that issues an empty prepared statement that we are not handling. There also appears to be another issue. I'll get both of those addressed.
> Provide an openshfit example of a secure transport
> --------------------------------------------------
>
> Key: TEIIDSB-92
> URL: https://issues.jboss.org/browse/TEIIDSB-92
> Project: Teiid Spring Boot
> Issue Type: Sub-task
> Components: OpenShift
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Attachments: screenshot-1.png
>
>
> Until we have kerberos support, usage of the pg transport will likely need to be secure to prevent plain-text username/password being sent unencrypted.
> It should also be a general option to enable secure transports from our ui. External exposure is covered in TEIIDSB-86.
> We should use the private key from either based upon a self-signed certificate or using service signing certificates. I'll provide an example demonstrating one of those approaches.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 7 months
[JBoss JIRA] (TEIIDSB-92) Provide an openshfit example of a secure transport
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIIDSB-92?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIIDSB-92:
---------------------------------------
[~rareddy] here is what this looks like: https://github.com/shawkins/teiid-openshift-examples/commit/3dba649fcbd57...
Before this is merged it would need to be targeted against the security example instead.
The basic idea is that we need a new svc.yml to define a secure transport. It has to include the service.alpha.openshift.io/serving-cert-secret-name annotation.
Then in the deploymentconfig there is an initContainer to take the generated certificate and turn it into a keystore, a volume to share it, and additional env properties to enable the secure transport and provide the keystore.
This requires a later version of f-m-p - and it requires that the container name be spring-boot. If it's named something else, them f-m-p creates an extra invalid container in the generated deployment. I'll log something with f-m-p just so it's captured.
A minor complication with this approach (or with having a single Teiid ssl config) is when you have both services as secure - you end up with a single key/keystore as they both are given the same name. It doesn't really matter which one, but if you care about what is presented as the host name it would be good to know.
> Provide an openshfit example of a secure transport
> --------------------------------------------------
>
> Key: TEIIDSB-92
> URL: https://issues.jboss.org/browse/TEIIDSB-92
> Project: Teiid Spring Boot
> Issue Type: Sub-task
> Components: OpenShift
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Attachments: screenshot-1.png
>
>
> Until we have kerberos support, usage of the pg transport will likely need to be secure to prevent plain-text username/password being sent unencrypted.
> It should also be a general option to enable secure transports from our ui. External exposure is covered in TEIIDSB-86.
> We should use the private key from either based upon a self-signed certificate or using service signing certificates. I'll provide an example demonstrating one of those approaches.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
5 years, 7 months