[ https://issues.jboss.org/browse/TEIID-4311?page=com.atlassian.jira.plugin... ] Kylin Soong edited comment on TEIID-4311 at 7/4/16 3:58 AM: ------------------------------------------------------------ Base on my investigate against wildfly 10, At least one xa-datasource-property is required for an xa-datasource, no need 3, eg, the following cli works: {code} xa-data-source add --name=H2XADS --driver-name=h2-xa --jndi-name=java:jboss/datasources/H2XADS --user-name=user --password=password --use-java-context=true --xa-datasource-properties=[URL=>"jdbc:h2:mem:test-xa;DB_CLOSE_DELAY=-1;DB_CLOSE_ON_EXIT=FALSE"] {code} Btw, I have two aspects opinion: * What AdminImpl try to do is build a dmr Model Rquest, then execute the request. The question is current build dmr Model Rquest programmatic, which setAddress, setOprations, setAttributes manually, this cause some private methods, and made the program difficult to understand, it's not easy for maintaining, especially. There is a simple way to build dmr Rquest, which build request from cli string, {code} CommandContext ctx = CommandContextFactory.getInstance().newCommandContext(); ctx.bindClient(connection); ModelNode request = ctx.buildRequest("/subsystem=..."); {code} If we put all management cli to a separate file, this will simplify the AdminImpl implementation logic, lots of private methods will be removed, it's easy to understand and maintaining. * In late version of teiid, RAR based installation be removed, so we we still need keep rar related logic(like rar connection-definitions)? * We may need add more methods that including add driver, add driver module, etc, cause these operations is necessary for creating datasource. was (Author: kylin): Base on my investigate against wildfly 10, At least one xa-datasource-property is required for an xa-datasource, no need 3, eg, the following cli works: {code} xa-data-source add --name=H2XADS --driver-name=h2-xa --jndi-name=java:jboss/datasources/H2XADS --user-name=user --password=password --use-java-context=true --xa-datasource-properties=[URL=>"jdbc:h2:mem:test-xa;DB_CLOSE_DELAY=-1;DB_CLOSE_ON_EXIT=FALSE"] {code} Btw, I have two aspects opinion: * What AdminImpl try to do is build a dmr Model Rquest, then execute the request. The question is current build dmr Model Rquest programmatic, which setAddress, setOprations, setAttributes manually, this cause some private methods, and made the program difficult to understand, it's not easy for maintaining, especially. There is a simple way to build dmr Rquest, which build request from cli string, {code} CommandContext ctx = CommandContextFactory.getInstance().newCommandContext(); ctx.bindClient(connection); ModelNode request = ctx.buildRequest("/subsystem=..."); {code} If we put all management cli to a separate file, this will simplify the AdminImpl implementation logic, lots of private methods will be removed, it's easy to understand and maintaining. * In late version of teiid, RAR based installation be removed, so we we still need keep rar related logic(like rar connection-definitions)? if we keep management cli in a separate file, -- This message was sent by Atlassian JIRA (v6.4.11#64026)