[JBoss JIRA] (TEIID-4887) Domain mode configuration fails with CNF
by Ramesh Reddy (JIRA)
[ https://issues.jboss.org/browse/TEIID-4887?page=com.atlassian.jira.plugin... ]
Ramesh Reddy resolved TEIID-4887.
---------------------------------
Assignee: Ramesh Reddy (was: Steven Hawkins)
Resolution: Done
Added the missing JGroups dependency to the Teiid module
{code}
<module name="org.wildfly.clustering.jgroups.spi"/>
{code}
> Domain mode configuration fails with CNF
> ----------------------------------------
>
> Key: TEIID-4887
> URL: https://issues.jboss.org/browse/TEIID-4887
> Project: Teiid
> Issue Type: Bug
> Components: Server
> Affects Versions: 9.1
> Reporter: Ramesh Reddy
> Assignee: Ramesh Reddy
> Priority: Critical
> Fix For: 9.3, 9.2.3
>
>
> domain script fails to run to the finish with a exception
> {code}
> [Server:server-one] 12:15:52,763 ERROR [org.jboss.as.controller.management-operation] (ServerService Thread Pool -- 62) WFLYCTL0013: Operation ("add") failed - address: ([("subsystem" => "teiid")]): java.lang.NoClassDefFoundError: org/wildfly/clustering/jgroups/spi/service/ProtocolStackServiceName
> [Server:server-one] at org.teiid.jboss.TeiidAdd.initilaizeTeiidEngine(TeiidAdd.java:314)
> [Server:server-one] at org.teiid.jboss.TeiidAdd.performRuntime(TeiidAdd.java:215)
> [Server:server-one] at org.jboss.as.controller.AbstractAddStepHandler.performRuntime(AbstractAddStepHandler.java:337)
> [Server:server-one] at org.jboss.as.controller.AbstractAddStepHandler$1.execute(AbstractAddStepHandler.java:151)
> [Server:server-one] at org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:890)
> [Server:server-one] at org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:659)
> [Server:server-one] at org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:370)
> [Server:server-one] at org.jboss.as.controller.OperationContextImpl.executeOperation(OperationContextImpl.java:1344)
> [Server:server-one] at org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:39
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 8 months
[JBoss JIRA] (TEIID-4887) Domain mode configuration fails with CNF
by Ramesh Reddy (JIRA)
Ramesh Reddy created TEIID-4887:
-----------------------------------
Summary: Domain mode configuration fails with CNF
Key: TEIID-4887
URL: https://issues.jboss.org/browse/TEIID-4887
Project: Teiid
Issue Type: Bug
Components: Server
Affects Versions: 9.1
Reporter: Ramesh Reddy
Assignee: Steven Hawkins
Priority: Critical
Fix For: 9.3, 9.2.3
domain script fails to run to the finish with a exception
{code}
[Server:server-one] 12:15:52,763 ERROR [org.jboss.as.controller.management-operation] (ServerService Thread Pool -- 62) WFLYCTL0013: Operation ("add") failed - address: ([("subsystem" => "teiid")]): java.lang.NoClassDefFoundError: org/wildfly/clustering/jgroups/spi/service/ProtocolStackServiceName
[Server:server-one] at org.teiid.jboss.TeiidAdd.initilaizeTeiidEngine(TeiidAdd.java:314)
[Server:server-one] at org.teiid.jboss.TeiidAdd.performRuntime(TeiidAdd.java:215)
[Server:server-one] at org.jboss.as.controller.AbstractAddStepHandler.performRuntime(AbstractAddStepHandler.java:337)
[Server:server-one] at org.jboss.as.controller.AbstractAddStepHandler$1.execute(AbstractAddStepHandler.java:151)
[Server:server-one] at org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:890)
[Server:server-one] at org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:659)
[Server:server-one] at org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:370)
[Server:server-one] at org.jboss.as.controller.OperationContextImpl.executeOperation(OperationContextImpl.java:1344)
[Server:server-one] at org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:39
{code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 8 months
[JBoss JIRA] (TEIID-4886) Allow join grouping to optimize across left outer joins
by Steven Hawkins (JIRA)
Steven Hawkins created TEIID-4886:
-------------------------------------
Summary: Allow join grouping to optimize across left outer joins
Key: TEIID-4886
URL: https://issues.jboss.org/browse/TEIID-4886
Project: Teiid
Issue Type: Enhancement
Components: Query Engine
Reporter: Steven Hawkins
Assignee: Steven Hawkins
Fix For: 9.3
In a from clause such as:
(a.t1 inner join b.t1 ... inner join a.t2 ...) left outer join b.t2 ...
It is possible to group the b.t1 and b.t2 together, but generally won't be found by the grouping and then ordering logic.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 8 months
[JBoss JIRA] (TEIID-4885) Costing issues
by Steven Hawkins (JIRA)
Steven Hawkins created TEIID-4885:
-------------------------------------
Summary: Costing issues
Key: TEIID-4885
URL: https://issues.jboss.org/browse/TEIID-4885
Project: Teiid
Issue Type: Quality Risk
Components: Query Engine
Reporter: Steven Hawkins
Assignee: Steven Hawkins
Fix For: 9.3
There were several deficiencies introduced with TEIID-4332 -
In some circumstances very low ndv values on the large side of a join would cause a dependent join in an unexpected direction.
The row estimate derived for a join without ndv information would tend to be too low, which would have a cumulative effect through further joins.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 8 months
[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by David Vilaverde (JIRA)
[ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin... ]
David Vilaverde commented on TEIID-4883:
----------------------------------------
[~rareddy] Ok I've updated the PR now to reflect the changes you suggested. I've also added some tests to cover the new cases.
> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
> Key: TEIID-4883
> URL: https://issues.jboss.org/browse/TEIID-4883
> Project: Teiid
> Issue Type: Enhancement
> Components: Misc. Connectors
> Reporter: David Vilaverde
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: Open To Community
>
> Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
> I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
> If this PR is not going to be accepted, can the methods in the ExcelMetadataProcessor me changed from private to protected so that the processor can be extended easily?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 8 months
[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by Ramesh Reddy (JIRA)
[ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin... ]
Ramesh Reddy commented on TEIID-4883:
-------------------------------------
Yes, instead of {{getAllowEmptyCells}}, I propose we say {{getIgnoreEmptyCells}} when {{true}}, all the 3 columns are returned ignoring/skipping the empty space, and if {{false}} only first 2 columns are returned.
> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
> Key: TEIID-4883
> URL: https://issues.jboss.org/browse/TEIID-4883
> Project: Teiid
> Issue Type: Enhancement
> Components: Misc. Connectors
> Reporter: David Vilaverde
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: Open To Community
>
> Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
> I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
> If this PR is not going to be accepted, can the methods in the ExcelMetadataProcessor me changed from private to protected so that the processor can be extended easily?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 8 months
[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by David Vilaverde (JIRA)
[ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin... ]
David Vilaverde commented on TEIID-4883:
----------------------------------------
[~rareddy]So the PR i submitted with the allowEmptyCells property will treat the col 3 in the sample table in your previous comment as the end of table, so the end result is:
||heading 1||heading 2||
|col A1|col A2|
|col B1|col B2|
What do you mean by submit the patch again? Do you want me to alter the implementation somehow? Or do you want me to just get rid of the allowEmptyCells property?
> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
> Key: TEIID-4883
> URL: https://issues.jboss.org/browse/TEIID-4883
> Project: Teiid
> Issue Type: Enhancement
> Components: Misc. Connectors
> Reporter: David Vilaverde
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: Open To Community
>
> Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
> I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
> If this PR is not going to be accepted, can the methods in the ExcelMetadataProcessor me changed from private to protected so that the processor can be extended easily?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 8 months
[JBoss JIRA] (TEIID-4883) Teiid Excel Translator should filter blank cells from header row
by Ramesh Reddy (JIRA)
[ https://issues.jboss.org/browse/TEIID-4883?page=com.atlassian.jira.plugin... ]
Ramesh Reddy commented on TEIID-4883:
-------------------------------------
[~dvilaverde] In that case, this is bug. What I see is Teiid is not accounting for blank cells in header, thus using empty column name and considering the next cell as duplicate. I was thinking your usecase is much like
||heading 1||heading 2|| ||heading 3||
|col A1|col A2| |col A3|
|col B1|col B2| |col B3|
Where 3 should not be part of the table. Even this is good usecase.
So, for the bug, we would need to make sure headerCell is not blank, if it is blank then either skip the cell or end the the table creation at that column based on the {{getAllowEmptyCells}} proeprty you created. If you want to submit patch I will review it again.
> Teiid Excel Translator should filter blank cells from header row
> ----------------------------------------------------------------
>
> Key: TEIID-4883
> URL: https://issues.jboss.org/browse/TEIID-4883
> Project: Teiid
> Issue Type: Enhancement
> Components: Misc. Connectors
> Reporter: David Vilaverde
> Assignee: Steven Hawkins
> Priority: Minor
> Fix For: Open To Community
>
> Attachments: fr-demo1-sample-data.xls
>
>
> The teiid translator for excel will throw a duplicate column name exception when using a spreadsheet that has 2 or more columns where the header row doesn't specify a header name. In the attached spreadsheet it's difficult to see that rows E-H should be deleted from the dataset.
> The proposed enhancement is to allow the translator for excel to exclude any trailing columns where there is no column name defined.
> I took a shot at making this enhancement and created a PR at https://github.com/teiid/teiid/pull/951
> If this PR is not going to be accepted, can the methods in the ExcelMetadataProcessor me changed from private to protected so that the processor can be extended easily?
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 8 months