[JBoss JIRA] (TEIID-5852) views are resolved twice in the metadata validator
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5852?page=com.atlassian.jira.plugi... ]
Steven Hawkins edited comment on TEIID-5852 at 2/28/20 12:56 PM:
-----------------------------------------------------------------
The purpose of the dual resolving is to first resolve just the query command, then to resolve view after adjustments have been made to the metadata. The re-resolving makes it easier to avoid corner cases with the metadata adjustments. Unless we move the knowledge of that up into the metadata validation, then we should just leave this as is for now.
was (Author: shawkins):
The purpose of the dual resolving is to first resolve just the query command, then to resolve view after adjustments have been made to the metadata. I wasn't successful even with skipping just the reparsing of the sql, let alone the re-resolving as there are corner cases about each situation. Unless we move the knowledge of that up into the metadata validation, then we should just leave this as is for now.
> views are resolved twice in the metadata validator
> --------------------------------------------------
>
> Key: TEIID-5852
> URL: https://issues.redhat.com/browse/TEIID-5852
> Project: Teiid
> Issue Type: Quality Risk
> Components: Query Engine
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.1
>
>
> There is an initial resolve to run the Validation visitor, then another resolve in resolveView. This should be combined as much as possible.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (TEIID-5852) views are resolved twice in the metadata validator
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5852?page=com.atlassian.jira.plugi... ]
Steven Hawkins resolved TEIID-5852.
-----------------------------------
Resolution: Rejected
The purpose of the dual resolving is to first resolve just the query command, then to resolve view after adjustments have been made to the metadata. I wasn't successful even with skipping just the reparsing of the sql, let alone the re-resolving as there are corner cases about each situation. Unless we move the knowledge of that up into the metadata validation, then we should just leave this as is for now.
> views are resolved twice in the metadata validator
> --------------------------------------------------
>
> Key: TEIID-5852
> URL: https://issues.redhat.com/browse/TEIID-5852
> Project: Teiid
> Issue Type: Quality Risk
> Components: Query Engine
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.1
>
>
> There is an initial resolve to run the Validation visitor, then another resolve in resolveView. This should be combined as much as possible.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (TEIID-5866) Teiid embedded does not implement active vdb import management
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5866?page=com.atlassian.jira.plugi... ]
Work on TEIID-5866 started by Steven Hawkins.
---------------------------------------------
> Teiid embedded does not implement active vdb import management
> --------------------------------------------------------------
>
> Key: TEIID-5866
> URL: https://issues.redhat.com/browse/TEIID-5866
> Project: Teiid
> Issue Type: Quality Risk
> Components: Embedded
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.1
>
>
> This should initially be resolved by calling out the difference in handling in the docs. In short when you use vdb imports in embedded the import is processed at deployment time only. If the imported vdb later changes, it will cause any changes in importing vdbs.
> Note that in teiid-syndesis this import management logic was added via a custom vdb lifecycle listener, but that isn't quite the best solution given that we shouldn't be doing a lot of work in that thread.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years