[JBoss JIRA] (TEIID-5928) Allow External and Internal materialization of multi-source to fail/update individually
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5928?focusedWorklogId=12451742&pag... ]
Steven Hawkins logged work on TEIID-5928:
-----------------------------------------
Author: Steven Hawkins
Created on: 15/Jul/20 11:09 AM
Start Date: 15/Jul/20 11:08 AM
Worklog Time Spent: 1 day, 4 hours
Work Description: Accounting for both iterations of the development.
Issue Time Tracking
-------------------
Time Spent: 1 day, 4 hours, 30 minutes (was: 30 minutes)
Worklog Id: (was: 12451742)
> Allow External and Internal materialization of multi-source to fail/update individually
> ---------------------------------------------------------------------------------------
>
> Key: TEIID-5928
> URL: https://issues.redhat.com/browse/TEIID-5928
> Project: Teiid
> Issue Type: Enhancement
> Components: Common
> Affects Versions: 12.2.2
> Reporter: Rafael Sampaio
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 15.0
>
> Original Estimate: 1 day, 4 hours
> Time Spent: 1 day, 4 hours, 30 minutes
> Remaining Estimate: 0 minutes
>
> Hi, all.
> First of all thanks in advance for your attention, and efforts on such a great product.
> Since I haven't found any docs or examples regarding my current usage (please if this already exists or there's a better way of doing this, disregard this request and advice) here goes my suggestion:
> It would be nice to have a way to gracefully update/fail per source, if a view that has Materialization enabled and target a multi-source source model, because things can get, messy if I have to create a view per source and Materialize each one and only then create a unified (UNION) view.
> Using this approach also obligates me to implement custom insert/update/delete/based on the discriminator column.
> Thanks again.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5928) Allow External and Internal materialization of multi-source to fail/update individually
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5928?page=com.atlassian.jira.plugi... ]
Steven Hawkins resolved TEIID-5928.
-----------------------------------
Resolution: Done
Marking as resolved. Added for external materialization when using the loadnumber strategy, and for internal materialization - which has some additional caveats noted in the docs. Additional work to smooth out the limitations or add support for external without specifying the loadnumber is possible, but it would be best to get some usage out of this first.
> Allow External and Internal materialization of multi-source to fail/update individually
> ---------------------------------------------------------------------------------------
>
> Key: TEIID-5928
> URL: https://issues.redhat.com/browse/TEIID-5928
> Project: Teiid
> Issue Type: Enhancement
> Components: Common
> Affects Versions: 12.2.2
> Reporter: Rafael Sampaio
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 15.0
>
> Original Estimate: 1 day, 4 hours
> Time Spent: 30 minutes
> Remaining Estimate: 0 minutes
>
> Hi, all.
> First of all thanks in advance for your attention, and efforts on such a great product.
> Since I haven't found any docs or examples regarding my current usage (please if this already exists or there's a better way of doing this, disregard this request and advice) here goes my suggestion:
> It would be nice to have a way to gracefully update/fail per source, if a view that has Materialization enabled and target a multi-source source model, because things can get, messy if I have to create a view per source and Materialize each one and only then create a unified (UNION) view.
> Using this approach also obligates me to implement custom insert/update/delete/based on the discriminator column.
> Thanks again.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5987) Plan with join removal returns unexpected values
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5987?page=com.atlassian.jira.plugi... ]
Steven Hawkins resolved TEIID-5987.
-----------------------------------
Resolution: Done
Corrected the handling by adding is null (similar to what the salesforce translator has to do) predicates in the inner join case. This does not deeply introspect whether it's possible for the column to be null, which can be added later.
> Plan with join removal returns unexpected values
> ------------------------------------------------
>
> Key: TEIID-5987
> URL: https://issues.redhat.com/browse/TEIID-5987
> Project: Teiid
> Issue Type: Bug
> Components: Salesforce Connector
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Critical
> Fix For: 15.0, 13.1.2, 14.0.1
>
> Original Estimate: 4 hours
> Time Spent: 3 hours
> Remaining Estimate: 1 hour
>
> In testing TEIIDSB-213 I can see that a query such as:
> select a1.id from Account a1 inner join account a2 on a1.parentid = a2.id
> actually returns results, but no are expected.
> Whereas
> select a1.id from Account a1 where a1.parentid is not null
> returns no results as expected
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5987) Plan with join removal returns unexpected values
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5987?focusedWorklogId=12451732&pag... ]
Steven Hawkins logged work on TEIID-5987:
-----------------------------------------
Author: Steven Hawkins
Created on: 14/Jul/20 1:41 PM
Start Date: 14/Jul/20 1:41 PM
Worklog Time Spent: 3 hours
Issue Time Tracking
-------------------
Remaining Estimate: 1 hour (was: 4 hours)
Time Spent: 3 hours
Worklog Id: (was: 12451732)
> Plan with join removal returns unexpected values
> ------------------------------------------------
>
> Key: TEIID-5987
> URL: https://issues.redhat.com/browse/TEIID-5987
> Project: Teiid
> Issue Type: Bug
> Components: Salesforce Connector
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Critical
> Fix For: 15.0, 13.1.2, 14.0.1
>
> Original Estimate: 4 hours
> Time Spent: 3 hours
> Remaining Estimate: 1 hour
>
> In testing TEIIDSB-213 I can see that a query such as:
> select a1.id from Account a1 inner join account a2 on a1.parentid = a2.id
> actually returns results, but no are expected.
> Whereas
> select a1.id from Account a1 where a1.parentid is not null
> returns no results as expected
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5987) Plan with join removal returns unexpected values
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5987?page=com.atlassian.jira.plugi... ]
Steven Hawkins updated TEIID-5987:
----------------------------------
Description:
In testing TEIIDSB-213 I can see that a query such as:
select a1.id from Account a1 inner join account a2 on a1.parentid = a2.id
actually returns results, but no are expected.
Whereas
select a1.id from Account a1 where a1.parentid is not null
returns no results as expected
was:
I'm not sure about the full scope of this issue. In testing TEIIDSB-213 I can see that a query such as:
select a1.id from Account a1 inner join account a2 on a1.parentid = a2.id
which results in the source query with the implicit null check:
SELECT Id FROM Account WHERE ParentId != NULL
actually returns results, but no are expected.
The explicit non-join query query
select a1.id from Account a1 where a1.parentid is not null
result in:
SELECT Id FROM Account WHERE ParentId != NULL
but returns no results
So there is something in the join handling that is not working as expected.
Summary: Plan with join removal returns unexpected values (was: salesforce self join involving implicit null check on parentid field not working)
> Plan with join removal returns unexpected values
> ------------------------------------------------
>
> Key: TEIID-5987
> URL: https://issues.redhat.com/browse/TEIID-5987
> Project: Teiid
> Issue Type: Bug
> Components: Salesforce Connector
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Critical
> Fix For: 15.0, 13.1.2, 14.0.1
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> In testing TEIIDSB-213 I can see that a query such as:
> select a1.id from Account a1 inner join account a2 on a1.parentid = a2.id
> actually returns results, but no are expected.
> Whereas
> select a1.id from Account a1 where a1.parentid is not null
> returns no results as expected
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5987) salesforce self join involving implicit null check on parentid field not working
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5987?page=com.atlassian.jira.plugi... ]
Steven Hawkins commented on TEIID-5987:
---------------------------------------
Actually this is a problem introduced by TEIID-4880 as it's converting this self join scenario into just a table scan. I'm not sure if the logic there is not accounting for this case or if there's a metadata issue.
> salesforce self join involving implicit null check on parentid field not working
> --------------------------------------------------------------------------------
>
> Key: TEIID-5987
> URL: https://issues.redhat.com/browse/TEIID-5987
> Project: Teiid
> Issue Type: Bug
> Components: Salesforce Connector
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Critical
> Fix For: 15.0, 13.1.2, 14.0.1
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> I'm not sure about the full scope of this issue. In testing TEIIDSB-213 I can see that a query such as:
> select a1.id from Account a1 inner join account a2 on a1.parentid = a2.id
> which results in the source query with the implicit null check:
> SELECT Id FROM Account WHERE ParentId != NULL
> actually returns results, but no are expected.
> The explicit non-join query query
> select a1.id from Account a1 where a1.parentid is not null
> result in:
> SELECT Id FROM Account WHERE ParentId != NULL
> but returns no results
> So there is something in the join handling that is not working as expected.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5987) salesforce self join involving implicit null check on parentid field not working
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5987?page=com.atlassian.jira.plugi... ]
Work on TEIID-5987 started by Steven Hawkins.
---------------------------------------------
> salesforce self join involving implicit null check on parentid field not working
> --------------------------------------------------------------------------------
>
> Key: TEIID-5987
> URL: https://issues.redhat.com/browse/TEIID-5987
> Project: Teiid
> Issue Type: Bug
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
>
> I'm not sure about the full scope of this issue. In testing TEIIDSB-213 I can see that a query such as:
> select a1.id from Account a1 inner join account a2 on a1.parentid = a2.id
> which results in the source query with the implicit null check:
> SELECT Id FROM Account WHERE ParentId != NULL
> actually returns results, but no are expected.
> The explicit non-join query query
> select a1.id from Account a1 where a1.parentid is not null
> result in:
> SELECT Id FROM Account WHERE ParentId != NULL
> but returns no results
> So there is something in the join handling that is not working as expected.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (TEIID-5987) salesforce self join involving implicit null check on parentid field not working
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5987?page=com.atlassian.jira.plugi... ]
Steven Hawkins updated TEIID-5987:
----------------------------------
Component/s: Salesforce Connector
Fix Version/s: 15.0
13.1.2
14.0.1
Original Estimate: 4 hours
Remaining Estimate: 4 hours
Story Points: 0.5
Sprint: DV Sprint 66
Priority: Critical (was: Major)
> salesforce self join involving implicit null check on parentid field not working
> --------------------------------------------------------------------------------
>
> Key: TEIID-5987
> URL: https://issues.redhat.com/browse/TEIID-5987
> Project: Teiid
> Issue Type: Bug
> Components: Salesforce Connector
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Critical
> Fix For: 15.0, 13.1.2, 14.0.1
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> I'm not sure about the full scope of this issue. In testing TEIIDSB-213 I can see that a query such as:
> select a1.id from Account a1 inner join account a2 on a1.parentid = a2.id
> which results in the source query with the implicit null check:
> SELECT Id FROM Account WHERE ParentId != NULL
> actually returns results, but no are expected.
> The explicit non-join query query
> select a1.id from Account a1 where a1.parentid is not null
> result in:
> SELECT Id FROM Account WHERE ParentId != NULL
> but returns no results
> So there is something in the join handling that is not working as expected.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months