[JBoss JIRA] (TEIID-6008) Add support for maps
by Steven Hawkins (Jira)
Steven Hawkins created TEIID-6008:
-------------------------------------
Summary: Add support for maps
Key: TEIID-6008
URL: https://issues.redhat.com/browse/TEIID-6008
Project: Teiid
Issue Type: Feature Request
Components: Query Engine
Reporter: Steven Hawkins
Assignee: Steven Hawkins
We should either add a strongly typed map, similar to the array type handling that accepts operations directly - map['key'] - or expand json syntax to postgresql jsonb handling for ->> to make json objects usable as maps.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 9 months
[JBoss JIRA] (TEIIDSB-223) Issues with connection_factories.json and operator
by Ramesh Reddy (Jira)
[ https://issues.redhat.com/browse/TEIIDSB-223?page=com.atlassian.jira.plug... ]
Ramesh Reddy edited comment on TEIIDSB-223 at 8/4/20 3:49 PM:
--------------------------------------------------------------
`makefile` had the `operator-sdk` at wrong version, it should have been `0.17.0` updated now, so run generate once it should correct it.
update: yes, I see `make ci` failing, I will take a look
was (Author: rareddy):
`makefile` had the `operator-sdk` at wrong version, it should have been `0.17.0` updated now, so run generate once it should correct it.
> Issues with connection_factories.json and operator
> --------------------------------------------------
>
> Key: TEIIDSB-223
> URL: https://issues.redhat.com/browse/TEIIDSB-223
> Project: Teiid Spring Boot
> Issue Type: Quality Risk
> Reporter: Steven Hawkins
> Assignee: Ramesh Reddy
> Priority: Major
> Fix For: 1.6.0
>
> Time Spent: 4 hours, 4 minutes
> Remaining Estimate: 0 minutes
>
> There are a couple of things that I hit updating the connection_factories.json:
> 1. The objectmapper is not set to use a predictable order for the json, so it may vary by vm leading to needless file changes. We can just change the Main to add the sorted mapping feature.
> 2. The operator generation logic uses a settings.xml that does not specify snapshot access - if you do not locally build the teiid-spring-boot snapshot, then it will fail generation.
> 3. Even if you update the settings to have snapshot access, the generation logic must download nearly everything related to teiid-spring-boot. We could consider just running the generation step as part of the teiid-spring-boot build so that it is available as a single artifact.
> 4. The operator readme doesn't mention anything about running make generate (or related)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 9 months
[JBoss JIRA] (TEIIDSB-223) Issues with connection_factories.json and operator
by Ramesh Reddy (Jira)
[ https://issues.redhat.com/browse/TEIIDSB-223?page=com.atlassian.jira.plug... ]
Ramesh Reddy commented on TEIIDSB-223:
--------------------------------------
`makefile` had the `operator-sdk` at wrong version, it should have been `0.17.0` updated now, so run generate once it should correct it.
> Issues with connection_factories.json and operator
> --------------------------------------------------
>
> Key: TEIIDSB-223
> URL: https://issues.redhat.com/browse/TEIIDSB-223
> Project: Teiid Spring Boot
> Issue Type: Quality Risk
> Reporter: Steven Hawkins
> Assignee: Ramesh Reddy
> Priority: Major
> Fix For: 1.6.0
>
> Time Spent: 4 hours, 4 minutes
> Remaining Estimate: 0 minutes
>
> There are a couple of things that I hit updating the connection_factories.json:
> 1. The objectmapper is not set to use a predictable order for the json, so it may vary by vm leading to needless file changes. We can just change the Main to add the sorted mapping feature.
> 2. The operator generation logic uses a settings.xml that does not specify snapshot access - if you do not locally build the teiid-spring-boot snapshot, then it will fail generation.
> 3. Even if you update the settings to have snapshot access, the generation logic must download nearly everything related to teiid-spring-boot. We could consider just running the generation step as part of the teiid-spring-boot build so that it is available as a single artifact.
> 4. The operator readme doesn't mention anything about running make generate (or related)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 9 months
[JBoss JIRA] (TEIIDSB-223) Issues with connection_factories.json and operator
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIIDSB-223?page=com.atlassian.jira.plug... ]
Steven Hawkins commented on TEIIDSB-223:
----------------------------------------
I'm trying to update travis to run make ci, but it looks like that may still not be good to do.
After "make generate" I'm seeing deploy/crds/teiid.io_virtualdatabases_crd.yaml as modified with changes to properties like:
{code}
- anyOf:
- - type: integer
- - type: string
- pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
- x-kubernetes-int-or-string: true
+ type: string
{code}
See https://github.com/shawkins/teiid-operator/commit/12a13b986281f2da79e4e65...
Is that occurring for you as well?
Also even with some cleanup from 12a13b986281f2da79e4e65b19d1b02526e25ab5 to the lint script "make lint" is failing with:
pkg/util/openshift/webconsole.go:26:1: exported function ConsoleYAMLSampleExists should have comment or be unexported
pkg/util/openshift/webconsole.go:31:1: exported function CreateConsoleYAMLSamples should have comment or be unexported
pkg/util/openshift/webconsole.go:70:1: exported function ConsoleLinkExists should have comment or be unexported
pkg/util/openshift/webconsole.go:75:1: exported function CreateConsoleLink should have comment or be unexported
pkg/util/openshift/webconsole.go:138:1: exported function RemoveConsoleLink should have comment or be unexported
Found 5 lint suggestions; failing.
make: *** [Makefile:48: lint] Error 1
There are a lot of other yaml errors, but they don't seem to be stopping the build.
> Issues with connection_factories.json and operator
> --------------------------------------------------
>
> Key: TEIIDSB-223
> URL: https://issues.redhat.com/browse/TEIIDSB-223
> Project: Teiid Spring Boot
> Issue Type: Quality Risk
> Reporter: Steven Hawkins
> Assignee: Ramesh Reddy
> Priority: Major
> Fix For: 1.6.0
>
> Time Spent: 4 hours, 4 minutes
> Remaining Estimate: 0 minutes
>
> There are a couple of things that I hit updating the connection_factories.json:
> 1. The objectmapper is not set to use a predictable order for the json, so it may vary by vm leading to needless file changes. We can just change the Main to add the sorted mapping feature.
> 2. The operator generation logic uses a settings.xml that does not specify snapshot access - if you do not locally build the teiid-spring-boot snapshot, then it will fail generation.
> 3. Even if you update the settings to have snapshot access, the generation logic must download nearly everything related to teiid-spring-boot. We could consider just running the generation step as part of the teiid-spring-boot build so that it is available as a single artifact.
> 4. The operator readme doesn't mention anything about running make generate (or related)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 9 months
[JBoss JIRA] (TEIIDSB-223) Issues with connection_factories.json and operator
by Ramesh Reddy (Jira)
[ https://issues.redhat.com/browse/TEIIDSB-223?focusedWorklogId=12451859&pa... ]
Ramesh Reddy logged work on TEIIDSB-223:
----------------------------------------
Author: Ramesh Reddy
Created on: 04/Aug/20 3:02 PM
Start Date: 04/Aug/20 3:02 PM
Worklog Time Spent: 4 hours
Issue Time Tracking
-------------------
Time Spent: 4 hours, 4 minutes (was: 4 minutes)
Worklog Id: (was: 12451859)
> Issues with connection_factories.json and operator
> --------------------------------------------------
>
> Key: TEIIDSB-223
> URL: https://issues.redhat.com/browse/TEIIDSB-223
> Project: Teiid Spring Boot
> Issue Type: Quality Risk
> Reporter: Steven Hawkins
> Assignee: Ramesh Reddy
> Priority: Major
> Fix For: 1.6.0
>
> Time Spent: 4 hours, 4 minutes
> Remaining Estimate: 0 minutes
>
> There are a couple of things that I hit updating the connection_factories.json:
> 1. The objectmapper is not set to use a predictable order for the json, so it may vary by vm leading to needless file changes. We can just change the Main to add the sorted mapping feature.
> 2. The operator generation logic uses a settings.xml that does not specify snapshot access - if you do not locally build the teiid-spring-boot snapshot, then it will fail generation.
> 3. Even if you update the settings to have snapshot access, the generation logic must download nearly everything related to teiid-spring-boot. We could consider just running the generation step as part of the teiid-spring-boot build so that it is available as a single artifact.
> 4. The operator readme doesn't mention anything about running make generate (or related)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 10 months
[JBoss JIRA] (TEIIDSB-223) Issues with connection_factories.json and operator
by Ramesh Reddy (Jira)
[ https://issues.redhat.com/browse/TEIIDSB-223?focusedWorklogId=12451858&pa... ]
Ramesh Reddy logged work on TEIIDSB-223:
----------------------------------------
Author: Ramesh Reddy
Created on: 04/Aug/20 3:02 PM
Start Date: 04/Aug/20 3:02 PM
Worklog Time Spent: 4 minutes
Issue Time Tracking
-------------------
Remaining Estimate: 0 minutes
Time Spent: 4 minutes
Worklog Id: (was: 12451858)
> Issues with connection_factories.json and operator
> --------------------------------------------------
>
> Key: TEIIDSB-223
> URL: https://issues.redhat.com/browse/TEIIDSB-223
> Project: Teiid Spring Boot
> Issue Type: Quality Risk
> Reporter: Steven Hawkins
> Assignee: Ramesh Reddy
> Priority: Major
> Fix For: 1.6.0
>
> Time Spent: 4 minutes
> Remaining Estimate: 0 minutes
>
> There are a couple of things that I hit updating the connection_factories.json:
> 1. The objectmapper is not set to use a predictable order for the json, so it may vary by vm leading to needless file changes. We can just change the Main to add the sorted mapping feature.
> 2. The operator generation logic uses a settings.xml that does not specify snapshot access - if you do not locally build the teiid-spring-boot snapshot, then it will fail generation.
> 3. Even if you update the settings to have snapshot access, the generation logic must download nearly everything related to teiid-spring-boot. We could consider just running the generation step as part of the teiid-spring-boot build so that it is available as a single artifact.
> 4. The operator readme doesn't mention anything about running make generate (or related)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
3 years, 10 months