[
https://issues.redhat.com/browse/TEIIDSB-197?page=com.atlassian.jira.plug...
]
Steven Hawkins commented on TEIIDSB-197:
----------------------------------------
which I agree to needs improvement here, to remove driver versions
from Operator
And that is exactly what I'm proposing to address here... I'm not sure why
I'm having such a hard time getting through to you on some of this :(
Another reason the driver versions designed this way was to override
them if user wanted to use a different version.
That should be completely discounted as a possibility. You can override dependencies in
the crd's themselves to do it on an ad hoc basis in your own custom operator would
make it extremely difficult to know what versions of things were actual in use.
I am reluctant to create 30 more projects with a single file to
remove one config file
Let me rephase that - you currently believe you can do as good of a job of dependency
management as maven in a single file. However I would counter that once you encounter
sources that need more than a single dependency and/or you need better traceability - then
it would be best to just rely on a standard system.
I completely miss the point you are making with
enviroment-post-processor, are saying no prefix needed at all? How am I passing the
properties I configured for a data source to a SB process? even if it is, why add more
complexity?
As far as the operator is concerned, yes there is no Teiid Spring Boot specific prefix
needed, just a general convention - then let Teiid Spring Boot convert the properties to
the actual property. So for example default everything to
spring.teiid.data.alias.property and let Teiid Spring Boot determine if it needs to
actually be spring.datasource, spring.datasource.xa, etc.
Pretty soon, I also would like to add property names and then
validate them when the CR is provided
I get that as a goal. But keep in mind it's not as straight forward as it seems.
There's a lot of pooling related properties that could be included, all of the
XADataSource properties (which aren't explicitly named by spring), or other similar
more free form / source driven properties. The more you commit to assumptions, the more
rigid and brittle things will become (for example are we prepared to fully commit to a
particular pooling implementation, or do we need to come up with abstractions).
Add a module for each external source
-------------------------------------
Key: TEIIDSB-197
URL:
https://issues.redhat.com/browse/TEIIDSB-197
Project: Teiid Spring Boot
Issue Type: Enhancement
Reporter: Steven Hawkins
Assignee: Ramesh Reddy
Priority: Major
To simplify the logic in the operator each external source should be represented by a
maven artifact - org.teiid:spring-data-x. Any dependency management would be handled in
that module and not in the operator - to remove the need for a config file containing
driver versions. Additionally property handling should be moved into Teiid Spring Boot
such that the operator does not need to know what property prefix is expected.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)