[
https://issues.jboss.org/browse/TEIID-5574?page=com.atlassian.jira.plugin...
]
Steven Hawkins commented on TEIID-5574:
---------------------------------------
maxReservedKb -> maxReservedHeapKb -> heapMemoryMaxReservedInKb
(making the "heapMemory" word as prefix consistent across)
That would be something like:
heapBufferMaxReservedKb
heapBufferReservedByActivePlansKb
heapBufferInUseKb
Part of the reason for the subtle difference is that max reserve is not a hard limit for
what is actually in use (see above).
heapCacheMemoryInUseKB -> heapBufferInUseKb ->
heapMemoryInUseKb (may be drop "buffer" every where?)
The danger in that is that buffer differentiates these properties to buffer manager.
diskMaxSpaceMb for example could apply to temp space as well.
This way it is easy and also works well in spring-boot with style
"heap-memory-max-reserved-in-kb" format.
Of course most of the other properties would need changed as well then.
Perhaps the question is how will work from a user perspective. I was specifically
starting with the bufferserivceimpl and renaming properties that were not sufficiently
descriptive.
How are you proposing this will map to spring? Are you reusing the EmbeddedConfiguration
or are you expecting to directly set properties on the BufferServiceImpl bean. And do you
expect any consistency with cli? In the cli we have existing properties like
buffer-service-max-reserve-kb, which with this change that would become
buffer-service-max-reserved-heap-mb or buffer-service-heap-max-reserved-mb if we redo the
property keys to be more consistent with prefixing.
Clarify buffer manager property names
-------------------------------------
Key: TEIID-5574
URL:
https://issues.jboss.org/browse/TEIID-5574
Project: Teiid
Issue Type: Quality Risk
Components: Query Engine, Server
Reporter: Steven Hawkins
Assignee: Steven Hawkins
Priority: Major
Fix For: 12.0
Where possible the buffer manager properties should be better differentiated. Instead of
max-buffer-space for example, we could have max-buffer-disk-space-mb.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)