[ https://issues.jboss.org/browse/TEIID-2247?page=com.atlassian.jira.plugin... ] Steven Hawkins commented on TEIID-2247: --------------------------------------- These are all internal apis and will most definitely change in point releases to accommodate features. It is a long standing issue to get Teiid Designer off of Teiid's language objects. The TeiidRuntimeException constructors were removed since they no longer followed usage patterns in Teiid, but can be added back if needed. The modifications to RaiseErrorStatement and CreateProcedureCommand will not be undone. The change in RaiseErrorStatement reflects that it now represents a RAISE statement rather than an ERROR statement. Also the logic to determine the results command was not generally correct as there can be many results commands. If you want the results set columns post resolve, then use the getResultSetColumns method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIID-2247?page=com.atlassian.jira.plugin... ] Paul Richardson commented on TEIID-2247: ---------------------------------------- Fair enough ... Is there an obvious way to understand what are internal APIs and what TD should be using? Obviously X-Internal directives are out since they are eclipse-orientated but you get the idea. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIID-2247?page=com.atlassian.jira.plugin... ] Steven Hawkins commented on TEIID-2247: --------------------------------------- Paul, Will you need the changes to TeiidRuntimeException and/or what else is needed to resolve this issue? Steve -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIID-2247?page=com.atlassian.jira.plugin... ] Steven Hawkins commented on TEIID-2247: --------------------------------------- common-core is a little ambiguous on who should use what. It underlies our api module, but we make an effort to isolate anything that might change. For Teiid Designer we have considered it shared, but with Teiid weening out parts that it no longer needs - of which there used to be a significant amount. So if the fastest resolution is to add back the TeiidRuntimeException, that's ok. That is a perennial topic. The short version is that Teiid Designer through the Teiid Language objects reuses the Teiid parser/resolver/validator/sql-string logic. For Designer to duplicate all of that logic has never been feasible - although it has some obvious benefits for Teiid and allows for the UI to pursue other interesting problems, such as incremental parsing, better representation of the AST (although we can supply you with the raw JavaCC tokens as a workaroun), etc. So the approach has been to just let Teiid evolve and have the Designer logic make changes as needed. An incremental approach to the engine/language object dependency would be to have designer interact with the Teiid components via the query strings and supply parse/resolve/validation results that are appropriately consumable. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/TEIID-2247?page=com.atlassian.jira.plugin... ] Steven Hawkins updated TEIID-2247: ---------------------------------- Fix Version/s: (was: 8.2) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira