[JBoss JIRA] (CDI-697) Provide delegating/forwarding implementations of the annotated type model classes
by John Ament (JIRA)
[ https://issues.jboss.org/browse/CDI-697?page=com.atlassian.jira.plugin.sy... ]
John Ament reopened CDI-697:
----------------------------
Assignee: John Ament
Its agreed we should provide some clarification.
> Provide delegating/forwarding implementations of the annotated type model classes
> ---------------------------------------------------------------------------------
>
> Key: CDI-697
> URL: https://issues.jboss.org/browse/CDI-697
> Project: CDI Specification Issues
> Issue Type: Feature Request
> Components: Portable Extensions
> Reporter: Laird Nelson
> Assignee: John Ament
> Priority: Minor
>
> A lot of duplicate efforts could be eliminated if the CDI SPI supplied delegating implementations of each of the {{Annotated*}} SPI interfaces. These implementations would assist in creating objects suitable for passing to {{ProcessAnnotatedType#setAnnotatedType(AnnotatedType)}} (and the like) when the configurator APIs prove to be too simplistic.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 9 months
Public review ballot result
by Antoine Sabot-Durand
Hi all,
So the public review ballot closed yesterday and all EC member voted yes.
Result is here: [1]
So we are entering the PFD (proposed final draft) step.
We still have one PR open and if you'd like to see some typo or
clarification tickets being added to PFD it's still time to discuss as I
plan to propose the PFD by the end of the week.
When PFD will be submitted, it will trigger a final vote (2 weeks) and if
it is accepted final version will be submitted.
Antoine
[1] https://jcp.org/en/jsr/results?id=5925
7 years, 9 months
[JBoss JIRA] (CDI-697) Provide delegating/forwarding implementations of the annotated type model classes
by Matej Novotny (JIRA)
[ https://issues.jboss.org/browse/CDI-697?page=com.atlassian.jira.plugin.sy... ]
Matej Novotny commented on CDI-697:
-----------------------------------
We might want to add a clarification that {{AnnotatedTypeConfigurator#fields()}} and {{AnnotatedTypeConfigurator#filterFields()}} operate on a set of annotated fields equal to invocation of {{AnnotatedType#getFields()}} on the given type.
I kind of agree with Laird that it's not really obvious.
> Provide delegating/forwarding implementations of the annotated type model classes
> ---------------------------------------------------------------------------------
>
> Key: CDI-697
> URL: https://issues.jboss.org/browse/CDI-697
> Project: CDI Specification Issues
> Issue Type: Feature Request
> Components: Portable Extensions
> Reporter: Laird Nelson
> Priority: Minor
>
> A lot of duplicate efforts could be eliminated if the CDI SPI supplied delegating implementations of each of the {{Annotated*}} SPI interfaces. These implementations would assist in creating objects suitable for passing to {{ProcessAnnotatedType#setAnnotatedType(AnnotatedType)}} (and the like) when the configurator APIs prove to be too simplistic.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 9 months
[JBoss JIRA] (CDI-697) Provide delegating/forwarding implementations of the annotated type model classes
by John Ament (JIRA)
[ https://issues.jboss.org/browse/CDI-697?page=com.atlassian.jira.plugin.sy... ]
John Ament commented on CDI-697:
--------------------------------
[~antoinesabot-durand] Anything you think we need to do to clarify that this is the case?
> Provide delegating/forwarding implementations of the annotated type model classes
> ---------------------------------------------------------------------------------
>
> Key: CDI-697
> URL: https://issues.jboss.org/browse/CDI-697
> Project: CDI Specification Issues
> Issue Type: Feature Request
> Components: Portable Extensions
> Reporter: Laird Nelson
> Priority: Minor
>
> A lot of duplicate efforts could be eliminated if the CDI SPI supplied delegating implementations of each of the {{Annotated*}} SPI interfaces. These implementations would assist in creating objects suitable for passing to {{ProcessAnnotatedType#setAnnotatedType(AnnotatedType)}} (and the like) when the configurator APIs prove to be too simplistic.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 9 months
[JBoss JIRA] (CDI-697) Provide delegating/forwarding implementations of the annotated type model classes
by John Ament (JIRA)
[ https://issues.jboss.org/browse/CDI-697?page=com.atlassian.jira.plugin.sy... ]
John Ament commented on CDI-697:
--------------------------------
I agree, but here's what the spec says
bq. getFields() returns all default-access, public, protected or private fields declared on the type and those declared on any supertypes. The container should call AnnotatedField.getJavaMember().getDeclaringClass() to determine the type in the type hierarchy that declared the field.
The problem is that 11.4.1 doesn't clarify that fields() etc use these same rules. I think that's something easy to clarify in the spec text.
> Provide delegating/forwarding implementations of the annotated type model classes
> ---------------------------------------------------------------------------------
>
> Key: CDI-697
> URL: https://issues.jboss.org/browse/CDI-697
> Project: CDI Specification Issues
> Issue Type: Feature Request
> Components: Portable Extensions
> Reporter: Laird Nelson
> Priority: Minor
>
> A lot of duplicate efforts could be eliminated if the CDI SPI supplied delegating implementations of each of the {{Annotated*}} SPI interfaces. These implementations would assist in creating objects suitable for passing to {{ProcessAnnotatedType#setAnnotatedType(AnnotatedType)}} (and the like) when the configurator APIs prove to be too simplistic.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 9 months
[JBoss JIRA] (CDI-697) Provide delegating/forwarding implementations of the annotated type model classes
by Laird Nelson (JIRA)
[ https://issues.jboss.org/browse/CDI-697?page=com.atlassian.jira.plugin.sy... ]
Laird Nelson commented on CDI-697:
----------------------------------
Oh! It does indeed return {{private}} fields of the supertypes.
I'll close this issue. Before I do, do consider spelling out the fact that methods like {{fields()}} return _all_ fields from the _entire type hierarchy_, which I don't think is clear (or at least was not clear to me, playing the role of guinea pig).
> Provide delegating/forwarding implementations of the annotated type model classes
> ---------------------------------------------------------------------------------
>
> Key: CDI-697
> URL: https://issues.jboss.org/browse/CDI-697
> Project: CDI Specification Issues
> Issue Type: Feature Request
> Components: Portable Extensions
> Reporter: Laird Nelson
> Priority: Minor
>
> A lot of duplicate efforts could be eliminated if the CDI SPI supplied delegating implementations of each of the {{Annotated*}} SPI interfaces. These implementations would assist in creating objects suitable for passing to {{ProcessAnnotatedType#setAnnotatedType(AnnotatedType)}} (and the like) when the configurator APIs prove to be too simplistic.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 9 months
[JBoss JIRA] (CDI-697) Provide delegating/forwarding implementations of the annotated type model classes
by Laird Nelson (JIRA)
[ https://issues.jboss.org/browse/CDI-697?page=com.atlassian.jira.plugin.sy... ]
Laird Nelson commented on CDI-697:
----------------------------------
I don't _believe_ I'm observing that behavior; I'll check.
> Provide delegating/forwarding implementations of the annotated type model classes
> ---------------------------------------------------------------------------------
>
> Key: CDI-697
> URL: https://issues.jboss.org/browse/CDI-697
> Project: CDI Specification Issues
> Issue Type: Feature Request
> Components: Portable Extensions
> Reporter: Laird Nelson
> Priority: Minor
>
> A lot of duplicate efforts could be eliminated if the CDI SPI supplied delegating implementations of each of the {{Annotated*}} SPI interfaces. These implementations would assist in creating objects suitable for passing to {{ProcessAnnotatedType#setAnnotatedType(AnnotatedType)}} (and the like) when the configurator APIs prove to be too simplistic.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 9 months
[JBoss JIRA] (CDI-697) Provide delegating/forwarding implementations of the annotated type model classes
by John Ament (JIRA)
[ https://issues.jboss.org/browse/CDI-697?page=com.atlassian.jira.plugin.sy... ]
John Ament commented on CDI-697:
--------------------------------
Good question. We don't call it out, but I would assume it should. How do others feel? Martin? Mark? Antoine?
> Provide delegating/forwarding implementations of the annotated type model classes
> ---------------------------------------------------------------------------------
>
> Key: CDI-697
> URL: https://issues.jboss.org/browse/CDI-697
> Project: CDI Specification Issues
> Issue Type: Feature Request
> Components: Portable Extensions
> Reporter: Laird Nelson
> Priority: Minor
>
> A lot of duplicate efforts could be eliminated if the CDI SPI supplied delegating implementations of each of the {{Annotated*}} SPI interfaces. These implementations would assist in creating objects suitable for passing to {{ProcessAnnotatedType#setAnnotatedType(AnnotatedType)}} (and the like) when the configurator APIs prove to be too simplistic.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
7 years, 9 months