[JBoss JIRA] (CDI-620) Not clear what the id for an annotated type is.
by Martin Kouba (JIRA)
[ https://issues.jboss.org/browse/CDI-620?page=com.atlassian.jira.plugin.sy... ]
Martin Kouba commented on CDI-620:
----------------------------------
Yep, the ordering of {{AfterTypeDiscovery.addAnnotatedType(String, Class<T>)}} should be the same as {{AfterTypeDiscovery.addAnnotatedType(AnnotatedType<?>, String)}}.
The identifier is used to distinguish multiple AnnotatedTypes per the same Java class. See also the javadoc:
{quote}
This method allows multiple annotated types, based on the same underlying type, to be defined. {{AnnotatedType}}s discovered by the container use the fully qualified class name of {{AnnotatedType#getJavaClass()}} to identify the type.
{quote}
For more details see also https://issues.jboss.org/browse/CDI-58.
WRT impl. detail of {{AfterTypeDiscovery.addAnnotatedType(AnnotatedType<?>, String)}} - Weld generates a unique id for an annotated type if the id is null.
> Not clear what the id for an annotated type is.
> -----------------------------------------------
>
> Key: CDI-620
> URL: https://issues.jboss.org/browse/CDI-620
> Project: CDI Specification Issues
> Issue Type: Clarification
> Reporter: John Ament
>
> The docs for AfterTypeDiscovery.addAnnotatedType(String, Class) do not state what the id is.
> In addition, it's odd that the addAnnotatedType(AnnotatedType, String) is in that order, and this method is in this order.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 9 months
Re: [cdi-dev] [VOTE] Name the class that can start/stop contexts
by Werner Keil
Seems the vote got swamped among many other messages both here and in my
mailbox;-O
The arguments leading towards the winning name sound good and logical, so
that would be my vote, too.
Werner
On Mon, Jul 18, 2016 at 12:02 PM, <cdi-dev-request(a)lists.jboss.org> wrote:
> Send cdi-dev mailing list submissions to
> cdi-dev(a)lists.jboss.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://lists.jboss.org/mailman/listinfo/cdi-dev
> or, via email, send a message with subject or body 'help' to
> cdi-dev-request(a)lists.jboss.org
>
> You can reach the person managing the list at
> cdi-dev-owner(a)lists.jboss.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of cdi-dev digest..."
>
>
> Today's Topics:
>
> 1. Re: [VOTE] Name the class that can start/stop contexts
> (John D. Ament)
> 2. ManageableContext hierarchy (John D. Ament)
> 3. Passed: cdi-spec/cdi#22 (2.0-EDR2 - 5b77f45) (Travis CI)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Fri, 15 Jul 2016 02:13:04 +0000
> From: "John D. Ament" <john.d.ament(a)gmail.com>
> Subject: Re: [cdi-dev] [VOTE] Name the class that can start/stop
> contexts
> To: Emily Jiang <EMIJIANG(a)uk.ibm.com>, Antoine Sabot-Durand
> <antoine(a)sabot-durand.net>
> Cc: cdi-dev(a)lists.jboss.org
> Message-ID:
> <
> CAOqetn_E0u6HCOyb5mm7hv-NRqxBKjwykz7v1YW0ynvYxtZPBw(a)mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
>
> All,
>
> Thanks for those who voted.
>
> 2 votes for ManageableContext
> 1 vote for ManagedContext
> 1 vote for UserManagedContext
>
> Therefore I'm declaring the winner ManageableContext.
>
> John
>
> On Mon, Jul 11, 2016 at 6:23 PM Emily Jiang <EMIJIANG(a)uk.ibm.com> wrote:
>
> > We are trying to find a better name than UnManagedContext.
> >
> > ManagedContext is surely opposite to the option UnManagedContext:o.
> >
> > ManagableContext fits well with AlternableContext. In addition,
> > ManagableContext should be managed by others, which is the same as
> > UserManagedContext and it is shorter.
> >
> > Hence, +1 for ManagableContext.
> >
> > Many thanks,
> > Emily
> > ===========================
> > Emily Jiang
> > WebSphere Application Server, CDI Development Lead
> >
> > MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN
> > Phone: +44 (0)1962 816278 Internal: 246278
> >
> > Email: emijiang(a)uk.ibm.com
> > Lotus Notes: Emily Jiang/UK/IBM@IBMGB
> >
> >
> >
> >
> > From: Antoine Sabot-Durand <antoine(a)sabot-durand.net>
> > To: Matej Novotny <manovotn(a)redhat.com>, "John D. Ament" <
> > john.d.ament(a)gmail.com>,
> > Cc: cdi-dev(a)lists.jboss.org
> > Date: 11/07/2016 15:12
> > Subject: Re: [cdi-dev] [VOTE] Name the class that can start/stop
> > contexts
> > Sent by: cdi-dev-bounces(a)lists.jboss.org
> > ------------------------------
> >
> >
> >
> > +1 for UserManagedContext, it says clearly that user is in charge of
> > managing the context.
> > ManageableContext is ok as fallback to me but the fact the the context is
> > manageable does not says anything about who has the responsibility to
> > manage it.
> >
> >
> > Le lun. 11 juil. 2016 ? 11:02, Matej Novotny <*manovotn(a)redhat.com*
> > <manovotn(a)redhat.com>> a ?crit :
> > +1 for ManageableContext
> >
> > Personally I would still have UnmanagedContext, but since that seems
> > ambiguous (as does ManagedContext),
> > I chose ManageableContext.
> >
> > Matej
> >
> > ----- Original Message -----
> > > From: "John D. Ament" <*john.d.ament(a)gmail.com* <
> john.d.ament(a)gmail.com>
> > >
> > > To: *cdi-dev(a)lists.jboss.org* <cdi-dev(a)lists.jboss.org>
> > > Sent: Monday, July 11, 2016 2:50:23 AM
> > > Subject: [cdi-dev] [VOTE] Name the class that can start/stop contexts
> > >
> > > All,
> > >
> > > It seems like one of the remaining issues with CDI-30 is the name for
> the
> > > class for the context management. This name isn't permanent, we can
> > change
> > > after EDR2, but not after final.
> > >
> > > Here's the proposed renames for "UnmanagedContext":
> > >
> > > - ManagedContext
> > > - ManageableContext
> > > - ProgrammaticContext
> > > - ExternallyManagedContext
> > > - UserManagedContext
> > >
> > > Please respond back with your vote, I'll leave this open for 3 days ( I
> > > believe its Monday morning in central Europe), so I'll close it
> Thursday
> > > morning.
> > >
> > > Reference:
> > >
> > *
> http://transcripts.jboss.org/meeting/irc.freenode.org/cdi-dev/2016/cdi-de...
> > <
> http://transcripts.jboss.org/meeting/irc.freenode.org/cdi-dev/2016/cdi-de...
> >
> > >
> > > - John
> > >
> > > _______________________________________________
> > > cdi-dev mailing list
> > > *cdi-dev(a)lists.jboss.org* <cdi-dev(a)lists.jboss.org>
> > > *https://lists.jboss.org/mailman/listinfo/cdi-dev*
> > <https://lists.jboss.org/mailman/listinfo/cdi-dev>
> > >
> > > Note that for all code provided on this list, the provider licenses the
> > code
> > > under the Apache License, Version 2
> > > (*http://www.apache.org/licenses/LICENSE-2.0.html*
> > <http://www.apache.org/licenses/LICENSE-2.0.html>). For all other ideas
> > > provided on this list, the provider waives all patent and other
> > intellectual
> > > property rights inherent in such information.
> > _______________________________________________
> > cdi-dev mailing list
> > *cdi-dev(a)lists.jboss.org* <cdi-dev(a)lists.jboss.org>
> > *https://lists.jboss.org/mailman/listinfo/cdi-dev*
> > <https://lists.jboss.org/mailman/listinfo/cdi-dev>
> >
> > Note that for all code provided on this list, the provider licenses the
> > code under the Apache License, Version 2 (
> > *http://www.apache.org/licenses/LICENSE-2.0.html*
> > <http://www.apache.org/licenses/LICENSE-2.0.html>). For all other ideas
> > provided on this list, the provider waives all patent and other
> > intellectual property rights inherent in such information.
> > _______________________________________________
> > cdi-dev mailing list
> > cdi-dev(a)lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/cdi-dev
> >
> > Note that for all code provided on this list, the provider licenses the
> > code under the Apache License, Version 2 (
> > http://www.apache.org/licenses/LICENSE-2.0.html). For all other ideas
> > provided on this list, the provider waives all patent and other
> > intellectual property rights inherent in such information.
> >
> > Unless stated otherwise above:
> > IBM United Kingdom Limited - Registered in England and Wales with number
> > 741598.
> > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> 3AU
> >
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> http://lists.jboss.org/pipermail/cdi-dev/attachments/20160715/7cfdde8c/at...
>
> ------------------------------
>
> Message: 2
> Date: Fri, 15 Jul 2016 22:38:46 +0000
> From: "John D. Ament" <john.d.ament(a)gmail.com>
> Subject: [cdi-dev] ManageableContext hierarchy
> To: "cdi-dev(a)lists.jboss.org" <cdi-dev(a)lists.jboss.org>
> Message-ID:
> <CAOqetn-mmfuWWTtgKiiMbV=WP36gKLM2=Pivr7Vb2v=
> UyFm2Ng(a)mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
>
> All,
>
> One of the items from our last conversation was to remove the hierarchy
> changes for ManageableContext.
>
> I'd like to propose that we re-evaluate the hierarchy post EDR2, to avoid
> too many changes. This is related to CDI-30.
>
> If agreed, I can create a follow up ticket.
>
> John
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> http://lists.jboss.org/pipermail/cdi-dev/attachments/20160715/8967178a/at...
>
> ------------------------------
>
> Message: 3
> Date: Mon, 18 Jul 2016 09:59:20 +0000
> From: Travis CI <builds(a)travis-ci.org>
> Subject: [cdi-dev] Passed: cdi-spec/cdi#22 (2.0-EDR2 - 5b77f45)
> To: <cdi-dev(a)lists.jboss.org>
> Message-ID:
>
> <578ca878916ce_33f98a949d7bc8168af(a)17287723-a229-46ff-8c0f-465f15696c07.mail
> >
>
> Content-Type: text/plain; charset="utf-8"
>
> Build Update for cdi-spec/cdi
> -------------------------------------
>
> Build: #22
> Status: Passed
>
> Duration: 8 minutes and 30 seconds
> Commit: 5b77f45 (2.0-EDR2)
> Author: Antoine Sabot-Durand
> Message: Adding travis CI config
>
> View the changeset:
> https://github.com/cdi-spec/cdi/compare/19a471aa497f...5b77f45d99d5
>
> View the full build log and details:
> https://travis-ci.org/cdi-spec/cdi/builds/145494191
>
> --
>
> You can configure recipients for build notifications in your .travis.yml
> file. See https://docs.travis-ci.com/user/notifications
>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> http://lists.jboss.org/pipermail/cdi-dev/attachments/20160718/f2041438/at...
>
> ------------------------------
>
> _______________________________________________
> cdi-dev mailing list
> cdi-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/cdi-dev
>
> Note that for all code provided on this list, the provider licenses the
> code under the Apache License, Version 2 (
> http://www.apache.org/licenses/LICENSE-2.0.html). For all other ideas
> provided on this list, the provider waives all patent and other
> intellectual property rights inherent in such information.
>
> End of cdi-dev Digest, Vol 68, Issue 8
> **************************************
>
7 years, 9 months
ManageableContext hierarchy
by John D. Ament
All,
One of the items from our last conversation was to remove the hierarchy
changes for ManageableContext.
I'd like to propose that we re-evaluate the hierarchy post EDR2, to avoid
too many changes. This is related to CDI-30.
If agreed, I can create a follow up ticket.
John
7 years, 9 months
[VOTE] Name the class that can start/stop contexts
by John D. Ament
All,
It seems like one of the remaining issues with CDI-30 is the name for the
class for the context management. This name isn't permanent, we can change
after EDR2, but not after final.
Here's the proposed renames for "UnmanagedContext":
- ManagedContext
- ManageableContext
- ProgrammaticContext
- ExternallyManagedContext
- UserManagedContext
Please respond back with your vote, I'll leave this open for 3 days ( I
believe its Monday morning in central Europe), so I'll close it Thursday
morning.
Reference:
http://transcripts.jboss.org/meeting/irc.freenode.org/cdi-dev/2016/cdi-de...
- John
7 years, 10 months
[JBoss JIRA] (CDI-480) Introduce real link between spec doc and TCK
by Tomas Remes (JIRA)
[ https://issues.jboss.org/browse/CDI-480?page=com.atlassian.jira.plugin.sy... ]
Tomas Remes commented on CDI-480:
---------------------------------
Can we mark this as resolved now?
> Introduce real link between spec doc and TCK
> --------------------------------------------
>
> Key: CDI-480
> URL: https://issues.jboss.org/browse/CDI-480
> Project: CDI Specification Issues
> Issue Type: Feature Request
> Affects Versions: 1.1.Final
> Reporter: Antoine Sabot-Durand
>
> One of the nicest thing in CDI TCK is the audit files. These XML files (like : https://github.com/cdi-spec/cdi-tck/blob/master/impl/src/main/resources/t...) list all challenges coming from the specification and allow to bind a given test to a given challenge thanks to {{@SpecAssertion}} annotation (see https://github.com/cdi-spec/cdi-tck/blob/master/impl/src/main/java/org/jb... for instance).
> This system is great to know what assertions are broken, retrieve what spec rule is tested from the code and have nice report on spec coverage in TCK.
> The only weakness here is that these audit files are only maintained "by hand" when we could (perhaps) have an automatic or semi-automatic way of generating them or at least checking them against the spec.
> Since the spec doc is generated with Asciidoctor, this could be done by creating an Asciidoctor macro or extension (not sure of the terminology) and add a meta data set to each rule written in the spec (allowing to have one or more test for one rule). These meta could be used to help generate the xml file for the TCK or at least check that they contains all rules from the spec.
> The immediate benefit I see here would be :
> # make the spec contributors more concerned about TCK
> # reduce the risk of forgetting rules in TCK
> # produce a version of the spec with links to TCK test
> # reduce the fear of refactoring the spec if needed
>
> To make short, if this "unification" could be done, it would probably give us more efficiency and improve spec and TCK quality.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 10 months
In F2F meeting all week
by Antoine Sabot-Durand
Hi All,
I'll be at a Red Hat F2F meeting from tomorrow to Friday. I'll check my
mail but won't be available for our meeting.
Antoine
7 years, 10 months
