Hi, while developing a plugin I found that I cannot access org.mvel classes. - if I install my plugin w/o specific dependency declaration I get: java.lang.NoClassDefFoundError: org/mvel2/templates/CompiledTemplate - if I try to package my own org.mvel library via dependency declaration the module is imported with <module xmlns="urn:jboss:module:1.0" name="at.tfr.forge.plugin-faces-id-aware.dependencies" slot="..."> <resources> <resource-root path="metawidget-all-2.0.jar"/> <resource-root path="mvel2-2.1.RC1.jar"/> great so far, but then I get: ***ERROR*** [scaffold from-entity] loader constraint violation: loader (instance of org/jboss/modules/ModuleClassLoader) previously initiated loading for a different type with name "org/mvel2/templates/CompiledTemplate" So this is a dead end for me. There seems to be no other way to access the Mvel libraries than by using maven shade, but this seems to be overkill. Could you please rethink the visibility protection strategy or show an easy way to use common libraries forge already provides. Regards, Thomas _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/forge-dev

Hi Ryan, Lincoln > I ran into similar problems with my own plugin development. Including > MVEL as a Maven dependency in your pom.xml should resolve this issue. this is exactly what I have tried to do. This will really look ugly :/ I will write it as clear as possible: in pom.xml I added: <dependency> <groupId>org.mvel</groupId> <artifactId>mvel2</artifactId> <scope>compile</scope> </dependency> On forge install-plugin ~/blabla/ I get: ***SUCCESS*** Installed from [plugin-faces-idaware] successfully. Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11 Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/plugin-faces-id-aware.jar Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/module.xml Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11 Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/metawidget-all-2.0.jar Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/mvel2-2.1.Beta7.jar Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/module.xml So to me it is clear, that I was successful, integration of Mvel libraries is done. But when I invoke my plugin, I get _a LoaderConstraintViolation_!! [myidaware] myidaware $ set VERBOSE true [myidaware] myidaware $ scaffold from-entity at.tfr.test.model.* --scaffoldType idaware Use which scaffold provider? 1 - [idaware] 2 - [faces]* ? Choose an option by typing the number of the selection [*-default] [0] 1 ***ERROR*** [scaffold from-entity] loader constraint violation: loader (instance of org/jboss/modules/ModuleClassLoader) previously initiated loading for a different type with name "org/mvel2/templates/CompiledTemplate" org.jboss.forge.shell.exceptions.CommandExecutionException: loader constraint violation: loader (instance of org/jboss/modules/ModuleClassLoader) previously initiated loading for a different type with name "org/mvel2/templates/CompiledTemplate" Caused by: java.lang.LinkageError: loader constraint violation: loader (instance of org/jboss/modules/ModuleClassLoader) previously initiated loading for a different type with name "org/mvel2/templates/CompiledTemplate" So for me it is evident, that I brought my own Mvel jar, but the module loader will not let me use it! Regards, Thomas _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/forge-dev

Ryan, how did you get around this? Thomas, perhaps you could try including seam-render instead of MVEL? Make sure you use the same version that Forge Shell uses as a temporary workaround. ~Lincoln On Mon, Feb 13, 2012 at 5:33 PM, Thomas Frühbeck <fruehbeck(a)aon.at <mailto:fruehbeck@aon.at>> wrote: Hi Ryan, Lincoln > I ran into similar problems with my own plugin development. Including > MVEL as a Maven dependency in your pom.xml should resolve this issue. this is exactly what I have tried to do. This will really look ugly :/ I will write it as clear as possible: in pom.xml I added: <dependency> <groupId>org.mvel</groupId> <artifactId>mvel2</artifactId> <scope>compile</scope> </dependency> On forge install-plugin ~/blabla/ I get: ***SUCCESS*** Installed from [plugin-faces-idaware] successfully. Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11 Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/plugin-faces-id-aware.jar Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/module.xml Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11 Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/metawidget-all-2.0.jar Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/mvel2-2.1.Beta7.jar Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/module.xml So to me it is clear, that I was successful, integration of Mvel libraries is done. But when I invoke my plugin, I get _a LoaderConstraintViolation_!! [myidaware] myidaware $ set VERBOSE true [myidaware] myidaware $ scaffold from-entity at.tfr.test.model.* --scaffoldType idaware Use which scaffold provider? 1 - [idaware] 2 - [faces]* ? Choose an option by typing the number of the selection [*-default] [0] 1 ***ERROR*** [scaffold from-entity] loader constraint violation: loader (instance of org/jboss/modules/ModuleClassLoader) previously initiated loading for a different type with name "org/mvel2/templates/CompiledTemplate" org.jboss.forge.shell.exceptions.CommandExecutionException: loader constraint violation: loader (instance of org/jboss/modules/ModuleClassLoader) previously initiated loading for a different type with name "org/mvel2/templates/CompiledTemplate" Caused by: java.lang.LinkageError: loader constraint violation: loader (instance of org/jboss/modules/ModuleClassLoader) previously initiated loading for a different type with name "org/mvel2/templates/CompiledTemplate" So for me it is evident, that I brought my own Mvel jar, but the module loader will not let me use it! Regards, Thomas _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org <mailto:forge-dev@lists.jboss.org> https://lists.jboss.org/mailman/listinfo/forge-dev -- Lincoln Baxter, III http://ocpsoft.com http://scrumshark.com "Keep it Simple" _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/forge-dev

Lincoln, frankly, I'm stumped by this one. I never received a LoaderConstraintViolation or anything similar. My issue was with the seam-render not being added as a module to the plugin, since it was already included with the Forge core. However, that issue has since been resolved. Thomas, I'm not sure of the cause of your exception, as including seam-render and MVEL as dependencies solved the problem for me. If I understand your most recent e-mail correctly, your problem is solved if MVEL is manually added to module.xml? MVEL is not required for my ScaffoldProvider implementation, so maybe you are experiencing a similar problem? Sorry, Ryan On 02/13/2012 07:15 PM, Lincoln Baxter, III wrote: > Ryan, how did you get around this? > > Thomas, perhaps you could try including seam-render instead of MVEL? > Make sure you use the same version that Forge Shell uses as a > temporary workaround. > > ~Lincoln > > On Mon, Feb 13, 2012 at 5:33 PM, Thomas Frühbeck <fruehbeck(a)aon.at > <mailto:fruehbeck@aon.at>> wrote: > > Hi Ryan, Lincoln > > > I ran into similar problems with my own plugin development. > Including > > MVEL as a Maven dependency in your pom.xml should resolve this > issue. > > this is exactly what I have tried to do. This will really look > ugly :/ > I will write it as clear as possible: > > in pom.xml I added: > <dependency> > <groupId>org.mvel</groupId> > <artifactId>mvel2</artifactId> > <scope>compile</scope> > </dependency> > > On forge install-plugin ~/blabla/ I get: > ***SUCCESS*** Installed from [plugin-faces-idaware] successfully. > Wrote /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware > Wrote > /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11 > Wrote > /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/plugin-faces-id-aware.jar > Wrote > /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/module.xml > Wrote > /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies > Wrote > /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11 > Wrote > /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/metawidget-all-2.0.jar > Wrote > /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/mvel2-2.1.Beta7.jar > Wrote > /home/thomas/.forge/plugins/at/tfr/forge/plugin-faces-id-aware/dependencies/1.0.0-SNAPSHOT-6c38c8fd-45f4-4736-ad0a-467dc9154a11/module.xml > > So to me it is clear, that I was successful, integration of Mvel > libraries is done. > But when I invoke my plugin, I get _a LoaderConstraintViolation_!! > > [myidaware] myidaware $ set VERBOSE true > [myidaware] myidaware $ scaffold from-entity at.tfr.test.model.* > --scaffoldType idaware > Use which scaffold provider? > > 1 - [idaware] > 2 - [faces]* > > ? Choose an option by typing the number of the selection > [*-default] [0] 1 > ***ERROR*** [scaffold from-entity] loader constraint violation: > loader (instance of org/jboss/modules/ModuleClassLoader) > previously initiated loading for a different type with name > "org/mvel2/templates/CompiledTemplate" > org.jboss.forge.shell.exceptions.CommandExecutionException: > loader constraint violation: loader (instance of > org/jboss/modules/ModuleClassLoader) previously initiated loading > for a different type with name "org/mvel2/templates/CompiledTemplate" > > Caused by: java.lang.LinkageError: loader constraint violation: > loader (instance of org/jboss/modules/ModuleClassLoader) > previously initiated loading for a different type with name > "org/mvel2/templates/CompiledTemplate" > > > So for me it is evident, that I brought my own Mvel jar, but the > module loader will not let me use it! > > Regards, > Thomas > _______________________________________________ > forge-dev mailing list > forge-dev(a)lists.jboss.org <mailto:forge-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/forge-dev > > > > > -- > Lincoln Baxter, III > http://ocpsoft.com > http://scrumshark.com > "Keep it Simple" > > > _______________________________________________ > forge-dev mailing list > forge-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/forge-dev _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/forge-dev

Thank you for clarifying the issue, the build-repair-reload cycles have become tedious :-) > AFAICT, depending on seam-render and adjusting seam-render module definition to export the MVEL classes should take care of this ( If I understood correctly the proposed solution would be to change forge/modules/org/jboss/seam/render/main/module.xml to <module xmlns="urn:jboss:module:1.0" name="org.jboss.seam.render"> <resources> <resource-root path="seam-render-1.0.0.Alpha6.jar"/> </resources> <dependencies> <module name="javax.enterprise.api" /> <module name="org.jboss.forge" /> <module name="org.jboss.solder" /> <module name="org.mvel" export="true"/> <module name="javax.api" /> </dependencies> </module> I did that and it works! > if it's ever acceptable from a visibility perspective to depend on MVEL directly). Honestly, this sounds as if the old days of classloading problems come back :-/ My two cents: if there is a clean solution keeping the classes hidden from the plugins it's OK. But if it is difficult to do I would prefer to accept visibility of such libraries of common utility - we are talking of _plugins_, there should be some initimacy allowed, isn't it? Regards, Thomas _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/forge-dev

Am 15.02.2012 16:03, schrieb Lincoln Baxter, III: > I just had a thought. Are you sure that you really need the MVEL > library? Is it possible that you are directly referencing MVEL classes > when you should instead be referencing Seam Render classes? > > "TemplateCompiler" comes to mind. Lincoln you were right, the issue is in fact related to TemplateCompiler but not directly. I think I understand the problem now in detail and want to propose a solution. As my code was just taken from the FacesScaffold I did not further think about using it. As it turns out my plugin is not "as privileged?" as the FacesScaffold, so the problem became visible with my implementation. Situation: the FacesScaffold wants to calculate the textual indentation for the metawidgets that will be rendered inside of a template. To access the _compiled_ template, which seams to show the real indentation level, the following code was executed: private org.jboss.seam.render.template.CompiledTemplateResource createTemplate; ... String template = String.valueOf(this.createTemplate.getCompiledTemplate().getTemplate()); Now there is the hidden access to the MVEL libraries, because CompiledTemplateResource.getTemplate() will return a native org.mvel2.templates.CompiledTemplate. This is _very_ unfortunate, because there seems to be no easy way to e.g. override getTemplate() because it is already in the seam.render libs. On the other side it is quite important to provide consistent indentation for the generated sources - it simply looks ugly and unprof if code goes zigzag. My proposed solution is to provide a TemplateConverter in the scaffold.faces plugin. There the visibility of MVEL is provided and so does not conflict with forge's libs. On the other hand the FacesScaffold classes are visible to the other plugins. package org.jboss.forge.scaffold.faces; @Dependent public class TemplateConverter { public String convert(CompiledTemplateResource resource) { return new String(resource.getCompiledTemplate().getTemplate()); } } So now I can convert the compiled templates by : @Inject private TemplateConverter templateConverter; ... String template = templateConverter.convert(this.backingBeanTemplate); I would be very glad to provide the pull.request for this class. Any recommendations for the solution or the destination package for the converter? Thomas _______________________________________________ forge-dev mailing list forge-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/forge-dev