Author: hardy.ferentschik Date: 2009-02-20 12:10:42 -0500 (Fri, 20 Feb 2009) New Revision: 16014 Modified: validator/trunk/hibernate-validator/src/test/java/org/hibernate/validation/engine/ValidatorImplTest.java validator/trunk/hibernate-validator/src/test/java/org/hibernate/validation/engine/groups/GroupTest.java Log: Added testcase for HV-108 Modified: validator/trunk/hibernate-validator/src/test/java/org/hibernate/validation/engine/ValidatorImplTest.java =================================================================== --- validator/trunk/hibernate-validator/src/test/java/org/hibernate/validation/engine/ValidatorImplTest.java 2009-02-20 16:47:47 UTC (rev 16013) +++ validator/trunk/hibernate-validator/src/test/java/org/hibernate/validation/engine/ValidatorImplTest.java 2009-02-20 17:10:42 UTC (rev 16014) @@ -34,9 +34,12 @@ import org.hibernate.validation.eg.Customer; import org.hibernate.validation.eg.Engine; import org.hibernate.validation.eg.Order; +import org.hibernate.validation.eg.Person; import org.hibernate.validation.eg.UnconstraintEntity; +import org.hibernate.validation.engine.groups.User; import org.hibernate.validation.util.LoggerFactory; import org.hibernate.validation.util.TestUtil; +import static org.hibernate.validation.util.TestUtil.assertConstraintViolation; /** * Tests for the implementation of <code>Validator</code>. @@ -62,7 +65,6 @@ } } - @Test(expected = IllegalArgumentException.class) public void testNullParamterToValidatorImplConstructor() { TestUtil.getValidator().getConstraintsForClass( null ); @@ -232,7 +234,6 @@ } @Test - // @SpecAssertion( section = "2.2" ) public void testMultiValueConstraint() { Validator validator = TestUtil.getValidator(); @@ -251,7 +252,6 @@ } @Test - // @SpecAssertion( section = "3.5.1" ) public void testGraphValidation() { Validator validator = TestUtil.getValidator(); @@ -299,4 +299,37 @@ constraintViolations = validator.validateValue( Customer.class, "orderList[0].orderNumber", "1234" ); assertEquals( "Wrong number of constraints", 0, constraintViolations.size() ); } + + /** + * HV-108 + */ + @Test + public void testValidationIsPolymorphic() { + Validator validator = TestUtil.getValidator(); + + Customer customer = new Customer(); + customer.setFirstName( "Foo" ); + customer.setLastName( "Bar" ); + + Order order = new Order(); + customer.addOrder( order ); + + Person person = customer; + + Set<ConstraintViolation<Person>> constraintViolations = validator.validate( person ); + assertEquals( "Wrong number of constraints", 1, constraintViolations.size() ); + + assertConstraintViolation( + constraintViolations.iterator().next(), + "may not be null", + Customer.class, + null, + "orderList[0].orderNumber" + ); + + order.setOrderNumber( 123 ); + + constraintViolations = validator.validate( person ); + assertEquals( "Wrong number of constraints", 0, constraintViolations.size() ); + } } Modified: validator/trunk/hibernate-validator/src/test/java/org/hibernate/validation/engine/groups/GroupTest.java =================================================================== --- validator/trunk/hibernate-validator/src/test/java/org/hibernate/validation/engine/groups/GroupTest.java 2009-02-20 16:47:47 UTC (rev 16013) +++ validator/trunk/hibernate-validator/src/test/java/org/hibernate/validation/engine/groups/GroupTest.java 2009-02-20 17:10:42 UTC (rev 16014) @@ -257,6 +257,9 @@ ); } + /** + * HV-85 + */ @Test public void testGroupSequenceFollowedByGroup() { User user = new User();