Author: trustin Date: 2008-11-05 04:49:49 -0500 (Wed, 05 Nov 2008) New Revision: 4648 Modified: remoting3/trunk/api/src/main/java/org/jboss/remoting/spi/AbstractHandleableCloseable.java remoting3/trunk/api/src/test/java/org/jboss/remoting/spi/CloseableTestCase.java remoting3/trunk/core/src/main/java/org/jboss/remoting/core/RequestListenerExecutor.java remoting3/trunk/protocol/multiplex/src/main/java/org/jboss/remoting/protocol/multiplex/MultiplexProtocol.java remoting3/trunk/protocol/multiplex/src/test/java/org/jboss/remoting/protocol/multiplex/ConnectionTestCase.java remoting3/trunk/util/src/main/java/org/jboss/remoting/util/CollectionUtil.java remoting3/trunk/util/src/main/java/org/jboss/remoting/util/SynchronizedQueue.java remoting3/trunk/util/src/main/java/org/jboss/remoting/util/WeakHashSet.java Log: * Fixed warnings related with generic * Removed unused imports * Added a to-do marker for an unused method and a unused local variable Modified: remoting3/trunk/api/src/main/java/org/jboss/remoting/spi/AbstractHandleableCloseable.java =================================================================== --- remoting3/trunk/api/src/main/java/org/jboss/remoting/spi/AbstractHandleableCloseable.java 2008-11-05 09:40:43 UTC (rev 4647) +++ remoting3/trunk/api/src/main/java/org/jboss/remoting/spi/AbstractHandleableCloseable.java 2008-11-05 09:49:49 UTC (rev 4648) @@ -108,7 +108,6 @@ for (final CloseHandler<? super T> handler : closeHandlers) { try { executor.execute(new Runnable() { - @SuppressWarnings({ "unchecked" }) public void run() { SpiUtils.safeHandleClose(handler, (T) AbstractHandleableCloseable.this); } Modified: remoting3/trunk/api/src/test/java/org/jboss/remoting/spi/CloseableTestCase.java =================================================================== --- remoting3/trunk/api/src/test/java/org/jboss/remoting/spi/CloseableTestCase.java 2008-11-05 09:40:43 UTC (rev 4647) +++ remoting3/trunk/api/src/test/java/org/jboss/remoting/spi/CloseableTestCase.java 2008-11-05 09:49:49 UTC (rev 4648) @@ -187,7 +187,7 @@ }; final Handle<Object> rootHandle = closeable.getHandle(); try { - + // todo - something with that rootHandle } finally { IoUtils.safeClose(closeable); } Modified: remoting3/trunk/core/src/main/java/org/jboss/remoting/core/RequestListenerExecutor.java =================================================================== --- remoting3/trunk/core/src/main/java/org/jboss/remoting/core/RequestListenerExecutor.java 2008-11-05 09:40:43 UTC (rev 4647) +++ remoting3/trunk/core/src/main/java/org/jboss/remoting/core/RequestListenerExecutor.java 2008-11-05 09:49:49 UTC (rev 4648) @@ -33,9 +33,9 @@ private final Set<Task> tasks = CollectionUtil.synchronizedHashSet(); private final Executor executor; - private final RequestContextImpl requestContext; + private final RequestContextImpl<?> requestContext; - public RequestListenerExecutor(final Executor executor, final RequestContextImpl context) { + public RequestListenerExecutor(final Executor executor, final RequestContextImpl<?> context) { this.executor = executor; requestContext = context; } Modified: remoting3/trunk/protocol/multiplex/src/main/java/org/jboss/remoting/protocol/multiplex/MultiplexProtocol.java =================================================================== --- remoting3/trunk/protocol/multiplex/src/main/java/org/jboss/remoting/protocol/multiplex/MultiplexProtocol.java 2008-11-05 09:40:43 UTC (rev 4647) +++ remoting3/trunk/protocol/multiplex/src/main/java/org/jboss/remoting/protocol/multiplex/MultiplexProtocol.java 2008-11-05 09:49:49 UTC (rev 4648) @@ -75,6 +75,7 @@ return new AbstractConvertingIoFuture<SimpleCloseable, AllocatedMessageChannel>(futureChannel) { protected SimpleCloseable convert(final AllocatedMessageChannel channel) throws RemotingException { return new AbstractConnection(configuration.getExecutor()) { + // todo - this method is not called by anyone? public Handle<RequestHandlerSource> getServiceForId(final int id) throws IOException { return multiplexHandler.getRemoteService(id).getHandle(); } Modified: remoting3/trunk/protocol/multiplex/src/test/java/org/jboss/remoting/protocol/multiplex/ConnectionTestCase.java =================================================================== --- remoting3/trunk/protocol/multiplex/src/test/java/org/jboss/remoting/protocol/multiplex/ConnectionTestCase.java 2008-11-05 09:40:43 UTC (rev 4647) +++ remoting3/trunk/protocol/multiplex/src/test/java/org/jboss/remoting/protocol/multiplex/ConnectionTestCase.java 2008-11-05 09:49:49 UTC (rev 4648) @@ -48,7 +48,6 @@ import org.jboss.xnio.Xnio; import org.jboss.xnio.CloseableExecutor; import org.jboss.xnio.ChannelSource; -import org.jboss.xnio.IoHandler; import org.jboss.xnio.IoHandlerFactory; import org.jboss.xnio.IoFuture; import org.jboss.xnio.Buffers; Modified: remoting3/trunk/util/src/main/java/org/jboss/remoting/util/CollectionUtil.java =================================================================== --- remoting3/trunk/util/src/main/java/org/jboss/remoting/util/CollectionUtil.java 2008-11-05 09:40:43 UTC (rev 4647) +++ remoting3/trunk/util/src/main/java/org/jboss/remoting/util/CollectionUtil.java 2008-11-05 09:49:49 UTC (rev 4648) @@ -504,7 +504,7 @@ private static final Iterator<?> EMPTY_ITERATOR = new EmptyIterator(); - private static final class EmptyIterator implements Iterator { + private static final class EmptyIterator implements Iterator<Object> { public boolean hasNext() { return false; Modified: remoting3/trunk/util/src/main/java/org/jboss/remoting/util/SynchronizedQueue.java =================================================================== --- remoting3/trunk/util/src/main/java/org/jboss/remoting/util/SynchronizedQueue.java 2008-11-05 09:40:43 UTC (rev 4647) +++ remoting3/trunk/util/src/main/java/org/jboss/remoting/util/SynchronizedQueue.java 2008-11-05 09:49:49 UTC (rev 4648) @@ -83,7 +83,7 @@ } } - public <T> T[] toArray(final T[] a) { + public <U> U[] toArray(final U[] a) { synchronized(monitor) { //noinspection SuspiciousToArrayCall return delegate.toArray(a); Modified: remoting3/trunk/util/src/main/java/org/jboss/remoting/util/WeakHashSet.java =================================================================== --- remoting3/trunk/util/src/main/java/org/jboss/remoting/util/WeakHashSet.java 2008-11-05 09:40:43 UTC (rev 4647) +++ remoting3/trunk/util/src/main/java/org/jboss/remoting/util/WeakHashSet.java 2008-11-05 09:49:49 UTC (rev 4648) @@ -31,7 +31,7 @@ return map.keySet().toArray(); } - public <T> T[] toArray(final T[] a) { + public <U> U[] toArray(final U[] a) { return map.keySet().toArray(a); }