2:39 a.m.
Hi all,
As we are investigating usage of CSS themes in JBT and JBDS, I'd like to
integrate the Chrome-Theme (full EPL) plugins into the target-platform
so that we can leverage its runtime renderers (in the CSS, you can
specify some classes to render some elements such as tabs). We can't
fully use Themes generated by this cool plugin (which also contain a
Theme editor made with simple color pickers) without including this bundle.
So any objection on adding this to TP ?
Cheers
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
My blog <http://mickaelistria.wordpress.com> - My Tweets
<http://twitter.com/mickaelistria>
3:05 a.m.
link to what you want to include please ?
do we really need this plugin to do an eclipse style theme ?!
/max
On 05 Sep 2012, at 09:39, Mickael Istria <mistria(a)redhat.com> wrote:
Hi all,
As we are investigating usage of CSS themes in JBT and JBDS, I'd like to integrate
the Chrome-Theme (full EPL) plugins into the target-platform so that we can leverage its
runtime renderers (in the CSS, you can specify some classes to render some elements such
as tabs). We can't fully use Themes generated by this cool plugin (which also contain
a Theme editor made with simple color pickers) without including this bundle.
So any objection on adding this to TP ?
Cheers
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets
_______________________________________________
jbosstools-dev mailing list
jbosstools-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev
3:46 a.m.
On 09/05/2012 10:05 AM, Max Rydahl Andersen wrote:
link to what you want to include please ?
http://marketplace.eclipse.org/content/eclipse-4-chrome-theme
https://github.com/jeeeyul/eclipse-themes
do we really need this plugin to do an eclipse style theme ?!
Not really, but this plugin contains a few class (renderers) which
provide a more beautiful UI. I thought we'd better re-use them, but we
could re-write some if we want and rely only on our classes and CSS.
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
My blog <http://mickaelistria.wordpress.com> - My Tweets
<http://twitter.com/mickaelistria>
4:03 a.m.
On 09/05/2012 10:05 AM, Max Rydahl Andersen wrote:
> link to what you want to include please ?
http://marketplace.eclipse.org/content/eclipse-4-chrome-theme
https://github.com/jeeeyul/eclipse-themes
> do we really need this plugin to do an eclipse style theme ?!
Not really, but this plugin contains a few class (renderers) which provide a more
beautiful UI. I thought we'd better re-use them, but we could re-write some if we want
and rely only on our classes and CSS.
What few classes exactly ? link to github ?
for me it seriously feels like overkill to start depending on an external project for
something like css theming.
Would it make sense to fork these classes instead ?
/max
4:16 a.m.
On 09/05/2012 11:03 AM, Max Rydahl Andersen wrote:
What few classes exactly ? link to github ?
For the example
I've just checked, only this one seems necessary:
https://github.com/jeeeyul/eclipse-themes/blob/master/net.jeeeyul.eclipse...
for me it seriously feels like overkill to start depending on an
external project for something like css theming.
It also provides the nice Theme
editor in preferences. But I'm not sure
that's something we want to provide.
Would it make sense to fork these classes instead ?
Sure we
could.
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
My blog <http://mickaelistria.wordpress.com> - My Tweets
<http://twitter.com/mickaelistria>
5:46 a.m.
On 09/05/2012 11:03 AM, Max Rydahl Andersen wrote:
> What few classes exactly ? link to github ?
For the example I've just checked, only this one seems necessary:
https://github.com/jeeeyul/eclipse-themes/blob/master/net.jeeeyul.eclipse...
this class seem to depend heavily on HackedCTabRendering and themes* classes ?
> for me it seriously feels like overkill to start depending on an
external project for something like css theming.
It also provides the nice Theme editor in preferences. But I'm not sure that's
something we want to provide.
well, I don't find it like something we would want to maintain would we ?
> Would it make sense to fork these classes instead ?
Sure we could.
is this class something the css styles would reference as a "alternative
rendering" ?
What does this one actually fix ?
/max
7:02 a.m.
On 09/05/2012 12:46 PM, Max Rydahl Andersen wrote:
> On 09/05/2012 11:03 AM, Max Rydahl Andersen wrote:
>> What few classes exactly ? link to github ?
> For the example I've just checked, only this one seems necessary:
https://github.com/jeeeyul/eclipse-themes/blob/master/net.jeeeyul.eclipse...
this class seem to depend heavily on HackedCTabRendering and themes* classes ?
Yup.
>> for me it seriously feels like overkill to start depending on
an external project for something like css theming.
> It also provides the nice Theme editor in preferences. But I'm not sure
that's something we want to provide.
well, I don't find it like something we would want to maintain would we ?
Maintainance effort are probably very low. But we could also ask to
split the bundle into several bundles (common, renderers, editor) so we
could reuse only common and renderers.
>> Would it make sense to fork these classes instead ?
> Sure we could.
is this class something the css styles would reference as a "alternative
rendering" ?
What does this one actually fix ?
Yes it is.
I supports some additional color parameters compared to default one from
e4. So you can have different color for text, a gradient, and draw lines
more clearly.
--
Mickael Istria
Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
My blog <http://mickaelistria.wordpress.com> - My Tweets
<http://twitter.com/mickaelistria>
4515
days inactive
4515
days old
jbosstools-dev@lists.jboss.org
6 comments
2 participants
participants (2)
-
Max Rydahl Andersen -
Mickael Istria