[JBoss JIRA] (JBIDE-22443) Add to TP build a check that produced TP can be installed in target Eclipse version
by Mickael Istria (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22443?page=com.atlassian.jira.plugi... ]
Mickael Istria commented on JBIDE-22443:
----------------------------------------
[~maxandersen]: Ok, can you please suggest this in another Jira?
> Add to TP build a check that produced TP can be installed in target Eclipse version
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-22443
> URL: https://issues.jboss.org/browse/JBIDE-22443
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build, target-platform
> Reporter: Mickael Istria
>
> Recently, a change in TP (jetty 9.3.6) was introduced and everything built fine with it; until the very end of the build process: during install-tests.
> This issue would *probably* have occured if trying to install all content of the TP into the target Eclipse IDE (using install-grinder or p2director or whatever installation). So it would be good to have inside the TP build (as a "verify" plugin in pom.xml) something that would try to find whether target Eclipse version and our TP are already compatible.
> Technical notes:
> * Trying to install all IUs from the release train site + our TP seems easier to implement
> * We do not need to actually install the artifacts, just making the p2 request and getting whether the request managed to find a working plan without remediation seems enough.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 4 months
[JBoss JIRA] (JBIDE-22443) Add to TP build a check that produced TP can be installed in target Eclipse version
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22443?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen commented on JBIDE-22443:
---------------------------------------------
[~mickael_istria] why do you care which submodules to test ? they should all work should they not ?
My suggestion is simply:
1) do the TP build
2) checkout latest git submoduled repo (if using sticky workspaces the git update would only take a few seconds)
3) run a build that simply compiles and verify main and test code (takes max 15 minutes, and you already have the TP locally)
4) if any build failures the TP check is marked as failed.
> Add to TP build a check that produced TP can be installed in target Eclipse version
> -----------------------------------------------------------------------------------
>
> Key: JBIDE-22443
> URL: https://issues.jboss.org/browse/JBIDE-22443
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build, target-platform
> Reporter: Mickael Istria
>
> Recently, a change in TP (jetty 9.3.6) was introduced and everything built fine with it; until the very end of the build process: during install-tests.
> This issue would *probably* have occured if trying to install all content of the TP into the target Eclipse IDE (using install-grinder or p2director or whatever installation). So it would be good to have inside the TP build (as a "verify" plugin in pom.xml) something that would try to find whether target Eclipse version and our TP are already compatible.
> Technical notes:
> * Trying to install all IUs from the release train site + our TP seems easier to implement
> * We do not need to actually install the artifacts, just making the p2 request and getting whether the request managed to find a working plan without remediation seems enough.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 4 months
[JBoss JIRA] (JBIDE-19506) Connection wizard: should have unit tests
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19506?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-19506:
-------------------------------------
Original Estimate: 8 minutes
Remaining Estimate: 8 minutes
> Connection wizard: should have unit tests
> ------------------------------------------
>
> Key: JBIDE-19506
> URL: https://issues.jboss.org/browse/JBIDE-19506
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Alpha2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3, tests
> Fix For: 4.4.0.Alpha3
>
> Original Estimate: 8 minutes
> Remaining Estimate: 8 minutes
>
> In the new implementation of the connection wizard, that allows v2 and v3 connections (JBIDE-19096) we have rather complex behaviour that we should assert via unit tests.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 4 months
[JBoss JIRA] (JBIDE-19506) Connection wizard: should have unit tests
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-19506?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-19506:
-------------------------------------
Original Estimate: 2 days (was: 8 minutes)
Remaining Estimate: 2 days (was: 8 minutes)
> Connection wizard: should have unit tests
> ------------------------------------------
>
> Key: JBIDE-19506
> URL: https://issues.jboss.org/browse/JBIDE-19506
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.3.0.Alpha2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Labels: openshift_v3, tests
> Fix For: 4.4.0.Alpha3
>
> Original Estimate: 2 days
> Remaining Estimate: 2 days
>
> In the new implementation of the connection wizard, that allows v2 and v3 connections (JBIDE-19096) we have rather complex behaviour that we should assert via unit tests.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 4 months
[JBoss JIRA] (JBIDE-20756) Touch events for BrowserSim are not set properly
by Pavol Srna (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20756?page=com.atlassian.jira.plugi... ]
Pavol Srna closed JBIDE-20756.
------------------------------
Verified in JBT 4.4.0.Alpha1.
> Touch events for BrowserSim are not set properly
> ------------------------------------------------
>
> Key: JBIDE-20756
> URL: https://issues.jboss.org/browse/JBIDE-20756
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: browsersim
> Affects Versions: 4.3.0.CR1
> Environment: JBDS 9.0.0.CR1-v20150918-0257-B105 Fedora 22 KDE 64bit
> Reporter: Vlado Pakan
> Assignee: Konstantin Marmalyukov
> Fix For: 4.4.0.Alpha1
>
>
> 1. Create HTML page with this content:
> {code:html}
> <!DOCTYPE html>
> <html>
> <head>
> <title>sample</title>
> <script type="text/javascript">
> function window_onload() {
> document.getElementById('touchable').addEventListener('touchstart', function(ev) {
> alert('touchstart')}, false);
> document.getElementById('touchable').addEventListener('touchend', function(ev) {
> alert('touchend')}, false);
> document.getElementById('touchable').addEventListener('touchmove', function(ev) {
> alert('touchmove')}, false);
> }
> </script>
> </head>
> <body onload='window_onload();'>
> <div id='touchable'>This element is touchable.</div>
> </body>
> </html>
> {code}
> 2. Open this page in BrowserSim
> 3. Enable touch events for BrowserSim
> 4. Click somewhere within the page in BrowserSim
> ERROR:
> {noformat}
> !JavaScript WARN: Converting `ontouchstart` property to event listener.
> !JavaScript ERROR: TypeError: Unable to delete property. on line 118 for file:///.../jboss-touchevents/src/main/webapp/index.html
> !JavaScript WARN: Converting `ontouchend` property to event listener.
> !JavaScript ERROR: TypeError: Unable to delete property. on line 118 for file:///.../jboss-touchevents/src/main/webapp/index.html
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 4 months
[JBoss JIRA] (JBIDE-22454) Application Wizard: Build configuration wizard page has redundant environment variables table
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22454?page=com.atlassian.jira.plugi... ]
Marián Labuda edited comment on JBIDE-22454 at 5/31/16 4:39 AM:
----------------------------------------------------------------
It is understandable because of different wizard pages (Build vs Deployment config). Although I haven't noticed this difference, maybe my mistake. I like the tooltips. But could we also make it more explicit by label? *Build environment variables:* and *Deployment environment variables:*?
was (Author: mlabuda):
It is understandable because of different wizard pages (Build vs Deployment config). Although I haven't noticed this difference, maybe my mistake. I like the tooltips. But could we also make it more explicit by label? *Build environment variables:* and "Deployment environment variables:"?
> Application Wizard: Build configuration wizard page has redundant environment variables table
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-22454
> URL: https://issues.jboss.org/browse/JBIDE-22454
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.0.Alpha3
> Reporter: Marián Labuda
> Assignee: Jeff Cantrill
> Labels: application_wizard, openshift_v3
> Fix For: 4.4.x
>
> Attachments: screenshot-2.png, screenshot-3.png
>
>
> In New OpenShift Application wizard with selected builder image, there are 2 wizard pages containing same thing - table of environment variables passed to pod. First page is Build Configuration, where the table is empty. Second page is the immediately following one Deployment configuration and Scalability, where are environment variables even correctly prepared (obtained from image metadata). The first table, on Build configuration wizard page, should be removed, its redundant there.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 4 months
[JBoss JIRA] (JBIDE-22454) Application Wizard: Build configuration wizard page has redundant environment variables table
by Marián Labuda (JIRA)
[ https://issues.jboss.org/browse/JBIDE-22454?page=com.atlassian.jira.plugi... ]
Marián Labuda commented on JBIDE-22454:
---------------------------------------
It is understandable because of different wizard pages (Build vs Deployment config). Although I haven't noticed this difference, maybe my mistake. I like the tooltips. But could we also make it more explicit by label? *Build environment variables:* and "Deployment environment variables:"?
> Application Wizard: Build configuration wizard page has redundant environment variables table
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-22454
> URL: https://issues.jboss.org/browse/JBIDE-22454
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.4.0.Alpha3
> Reporter: Marián Labuda
> Assignee: Jeff Cantrill
> Labels: application_wizard, openshift_v3
> Fix For: 4.4.x
>
> Attachments: screenshot-2.png, screenshot-3.png
>
>
> In New OpenShift Application wizard with selected builder image, there are 2 wizard pages containing same thing - table of environment variables passed to pod. First page is Build Configuration, where the table is empty. Second page is the immediately following one Deployment configuration and Scalability, where are environment variables even correctly prepared (obtained from image metadata). The first table, on Build configuration wizard page, should be removed, its redundant there.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 4 months
[JBoss JIRA] (JBIDE-20674) Write automated tests to check consistency of Jetty between JBT & Eclipse
by Pavol Srna (JIRA)
[ https://issues.jboss.org/browse/JBIDE-20674?page=com.atlassian.jira.plugi... ]
Pavol Srna closed JBIDE-20674.
------------------------------
> Write automated tests to check consistency of Jetty between JBT & Eclipse
> -------------------------------------------------------------------------
>
> Key: JBIDE-20674
> URL: https://issues.jboss.org/browse/JBIDE-20674
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: browsersim, livereload, target-platform
> Reporter: Mickael Istria
> Assignee: Konstantin Marmalyukov
> Fix For: 4.4.0.Alpha1
>
>
> Since it appears Jetty is somehow a "weak" component (ie APIs are often broken and versions are not well managed), we often have to enforce a specific version of Jetty for our JBoss Tools bundles. However, it happens that the version used by JBoss Tools component isn't the same as the one shipped by some other Eclipse components.
> We need to make sure that enforcing a version of Jetty doesn't break those Eclipse components. The best way to achieve that is to write a test trying to validate the correct work of any Eclipse component we're aware it's using Jetty, as part of the same test plugin that validates the JBoss Tools components.
> The list of identified Eclipse component using Jetty so far:
> * Equinox (but I don't know how it uses Jetty, so neither how to make sure it's working well)
> * Eclipse Help (test coulod load the help and make sure it shows content and not a 302 or 500 HTTP error)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
9 years, 4 months