[JBoss JIRA] (JBIDE-24439) Block PRs for merge untill the Jenkins build is successful (protected branches)
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24439?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-24439:
------------------------------------------
I'm willing to change my mind and support protected branches for the following reasons:
* PR checks seem to be far more stable lately
* I am quite annoyed with [formatting flaws|JBIDE-24797] in our source but it seems far less critical than broken builds bcs of unvetted merges. Especially since there seems not to be a viable alternative if discipline is lacking.
Still, I believe that we should be careful growing the hurdles for successful merges given how thin our team is stretched.
> Block PRs for merge untill the Jenkins build is successful (protected branches)
> -------------------------------------------------------------------------------
>
> Key: JBIDE-24439
> URL: https://issues.jboss.org/browse/JBIDE-24439
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: build
> Affects Versions: 4.5.0.AM1
> Reporter: Nick Boldt
> Assignee: Jeff MAURY
> Fix For: LATER
>
>
> As discussed in this thread [1], we'd like to implement *Protected Branches* and
> *Required Status Checks* [2] for some jbosstools-* projects.
> [1] http://lists.jboss.org/pipermail/jbosstools-dev/2017-May/011948.html
> [2] https://help.github.com/articles/defining-the-mergeability-of-pull-requests/
> We will therefore need to document some requirements in jbosstools-devdoc about how to properly submit PRs when version-bumping is required:
> {quote}Make sure if your PR requires a version bump that the PR includes TWO commits. One for the change, and one for the version bump. That way the pair of commits can be built in the PR build and verify it works, AND when cherry picking the commit across branches, you can pick only the change and not the version-bump commit too.
> {quote}
> And we need to decide if we want to do what Fuse Tools does and require that PRs be reviewed before they can be merged, if we're ready to have that additional overhead on every PR.
> [~jeffmaury] as project lead can you state which project(s) you'd like to see changed in github, and which ones should be changed as such:
> * jbosstools-_____
> ** Protected Branch = master
> ** Required Status Check(s) = ....? (which checks do we want)
> ** PR reviews required = [true/false]
> From that list of projects / requirements, we can then create subtask JIRAs to track the workj & the changes.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 2 months
[JBoss JIRA] (JBIDE-24868) Server adapter: Switch off pod livenessProbe.periodSecond property and router timeout during debug session
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24868?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-24868 at 8/30/17 8:45 AM:
-------------------------------------------------------------------
* *Router timeout*:
according to the [docs|https://docs.openshift.org/latest/install_config/configuring_routing...] one can override the global timeout for a specific route by annotating it:
{code}
{
...
"kind": "Route",
"metadata": {
"annotations": {
"haproxy.router.openshift.io/timeout": "1h",
{code}
Using oc one has to do
{code}
# oc annotate route myroute --overwrite haproxy.router.openshift.io/timeout=2s
{code}
As a non-admin user I can process this change and it seems effective. This is a change that we could apply to the route when debugging, removing it once we stop the debugging.
* *Debug connection timeout*:
Doing a keepalive-ping within the debug connection as arquilian does seems not to be possible for us since we're not in control of the sockets that are used for this sake.
* *lifeness probe":
this seems like an edge case, not critical. I ack though that with a lifeness probe in place debugging gets annoying since the user would have to manually remove it before and add it back in after debugging.
[~jeffmaury], [~rhuss], [~aurelien.pupier] Thoughts?
was (Author: adietish):
* Router timeout:
according to the [docs|https://docs.openshift.org/latest/install_config/configuring_routing...] one can override the global timeout for a specific route by annotating it:
{code}
{
...
"kind": "Route",
"metadata": {
"annotations": {
"haproxy.router.openshift.io/timeout": "1h",
{code}
Using oc one has to do
{code}
# oc annotate route myroute --overwrite haproxy.router.openshift.io/timeout=2s
{code}
As a non-admin user I can process this change and it seems effective. This is a change that we could apply to the route when debugging, removing it once we stop the debugging.
* Debug connection timeout:
Doing a keepalive-ping within the debug connection as arquilian does seems not to be possible for us since we're not in control of the sockets that are used for this sake.
* lifenessprobe:
this seems like an edge case, not critical. I ack though that with a lifeness probe in place debugging gets annoying since the user would have to manually remove it before and add it back in after debugging.
[~jeffmaury], [~rhuss], [~aurelien.pupier] Thoughts?
> Server adapter: Switch off pod livenessProbe.periodSecond property and router timeout during debug session
> ----------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24868
> URL: https://issues.jboss.org/browse/JBIDE-24868
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.0.Final
> Reporter: Aurélien Pupier
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.5.x
>
>
> it will avoid to have "debug connections always killed after 30s staying in a breakpoint"
> see https://twitter.com/ro14nd/status/895886024387067904 for source of suggestion
> k8 documentations on the matter are here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-livene...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 2 months
[JBoss JIRA] (JBIDE-24868) Server adapter: Switch off pod livenessProbe.periodSecond property and router timeout during debug session
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24868?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-24868 at 8/30/17 8:45 AM:
-------------------------------------------------------------------
* *Router timeout*:
according to the [docs|https://docs.openshift.org/latest/install_config/configuring_routing...] one can override the global timeout for a specific route by annotating it:
{code}
{
...
"kind": "Route",
"metadata": {
"annotations": {
"haproxy.router.openshift.io/timeout": "1h",
{code}
Using oc one has to do
{code}
# oc annotate route myroute --overwrite haproxy.router.openshift.io/timeout=2s
{code}
As a non-admin user I can process this change and it seems effective. This is a change that we could apply to the route when debugging, removing it once we stop the debugging.
* *Debug connection timeout*:
Doing a keepalive-ping within the debug connection as arquilian does seems not to be possible for us since we're not in control of the sockets that are used for this sake.
* *lifeness probe*:
this seems like an edge case, not critical. I ack though that with a lifeness probe in place debugging gets annoying since the user would have to manually remove it before and add it back in after debugging.
[~jeffmaury], [~rhuss], [~aurelien.pupier] Thoughts?
was (Author: adietish):
* *Router timeout*:
according to the [docs|https://docs.openshift.org/latest/install_config/configuring_routing...] one can override the global timeout for a specific route by annotating it:
{code}
{
...
"kind": "Route",
"metadata": {
"annotations": {
"haproxy.router.openshift.io/timeout": "1h",
{code}
Using oc one has to do
{code}
# oc annotate route myroute --overwrite haproxy.router.openshift.io/timeout=2s
{code}
As a non-admin user I can process this change and it seems effective. This is a change that we could apply to the route when debugging, removing it once we stop the debugging.
* *Debug connection timeout*:
Doing a keepalive-ping within the debug connection as arquilian does seems not to be possible for us since we're not in control of the sockets that are used for this sake.
* *lifeness probe":
this seems like an edge case, not critical. I ack though that with a lifeness probe in place debugging gets annoying since the user would have to manually remove it before and add it back in after debugging.
[~jeffmaury], [~rhuss], [~aurelien.pupier] Thoughts?
> Server adapter: Switch off pod livenessProbe.periodSecond property and router timeout during debug session
> ----------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24868
> URL: https://issues.jboss.org/browse/JBIDE-24868
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.0.Final
> Reporter: Aurélien Pupier
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.5.x
>
>
> it will avoid to have "debug connections always killed after 30s staying in a breakpoint"
> see https://twitter.com/ro14nd/status/895886024387067904 for source of suggestion
> k8 documentations on the matter are here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-livene...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 2 months
[JBoss JIRA] (JBIDE-24868) Server adapter: Switch off pod livenessProbe.periodSecond property and router timeout during debug session
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24868?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-24868 at 8/30/17 8:45 AM:
-------------------------------------------------------------------
* *Router timeout*:
according to the [docs|https://docs.openshift.org/latest/install_config/configuring_routing...] one can override the global timeout for a specific route by annotating it:
{code}
{
...
"kind": "Route",
"metadata": {
"annotations": {
"haproxy.router.openshift.io/timeout": "1h",
{code}
Using oc one has to do
{code}
# oc annotate route myroute --overwrite haproxy.router.openshift.io/timeout=2s
{code}
As a non-admin user I can process this change and it seems effective. This is a change that we could apply to the route when debugging, removing it once we stop the debugging.
* *Debug connection timeout*:
Doing a keepalive-ping within the debug connection as arquilian does seems not to be possible for us since we're not in control of the sockets that are used for this sake.
* *lifeness probe*:
this seems like an edge case, not critical. I ack though that with a lifeness probe in place debugging gets annoying since the user would have to manually remove it before and add it back in after debugging.
[~jeffmaury], [~rhuss], [~aurelien.pupier] Thoughts?
was (Author: adietish):
* *Router timeout*:
according to the [docs|https://docs.openshift.org/latest/install_config/configuring_routing...] one can override the global timeout for a specific route by annotating it:
{code}
{
...
"kind": "Route",
"metadata": {
"annotations": {
"haproxy.router.openshift.io/timeout": "1h",
{code}
Using oc one has to do
{code}
# oc annotate route myroute --overwrite haproxy.router.openshift.io/timeout=2s
{code}
As a non-admin user I can process this change and it seems effective. This is a change that we could apply to the route when debugging, removing it once we stop the debugging.
* *Debug connection timeout*:
Doing a keepalive-ping within the debug connection as arquilian does seems not to be possible for us since we're not in control of the sockets that are used for this sake.
* *lifeness probe*:
this seems like an edge case, not critical. I ack though that with a lifeness probe in place debugging gets annoying since the user would have to manually remove it before and add it back in after debugging.
[~jeffmaury], [~rhuss], [~aurelien.pupier] Thoughts?
> Server adapter: Switch off pod livenessProbe.periodSecond property and router timeout during debug session
> ----------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24868
> URL: https://issues.jboss.org/browse/JBIDE-24868
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.0.Final
> Reporter: Aurélien Pupier
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.5.x
>
>
> it will avoid to have "debug connections always killed after 30s staying in a breakpoint"
> see https://twitter.com/ro14nd/status/895886024387067904 for source of suggestion
> k8 documentations on the matter are here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-livene...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 2 months
[JBoss JIRA] (JBIDE-24868) Server adapter: Switch off pod livenessProbe.periodSecond property and router timeout during debug session
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24868?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-24868 at 8/30/17 8:44 AM:
-------------------------------------------------------------------
* Router timeout:
according to the [docs|https://docs.openshift.org/latest/install_config/configuring_routing...] one can override the global timeout for a specific route by annotating it:
{code}
{
...
"kind": "Route",
"metadata": {
"annotations": {
"haproxy.router.openshift.io/timeout": "1h",
{code}
Using oc one has to do
{code}
# oc annotate route myroute --overwrite haproxy.router.openshift.io/timeout=2s
{code}
As a non-admin user I can process this change and it seems effective. This is a change that we could apply to the route when debugging, removing it once we stop the debugging.
* Debug connection timeout:
Doing a keepalive-ping within the debug connection as arquilian does seems not to be possible for us since we're not in control of the sockets that are used for this sake.
* lifenessprobe:
this seems like an edge case, not critical. I ack though that with a lifeness probe in place debugging gets annoying since the user would have to manually remove it before and add it back in after debugging.
[~jeffmaury], [~rhuss], [~aurelien.pupier] Thoughts?
was (Author: adietish):
according to the [docs|https://docs.openshift.org/latest/install_config/configuring_routing...] one can override the global timeout for a specific route by annotating it:
{code}
{
...
"kind": "Route",
"metadata": {
"annotations": {
"haproxy.router.openshift.io/timeout": "1h",
{code}
Using oc one has to do
{code}
# oc annotate route myroute --overwrite haproxy.router.openshift.io/timeout=2s
{code}
As a non-admin user I can process this change and it seems effective. This is a change that we could apply to the route when debugging, removing it once we stop the debugging.
[~jeffmaury], [~rhuss], [~aurelien.pupier] Thoughts?
> Server adapter: Switch off pod livenessProbe.periodSecond property and router timeout during debug session
> ----------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-24868
> URL: https://issues.jboss.org/browse/JBIDE-24868
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.5.0.Final
> Reporter: Aurélien Pupier
> Assignee: Andre Dietisheim
> Labels: openshift_v3, server_adapter
> Fix For: 4.5.x
>
>
> it will avoid to have "debug connections always killed after 30s staying in a breakpoint"
> see https://twitter.com/ro14nd/status/895886024387067904 for source of suggestion
> k8 documentations on the matter are here: https://kubernetes.io/docs/tasks/configure-pod-container/configure-livene...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 2 months
[JBoss JIRA] (JBIDE-24293) Lot of blank lines written to terminal when starting the CDK server
by Jeff MAURY (JIRA)
[ https://issues.jboss.org/browse/JBIDE-24293?page=com.atlassian.jira.plugi... ]
Jeff MAURY commented on JBIDE-24293:
------------------------------------
Yes it is related to HyperV. The output uses a lot of escapes, I even saw some part of my terminal being updated at the top of the window and blue colored !!!
Will make a small video.
Maybe reverting to using Eclipse terminal instead of console will be better ?
> Lot of blank lines written to terminal when starting the CDK server
> -------------------------------------------------------------------
>
> Key: JBIDE-24293
> URL: https://issues.jboss.org/browse/JBIDE-24293
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: cdk
> Affects Versions: 4.4.4.AM2
> Reporter: Aurélien Pupier
> Assignee: Rob Stryker
> Fix For: 4.5.x
>
> Attachments: terminalOutputWhenStartingCDK.txt
>
>
> Windows 10
> Version: 10.4.0.AM3
> Build id: AM3-v20170406-1058-B390
> Build date: 20170406-1058
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 2 months
[JBoss JIRA] (JBDS-4482) Create 'About' dialog to show most relevant information about installer
by Mohit Suman (JIRA)
[ https://issues.jboss.org/browse/JBDS-4482?page=com.atlassian.jira.plugin.... ]
Mohit Suman updated JBDS-4482:
------------------------------
Sprint: devex #137 September 2017
> Create 'About' dialog to show most relevant information about installer
> -----------------------------------------------------------------------
>
> Key: JBDS-4482
> URL: https://issues.jboss.org/browse/JBDS-4482
> Project: Red Hat JBoss Developer Studio (devstudio)
> Issue Type: Feature Request
> Components: platform-installer
> Affects Versions: 11.0.0.GA
> Reporter: Denis Golovin
> Assignee: Sudhir Verma
> Labels: New_and_noteworthy, ui
> Fix For: 11.x
>
>
> Dialog should contain:
> 1. Application logo, name and version
> 2. Link to documentation
> 3. Link to release notes
> 4. Link to documentation how to report issues
> Dialog can be requested trough context menu 'About' and should show modal dialog with content listed above
> Good Example is Atom editor About Page.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 2 months