[JBoss JIRA] (JBIDE-15853) plugins w/o test classes should not be set to packaging=eclipse-test-plugin
by Nick Boldt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15853?page=com.atlassian.jira.plugi... ]
Nick Boldt commented on JBIDE-15853:
------------------------------------
When I ran the above PR locally against master branch, it compiled and all tests ran fine. Of course that's partly because a lot of the test plugins aren't running tests due to swtbot.test.skip=true being set in JBT parent pom.
So, perhaps the root pom in this project should set swtbot.test.skip=false by default?
> plugins w/o test classes should not be set to packaging=eclipse-test-plugin
> ---------------------------------------------------------------------------
>
> Key: JBIDE-15853
> URL: https://issues.jboss.org/browse/JBIDE-15853
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: testing-tools
> Affects Versions: 4.1.1.Beta1
> Reporter: Nick Boldt
>
> 4 plugins in jbosstools-integration-tests have no test classes, but are set via their pom to packaging type eclipse-test-plugin instead of eclipse-plugin.
> As a result, these four plugins fail to run tests and the resulting build is red.
> {code:title=https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-integration-tests.aggregate_master/101/consoleFull}
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.archives.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.common.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.cdi.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.ws.reddeer: No tests found.
> {code}
> I propose that if these plugins are meant to be framework/API code, containing no actual JUnit tests to run, that their poms be changed as follows:
> {code}
> - <packaging>eclipse-test-plugin</packaging>
> + <packaging>eclipse-plugin</packaging>
> {code}
> And they be moved from
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/te...
> into
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/pl...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBDS-1591) JBDS Installer as a Native Mac OS X Application
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBDS-1591?page=com.atlassian.jira.plugin.... ]
Max Rydahl Andersen closed JBDS-1591.
-------------------------------------
Resolution: Won't Fix
It would be nice to get it but not on any plans so lets drop it until we actually need it/have a solution for it.
> JBDS Installer as a Native Mac OS X Application
> -----------------------------------------------
>
> Key: JBDS-1591
> URL: https://issues.jboss.org/browse/JBDS-1591
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: installer
> Affects Versions: 4.0.0.GA
> Environment: Mac OS X
> Reporter: Martin Malina
> Assignee: Denis Golovin
> Priority: Minor
> Fix For: 8.0.x
>
>
> This is an enhancement for your consideration. Feel free to reject it.
> Currently, all the installers of JBDS for Mac OS X and other platforms are just plain jar files which you launch either with "java -jar" or by double clicking if the OS supports this.
> When you launch the jar, the icon that appears in the Dock is just a default app icon. It would be possible to bundle the installer on the Mac so that it would be a native Mac OS X app called e.g. "JBDS 4 Installer.app".
> The instructions on how to achieve this are described here:
> http://java.sun.com/developer/technicalArticles/JavaLP/JavaToMac3/
> I just tried it and it's easy.
> I think it would be easy to implement this in the building process. The benefit would be an installer with our custom icon in the Dock and also on the installer itself - i.e. in Finder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-15744) openshift-java-client: add support for List<IEnvironmentVariable> and refactor methods that reference "List" in their names, however are operating on "Map<String, IEnvironmentVariable>", to reference "Map"
by Martes Wigglesworth (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15744?page=com.atlassian.jira.plugi... ]
Martes Wigglesworth commented on JBIDE-15744:
---------------------------------------------
Greetings Max.
I am not sure in what context your comment is meant to be referenced.
I haven't changed any of the workflow, other than introducing some changes to the tests, and interfaces to reference a List<IEnvironmentVariable>.
The only place that you will get the Map<String,IEnvironmentVariable> is to use a run-time implementation of the IApplication interface, so even if we won't have an application all the time, such as in the period associated with the "New Application" creation wizard, it is assumed that a call to load environment variables is made.
In the case for a new application use case, there are no variables to edit, and all environment variable instances will be added in, from the UI.
This List<IEnvironmentVariable> change is really only useful to an application that already has been created, and the wizard calls get/load...... to return the List or Map.
We don't use a Map for anything other than assuming that the map will guarantee uniqueness, which is checked by the validators for the inputs to the UI. So since we never actually need to check for uniqueness when pulling directly from the back-end, since it is assumed to be the corrected list of variables already, I have introduced a List, which doesn't require the users of a call to getEnvironmentVariables() to have to do extra work simply to get out the list.
> openshift-java-client: add support for List<IEnvironmentVariable> and refactor methods that reference "List" in their names, however are operating on "Map<String,IEnvironmentVariable>", to reference "Map"
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15744
> URL: https://issues.jboss.org/browse/JBIDE-15744
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.1.x, 4.2.0.Alpha1
> Reporter: Martes Wigglesworth
> Assignee: Andre Dietisheim
> Fix For: 4.1.1.CR1
>
>
> This enhancement to the interface will remove the requirement that users of the interface implementation instances to do extra processing to pull the list of variables from the provided immutable Map<String,IEnvirontmentVariable> instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-12646) web.xml servlet-name validation is not case-sensitive
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12646?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen commented on JBIDE-12646:
---------------------------------------------
remember: this would depend on the file system used for osx.
Should be the case insensitive to catch the bug here.
> web.xml servlet-name validation is not case-sensitive
> -----------------------------------------------------
>
> Key: JBIDE-12646
> URL: https://issues.jboss.org/browse/JBIDE-12646
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: jsp/jsf/xml/html source editing
> Affects Versions: 4.0.0.Alpha1
> Reporter: Xavier Coulon
> Assignee: Viacheslav Kabanovich
> Fix For: LATER
>
> Attachments: JBIDE-12646 - Wi-Fi.m4v, ServletNameValidation.png
>
>
> [Using the HTML5 sample project generated from Central]
> I'm adding a servlet declaration in the web.xml file but the web.xml editor does not report a warning when the servlet name case is wrong:
> {code}
> <servlet-mapping>
> <servlet-name>org.jboss.tools.example.html5.rest.JaxrsActivator</servlet-name>
> <url-pattern>/hello/*</url-pattern>
> </servlet-mapping>
> {code}
> In the example above, the class name should be JaxRsActivator, not JaxrsActivator.
> On the other hand, it properly reports a warning when a letter is missing in the classname.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-15375) File permissions for OpenShift actions hooks are sometimes incorrect when cloning repo
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15375?page=com.atlassian.jira.plugi... ]
Andre Dietisheim resolved JBIDE-15375.
--------------------------------------
Resolution: Cannot Reproduce Bug
resolving as CANNOT_REPRODUCE since no update quite some time. Feel free to reopen if this is still an issue.
> File permissions for OpenShift actions hooks are sometimes incorrect when cloning repo
> --------------------------------------------------------------------------------------
>
> Key: JBIDE-15375
> URL: https://issues.jboss.org/browse/JBIDE-15375
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.0.Final
> Environment: Windows, cygwin
> Reporter: Andy Goldstein
> Assignee: Andre Dietisheim
> Fix For: 4.1.1.CR1, 4.2.0.Alpha1
>
> Attachments: resource-properties.png, set-x-permissions.png
>
>
> (filing on behalf of another user who is having login issues)
> When I clone a git repo (git@...:user/myapp.git) using the Eclipse plugins, the file permissions for my action_hooks are set as:
> {code}
> /cygdrive/c/Users/user/git/myapp/.openshift/action_hooks
> $ ls -l
> total 45
> -rwx------+ 1 Administrators Domain Users 265 Aug 22 14:38 build
> -rwx------+ 1 Administrators Domain Users 264 Aug 22 14:38 deploy
> -rwx------+ 1 Administrators Domain Users 186 Aug 22 14:38 post_deploy
> -rwx------+ 1 Administrators Domain Users 645 Aug 22 14:38 post_start_jbossas-7
> -rwx------+ 1 Administrators Domain Users 645 Aug 22 14:38 post_stop_jbossas-7
> -rwx------+ 1 Administrators Domain Users 640 Aug 22 14:38 pre_build
> -rwx------+ 1 Administrators Domain Users 272 Aug 22 14:38 pre_build_jbossas-7
> -rwx------+ 1 Administrators Domain Users 645 Aug 22 14:38 pre_start_jbossas-7
> -rwx------+ 1 Administrators Domain Users 645 Aug 22 14:38 pre_stop_jbossas-7
> {code}
> When they are pushed to OpenShift, they can't be executed.
> {code}
> /var/lib/openshift/5216951d76c3b22b77000362/app-root/runtime/repo/.openshift/action_hooks/post_stop_jbossjsw-1.0: Permission denied
> remote: Failed to stop jbossjsw-1.0
> To
> ssh://5216951d76c3b22b77000362@ppon-tsujarit.qa02.shift.paypal.com/~/git/pp
> on.git/
> ! [remote rejected] master -> master (pre-receive hook declined)
> error: failed to push some refs to
> {code}
> On a different machine, when I clone using Eclipse, the file permission are set as expected:
> {code}
> -rwxr-xr-x 1 Administrators Domain Users 270 Aug 22 11:25 build
> -rwxr-xr-x 1 Administrators Domain Users 271 Aug 22 11:25 deploy
> -rwxr-xr-x 1 Administrators Domain Users 189 Aug 22 11:25 post_deploy
> -rwxr-xr-x 1 Administrators Domain Users 659 Aug 22 11:25 post_start_jbossas-7
> -rwxr-xr-x 1 Administrators Domain Users 659 Aug 22 11:25 post_stop_jbossas-7
> -rwxr-xr-x 1 Administrators Domain Users 650 Aug 22 11:25 pre_build
> -rwxr-xr-x 1 Administrators Domain Users 277 Aug 22 11:25 pre_build_jbossas-7
> -rwxr-xr-x 1 Administrators Domain Users 659 Aug 22 11:25 pre_start_jbossas-7
> -rwxr-xr-x 1 Administrators Domain Users 659 Aug 22 11:25 pre_stop_jbossas-7
> {code}
> Is it possible to set the file perms to +x on the action_hooks?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBDS-2729) Add mobile web quickstarts for JBoss Central
by Fred Bricon (JIRA)
[ https://issues.jboss.org/browse/JBDS-2729?page=com.atlassian.jira.plugin.... ]
Fred Bricon commented on JBDS-2729:
-----------------------------------
the html5-mobile quickstart already exist, but I guess I can update it to the latest version.
So the only new mobile quickstart will be the backbone one.
However, since it depends on wfk, it won't build OOTB if the wfk maven repo isn't accessible. I created JBIDE-15860 to add a warning (similar to archetype-based wizard) if wfk dependencies can't resolve
> Add mobile web quickstarts for JBoss Central
> --------------------------------------------
>
> Key: JBDS-2729
> URL: https://issues.jboss.org/browse/JBDS-2729
> Project: Developer Studio (JBoss Developer Studio)
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: aerogear-hybrid, central, requirements
> Reporter: Burr Sutter
> Assignee: Fred Bricon
> Fix For: 7.1.0.GA
>
>
> The mobile web quickstarts being proced on WFK2 side should be included in JBoss Central
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months