[JBoss JIRA] (JBIDE-15858) Application wizard: server that does not support env variables causes error when creating app
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15858?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-15858:
-------------------------------------
Steps to Reproduce:
# ASSERT: make sure you have an account on a OS server that does *NOT* support env variables (ex. console.itos.redhat.com)
# ASSERT: make sure you have an existing application on this server
# EXEC: in OpenShift Explorer: pick "Edit Environment Variables..." in the context menu of your application
Result:
You get an error:
!environment_variables.png!
In the Eclipse log you'll spot the following:
{code}
com.openshift.client.OpenShiftRequestException: Could not find link "LIST_ENVIRONMENT_VARIABLES" in resource "ApplicationResource"
at com.openshift.internal.client.AbstractOpenShiftResource.getLink(AbstractOpenShiftResource.java:123)
at com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:142)
at com.openshift.internal.client.ApplicationResource.loadEnvironmentVariables(ApplicationResource.java:622)
at com.openshift.internal.client.ApplicationResource.getOrLoadEnvironmentVariables(ApplicationResource.java:616)
at com.openshift.internal.client.ApplicationResource.getEnvironmentVariables(ApplicationResource.java:611)
at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.initVariablesFor(EnvironmentVariablesWizardModel.java:81)
at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.initVariables(EnvironmentVariablesWizardModel.java:64)
at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.loadEnvironmentVariables(EnvironmentVariablesWizardModel.java:58)
at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardPage$LoadEnvironmentVariablesJob.doRun(EnvironmentVariablesWizardPage.java:240)
at org.jboss.tools.openshift.express.internal.ui.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:36)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
{code}
Expected result:
You should not be able to edit environment variables if the server is not offering this capability.
was:
# ASSERT: make sure you have an account on a OS server that does *NOT* support env variables (ex. console.itos.redhat.com)
# ASSERT: make sure you have an existing application on this server
# EXEC: in OpenShift Explorer: pick "Edit Environment Variables..." in the context menu of your application
Result:
You get an error:
!environment_variables.png!
In the Eclipse log you'll spot the following:
{code}
com.openshift.client.OpenShiftRequestException: Could not find link "LIST_ENVIRONMENT_VARIABLES" in resource "ApplicationResource"
at com.openshift.internal.client.AbstractOpenShiftResource.getLink(AbstractOpenShiftResource.java:123)
at com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:142)
at com.openshift.internal.client.ApplicationResource.loadEnvironmentVariables(ApplicationResource.java:622)
at com.openshift.internal.client.ApplicationResource.getOrLoadEnvironmentVariables(ApplicationResource.java:616)
at com.openshift.internal.client.ApplicationResource.getEnvironmentVariables(ApplicationResource.java:611)
at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.initVariablesFor(EnvironmentVariablesWizardModel.java:81)
at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.initVariables(EnvironmentVariablesWizardModel.java:64)
at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.loadEnvironmentVariables(EnvironmentVariablesWizardModel.java:58)
at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardPage$LoadEnvironmentVariablesJob.doRun(EnvironmentVariablesWizardPage.java:240)
at org.jboss.tools.openshift.express.internal.ui.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:36)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
{code}
> Application wizard: server that does not support env variables causes error when creating app
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-15858
> URL: https://issues.jboss.org/browse/JBIDE-15858
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.1.Beta1
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Fix For: 4.1.1.Beta1, 4.2.0.Alpha1
>
> Attachments: environment_variables.png
>
>
> If OpenShift server does not support add/remove/modify environment variables it cause error. There should be some user-friendly dialog. See attached image. This is captured from opening shell with add/modify/remove environment variables (in context menu of application choose "Edit Environment Variables..."
> Another one is show after attempt to add variable.
> Other "Processing environment variables..."
> Probably good solution should show dialog "Server _name_ does not support modifying environment variables" and don't open shell with table of environment variables (my opinion).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-15839) Exception while saving Provider in JAX-RS application
by Xavier Coulon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15839?page=com.atlassian.jira.plugi... ]
Xavier Coulon reassigned JBIDE-15839:
-------------------------------------
Assignee: Max Rydahl Andersen (was: Xavier Coulon)
Please review the PR
> Exception while saving Provider in JAX-RS application
> -----------------------------------------------------
>
> Key: JBIDE-15839
> URL: https://issues.jboss.org/browse/JBIDE-15839
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: webservices
> Affects Versions: 4.1.1.Beta1
> Reporter: Xavier Coulon
> Assignee: Max Rydahl Andersen
> Fix For: 4.1.1.CR1
>
>
> Following exception was logged while working on a sample application, in which a Server Filter was edited and saved (error occurred while saving)
> {code}
> org.jboss.tools.common.validation.JBTValidationException
> at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:101)
> at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
> Caused by: java.lang.NullPointerException
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.addMarker(JaxrsMetamodelValidator.java:433)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsProviderValidatorDelegate.validateAtLeastOneImplementation(JaxrsProviderValidatorDelegate.java:161)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsProviderValidatorDelegate.internalValidate(JaxrsProviderValidatorDelegate.java:72)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsProviderValidatorDelegate.internalValidate(JaxrsProviderValidatorDelegate.java:1)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.AbstractJaxrsElementValidatorDelegate.validate(AbstractJaxrsElementValidatorDelegate.java:33)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.validate(JaxrsMetamodelValidator.java:315)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.validateAll(JaxrsMetamodelValidator.java:282)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.validate(JaxrsMetamodelValidator.java:157)
> at org.jboss.tools.common.validation.ValidatorManager.validate(ValidatorManager.java:117)
> at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:81)
> ... 2 more
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-15839) Exception while saving Provider in JAX-RS application
by Xavier Coulon (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15839?page=com.atlassian.jira.plugi... ]
Xavier Coulon commented on JBIDE-15839:
---------------------------------------
Fixed the problem which occurred only when the problem severity as set to
'ignore' level. In that particular case, no IMarker would be created, thus
returning a null reference, which lead to NPE.
So, to reproduce the bug, the following code example should work:
{code}
@Provider
public class SimpleMessageBodyReader {
@Override
public boolean isReadable(Class<?> type, Type genericType,
Annotation[] annotations, MediaType mediaType) {
// TODO Auto-generated method stub
return false;
}
@Override
public String readFrom(Class<String> type, Type genericType,
Annotation[] annotations, MediaType mediaType,
MultivaluedMap<String, String> httpHeaders, InputStream entityStream)
throws IOException, WebApplicationException {
// TODO Auto-generated method stub
return null;
}
}
{code}
then, set the JAX-RS Validation problem level to "Ignore" for the "Missing Provider Implementation" type of problem (in the JAX-RS Providers sub-category), and finally, validate the project (or do a clean/build).
> Exception while saving Provider in JAX-RS application
> -----------------------------------------------------
>
> Key: JBIDE-15839
> URL: https://issues.jboss.org/browse/JBIDE-15839
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: webservices
> Affects Versions: 4.1.1.Beta1
> Reporter: Xavier Coulon
> Assignee: Xavier Coulon
> Fix For: 4.1.1.CR1
>
>
> Following exception was logged while working on a sample application, in which a Server Filter was edited and saved (error occurred while saving)
> {code}
> org.jboss.tools.common.validation.JBTValidationException
> at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:101)
> at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
> Caused by: java.lang.NullPointerException
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.addMarker(JaxrsMetamodelValidator.java:433)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsProviderValidatorDelegate.validateAtLeastOneImplementation(JaxrsProviderValidatorDelegate.java:161)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsProviderValidatorDelegate.internalValidate(JaxrsProviderValidatorDelegate.java:72)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsProviderValidatorDelegate.internalValidate(JaxrsProviderValidatorDelegate.java:1)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.AbstractJaxrsElementValidatorDelegate.validate(AbstractJaxrsElementValidatorDelegate.java:33)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.validate(JaxrsMetamodelValidator.java:315)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.validateAll(JaxrsMetamodelValidator.java:282)
> at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.validate(JaxrsMetamodelValidator.java:157)
> at org.jboss.tools.common.validation.ValidatorManager.validate(ValidatorManager.java:117)
> at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:81)
> ... 2 more
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-15858) Application wizard: server that does not support env variables causes error when creating app
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15858?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-15858:
-------------------------------------
Summary: Application wizard: server that does not support env variables causes error when creating app (was: Edit environment variables: trying to edit env variables on server that does not support it causes error when creating app)
Steps to Reproduce:
# ASSERT: make sure you have an account on a OS server that does *NOT* support env variables (ex. console.itos.redhat.com)
# ASSERT: make sure you have an existing application on this server
# EXEC: in OpenShift Explorer: pick "Edit Environment Variables..." in the context menu of your application
Result:
You get an error:
!environment_variables.png!
In the Eclipse log you'll spot the following:
{code}
com.openshift.client.OpenShiftRequestException: Could not find link "LIST_ENVIRONMENT_VARIABLES" in resource "ApplicationResource"
at com.openshift.internal.client.AbstractOpenShiftResource.getLink(AbstractOpenShiftResource.java:123)
at com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:142)
at com.openshift.internal.client.ApplicationResource.loadEnvironmentVariables(ApplicationResource.java:622)
at com.openshift.internal.client.ApplicationResource.getOrLoadEnvironmentVariables(ApplicationResource.java:616)
at com.openshift.internal.client.ApplicationResource.getEnvironmentVariables(ApplicationResource.java:611)
at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.initVariablesFor(EnvironmentVariablesWizardModel.java:81)
at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.initVariables(EnvironmentVariablesWizardModel.java:64)
at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.loadEnvironmentVariables(EnvironmentVariablesWizardModel.java:58)
at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardPage$LoadEnvironmentVariablesJob.doRun(EnvironmentVariablesWizardPage.java:240)
at org.jboss.tools.openshift.express.internal.ui.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:36)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
{code}
> Application wizard: server that does not support env variables causes error when creating app
> ---------------------------------------------------------------------------------------------
>
> Key: JBIDE-15858
> URL: https://issues.jboss.org/browse/JBIDE-15858
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.1.Beta1
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Fix For: 4.1.1.Beta1, 4.2.0.Alpha1
>
> Attachments: environment_variables.png
>
>
> If OpenShift server does not support add/remove/modify environment variables it cause error. There should be some user-friendly dialog. See attached image. This is captured from opening shell with add/modify/remove environment variables (in context menu of application choose "Edit Environment Variables..."
> Another one is show after attempt to add variable.
> Other "Processing environment variables..."
> Probably good solution should show dialog "Server _name_ does not support modifying environment variables" and don't open shell with table of environment variables (my opinion).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-15860) Show a warning when enterprise maven repo is missing for enterprise quickstarts
by Fred Bricon (JIRA)
Fred Bricon created JBIDE-15860:
-----------------------------------
Summary: Show a warning when enterprise maven repo is missing for enterprise quickstarts
Key: JBIDE-15860
URL: https://issues.jboss.org/browse/JBIDE-15860
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: project-examples
Affects Versions: 4.1.1.CR1
Reporter: Fred Bricon
Assignee: Fred Bricon
Fix For: 4.1.1.CR1
Since the newest quickstarts now require the maven eap and/or wfk repos, generated projects won't build OOTB if these repos are not defined in the user's settings.xml.
Maven archetype based wizards show a warning is essential dependencies can't be resolved. We need to add the same thing for zipped quickstarts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-15858) Edit environment variables: trying to edit env variables on server that does not support it causes error when creating app
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15858?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-15858:
-------------------------------------
Summary: Edit environment variables: trying to edit env variables on server that does not support it causes error when creating app (was: Application wizard: server that does not support env variables causes error when creating app)
> Edit environment variables: trying to edit env variables on server that does not support it causes error when creating app
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15858
> URL: https://issues.jboss.org/browse/JBIDE-15858
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.1.Beta1
> Reporter: Marián Labuda
> Assignee: Andre Dietisheim
> Fix For: 4.1.1.Beta1, 4.2.0.Alpha1
>
> Attachments: environment_variables.png
>
>
> If OpenShift server does not support add/remove/modify environment variables it cause error. There should be some user-friendly dialog. See attached image. This is captured from opening shell with add/modify/remove environment variables (in context menu of application choose "Edit Environment Variables..."
> Another one is show after attempt to add variable.
> Other "Processing environment variables..."
> Probably good solution should show dialog "Server _name_ does not support modifying environment variables" and don't open shell with table of environment variables (my opinion).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months
[JBoss JIRA] (JBIDE-15830) openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
by Brenton Leanhardt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15830?page=com.atlassian.jira.plugi... ]
Brenton Leanhardt commented on JBIDE-15830:
-------------------------------------------
I definitely think the jenkins-plugin should be setting the user-agent instead of relying on the default behavior of the openshift-java-client. For what it's worth, when I performed a packet capture of the jenkins-plugin compiled with 2.4.0-SNAPSHOT or later of openshift-java-client the user-agent was set to "Java/1.7.0_45".
I see in https://github.com/openshift/jenkins-cloud-plugin/blob/master/src/main/ja... that the OpenShiftConnectionFactory is being used. I'm guessing that's probably where the user-agent should be passed in.
As for the openshift jenkins plugin itself, there is a story upstream to deal with a large chunk of technical debt that includes creating tests that actually work and do something useful.
> openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15830
> URL: https://issues.jboss.org/browse/JBIDE-15830
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Reporter: Brenton Leanhardt
> Assignee: Andre Dietisheim
> Labels: openshift-java-client
> Fix For: 4.1.1.CR1, 4.2.0.Alpha1
>
>
> OpenShift Enterprise and Origin both ship an authentication plugin that allows parts of authentication to be handled by Apache and other parts to be delegated to the openshift-origin-controller codebase. I've found that all versions of openshift-java-client after 2.3.0.Final change a (poorly documented) requirement for the OpenShift remote-user plugin.
> In order for a request to bypass the Apache authentication and passthrough to the OpenShift Broker the user-agent header is inspected. If the user-agent is 'OpenShift' then the Broker will require an encrypted authentication token. Today this is used by the jenkins cartridge but I believe it's also still used for scaling.
> You can see this for details:
> https://github.com/openshift/origin-server/blob/master/documentation/arch...
> In 2.3.0.Final of the openshift-java-client the user-agent was 'OpenShift' however all versions after this set the user-agent to the java version (eg, User-Agent: Java/1.7.0_45).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 5 months