[JBoss JIRA] (JBIDE-16105) openshift-java-client: offer access to express.conf/timeout
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-16105?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-16105:
-------------------------------------
Labels: help_wanted openshift-java-client (was: )
> openshift-java-client: offer access to express.conf/timeout
> -----------------------------------------------------------
>
> Key: JBIDE-16105
> URL: https://issues.jboss.org/browse/JBIDE-16105
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.1.1.CR1
> Reporter: Andre Dietisheim
> Labels: help_wanted, openshift-java-client
> Fix For: 4.2.x
>
>
> express.conf now offers a setting for timeouts:
> {code}
> # The default timeout for network operations
> #timeout=<integer>
> {code}
> we currently offer direct access via identical key. Since *timeout* is a very common name we should most likely offer also prefixed access (ex. openshift.timeout).
> This should replace or be aliased by the system property we already use:
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 4 months
[JBoss JIRA] (JBIDE-16112) openshift-java-client: remove hard coded default timeout, dont set HttpUrlConnection timeout
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-16112?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-16112:
-------------------------------------
Labels: openshift-java-client (was: )
> openshift-java-client: remove hard coded default timeout, dont set HttpUrlConnection timeout
> --------------------------------------------------------------------------------------------
>
> Key: JBIDE-16112
> URL: https://issues.jboss.org/browse/JBIDE-16112
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.1.1.CR1
> Reporter: Andre Dietisheim
> Labels: openshift-java-client
> Fix For: 4.2.x
>
>
> The current code to set timeouts in openshift-java-client is:
> {code}
> private int getTimeout(int timeout, int openShiftTimeout, int systemPropertyTimeout, int defaultTimeout) {
> if (timeout == NO_TIMEOUT) {
> timeout = openShiftTimeout;
> if (timeout == NO_TIMEOUT) {
> timeout = systemPropertyTimeout;
> if (timeout == NO_TIMEOUT) {
> timeout = defaultTimeout;
> }
> }
> }
> return timeout;
> }
> {code}
> calling it looks like this:
> {code}
> private void setReadTimeout(int timeout, URLConnection connection) {
> connection.setReadTimeout(
> getTimeout(
> timeout,
> getSystemPropertyInteger(SYSPROP_OPENSHIFT_READ_TIMEOUT),
> getSystemPropertyInteger(SYSPROP_DEFAULT_READ_TIMEOUT),
> DEFAULT_READ_TIMEOUT));
> }
> {code}
> DEFAULT_READ_TIMEOUT should get eliminated, we should use the SYSPROP_OPENSHIFT_READ_TIMEOUT as this. Furthermore there's no need to set the SYSPROP_DEFAULT_READ_TIMEOUT.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 4 months
[JBoss JIRA] (JBIDE-16112) openshift-java-client: remove hard coded default timeout, dont set HttpUrlConnection timeout
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-16112?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-16112:
-------------------------------------
Labels: help_wanted openshift-java-client (was: openshift-java-client)
> openshift-java-client: remove hard coded default timeout, dont set HttpUrlConnection timeout
> --------------------------------------------------------------------------------------------
>
> Key: JBIDE-16112
> URL: https://issues.jboss.org/browse/JBIDE-16112
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.1.1.CR1
> Reporter: Andre Dietisheim
> Labels: help_wanted, openshift-java-client
> Fix For: 4.2.x
>
>
> The current code to set timeouts in openshift-java-client is:
> {code}
> private int getTimeout(int timeout, int openShiftTimeout, int systemPropertyTimeout, int defaultTimeout) {
> if (timeout == NO_TIMEOUT) {
> timeout = openShiftTimeout;
> if (timeout == NO_TIMEOUT) {
> timeout = systemPropertyTimeout;
> if (timeout == NO_TIMEOUT) {
> timeout = defaultTimeout;
> }
> }
> }
> return timeout;
> }
> {code}
> calling it looks like this:
> {code}
> private void setReadTimeout(int timeout, URLConnection connection) {
> connection.setReadTimeout(
> getTimeout(
> timeout,
> getSystemPropertyInteger(SYSPROP_OPENSHIFT_READ_TIMEOUT),
> getSystemPropertyInteger(SYSPROP_DEFAULT_READ_TIMEOUT),
> DEFAULT_READ_TIMEOUT));
> }
> {code}
> DEFAULT_READ_TIMEOUT should get eliminated, we should use the SYSPROP_OPENSHIFT_READ_TIMEOUT as this. Furthermore there's no need to set the SYSPROP_DEFAULT_READ_TIMEOUT.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 4 months
[JBoss JIRA] (JBIDE-15744) openshift-java-client: add support for List<IEnvironmentVariable> and refactor methods that reference "List" in their names, however are operating on "Map<String, IEnvironmentVariable>", to reference "Map"
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15744?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-15744:
-------------------------------------
Labels: openshift-java-client (was: )
> openshift-java-client: add support for List<IEnvironmentVariable> and refactor methods that reference "List" in their names, however are operating on "Map<String,IEnvironmentVariable>", to reference "Map"
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15744
> URL: https://issues.jboss.org/browse/JBIDE-15744
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.1.x, 4.2.0.Alpha1
> Reporter: Martes Wigglesworth
> Assignee: Andre Dietisheim
> Labels: openshift-java-client
> Fix For: 4.2.x
>
>
> This enhancement to the interface will remove the requirement that users of the interface implementation instances to do extra processing to pull the list of variables from the provided immutable Map<String,IEnvirontmentVariable> instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 4 months
[JBoss JIRA] (JBIDE-15822) Application wizard: Embedded cartridges should get checked when I select "Enable Scaling" AFTER I selected them
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15822?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-15822:
-------------------------------------
Summary: Application wizard: Embedded cartridges should get checked when I select "Enable Scaling" AFTER I selected them (was: Embedded cartridges should get checked when I select "Enable Scaling" AFTER I selected them)
> Application wizard: Embedded cartridges should get checked when I select "Enable Scaling" AFTER I selected them
> ---------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15822
> URL: https://issues.jboss.org/browse/JBIDE-15822
> Project: Tools (JBoss Tools)
> Issue Type: Sub-task
> Components: openshift
> Affects Versions: 4.2.0.Alpha1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.2.x
>
>
> We currently only check the validity of embedded cartridges when you check/uncheck them. Since there are cartridges which are not valid in scaled apps (ex. phpmyadmin), we should also check the embedded cartridges when one hits the "Enable Scaling" checkbox.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 4 months