[JBoss JIRA] (JBIDE-14448) Build doesn't detect cycle dependencies between JBossTools modules
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-14448?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen edited comment on JBIDE-14448 at 5/15/13 3:23 AM:
----------------------------------------------------------------------
Suggestion (don't implement without testing in seperate branch!):
A) Remove nightly composite site from parent pom/TPC.
B) List the dependent composite site individually in root pom of components.
Question - how do we maintain this between branches/main platform.
Should have a naming scheme so we do not need to change this in every dev cycle for every component.
was (Author: maxandersen):
Suggestion (don't implement without testing in seperate branch!):
A) Remove nightly composite site from parent pom/TPC.
B) List the dependent composite site individually in root pom of components.
> Build doesn't detect cycle dependencies between JBossTools modules
> ------------------------------------------------------------------
>
> Key: JBIDE-14448
> URL: https://issues.jboss.org/browse/JBIDE-14448
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng
> Affects Versions: 4.1.0.Beta1
> Reporter: Denis Golovin
> Assignee: Nick Boldt
>
> Currently every component references nightly composite update site during the build to get dependencies. That leads to possibility to introduce cycle dependencies between components that is not detected by build.
> Here is example of PR introduced a cycle between JST and VPE. Build works because JST have access to VPE BrowserSim through nightly composite update site.
> The solution would be to reference specific nightly update sites for modules that are dependencies for current one.
> In this case JST should have reference only to base composite nightly update site. That would solve cycle dependency detection problem and speed up the build because it would not require to download and analyse all metadata from jbosstools nightly composite update site.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-14448) Build doesn't detect cycle dependencies between JBossTools modules
by Max Rydahl Andersen (JIRA)
[ https://issues.jboss.org/browse/JBIDE-14448?page=com.atlassian.jira.plugi... ]
Max Rydahl Andersen commented on JBIDE-14448:
---------------------------------------------
Suggestion (don't implement without testing in seperate branch!):
A) Remove nightly composite site from parent pom/TPC.
B) List the dependent composite site individually in root pom of components.
> Build doesn't detect cycle dependencies between JBossTools modules
> ------------------------------------------------------------------
>
> Key: JBIDE-14448
> URL: https://issues.jboss.org/browse/JBIDE-14448
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: Build/Releng
> Affects Versions: 4.1.0.Beta1
> Reporter: Denis Golovin
> Assignee: Nick Boldt
>
> Currently every component references nightly composite update site during the build to get dependencies. That leads to possibility to introduce cycle dependencies between components that is not detected by build.
> Here is example of PR introduced a cycle between JST and VPE. Build works because JST have access to VPE BrowserSim through nightly composite update site.
> The solution would be to reference specific nightly update sites for modules that are dependencies for current one.
> In this case JST should have reference only to base composite nightly update site. That would solve cycle dependency detection problem and speed up the build because it would not require to download and analyse all metadata from jbosstools nightly composite update site.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-14363) Creation of 'core' component in base
by Denis Golovin (JIRA)
[ https://issues.jboss.org/browse/JBIDE-14363?page=com.atlassian.jira.plugi... ]
Denis Golovin commented on JBIDE-14363:
---------------------------------------
+1 for foundation
> Creation of 'core' component in base
> ------------------------------------
>
> Key: JBIDE-14363
> URL: https://issues.jboss.org/browse/JBIDE-14363
> Project: Tools (JBoss Tools)
> Issue Type: Task
> Components: common/jst/core
> Affects Versions: 4.1.0.Beta1
> Reporter: Rob Stryker
> Assignee: Max Rydahl Andersen
> Fix For: 4.1.0.Beta1
>
>
> The creation of a 'core' with minimal dependencies, preferably ONLY platform, is required. The component will have the following requirements:
> 1) Only code designed for re-use can live there
> 2) Only fully and properly java-doc'd code can live there
> 3) Only code for use by TWO OR MORE components can live there.
> 4) Addition of dependencies for this component will be strictly regulated
> 5) Code must be properly tested and have tests cases demonstrating it.
> 6) Code relating to non-platform requirements (such as egit, maven, wtp) will receive additional bundles and features to keep these dependencies separate. FOr example:
> {code}
> org.jboss.tools.core.platform
> org.jboss.tools.core.platform.ui
> org.jboss.tools.core.wtp
> org.jboss.tools.core.wtp.ui
> {code}
> Bundles such as these would require test bundles, as well as features that keep them separate.
> {code}
> org.jboss.tools.core.platform.feature
> org.jboss.tools.core.wtp.feature
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-13569) Error when waiting for application to become reachable
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13569?page=com.atlassian.jira.plugi... ]
RH Bugzilla Integration commented on JBIDE-13569:
-------------------------------------------------
zhangjing <jinzhang(a)redhat.com> changed the Status of [bug 895507|https://bugzilla.redhat.com/show_bug.cgi?id=895507] from ON_QA to VERIFIED
> Error when waiting for application to become reachable
> ------------------------------------------------------
>
> Key: JBIDE-13569
> URL: https://issues.jboss.org/browse/JBIDE-13569
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.0.Alpha1
> Reporter: Stefan Bunciak
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.Alpha2
>
> Attachments: error-waiting-for-reachable.png, JBT_0219.png
>
>
> {code}
> com.openshift.client.NotFoundOpenShiftException: Could not find any OpenShift resource at "http://testapp-1360837500661.rhcloud.com/health"
> at com.openshift.internal.client.RestService.request(RestService.java:101)
> at com.openshift.internal.client.ApplicationResource.waitForPositiveHealthResponse(ApplicationResource.java:510)
> at com.openshift.internal.client.ApplicationResource.waitForAccessible(ApplicationResource.java:487)
> at org.jboss.tools.openshift.express.internal.ui.job.WaitForApplicationJob.doRun(WaitForApplicationJob.java:50)
> at org.jboss.tools.openshift.express.internal.ui.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:35)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
> Caused by: com.openshift.internal.client.httpclient.NotFoundException: Could not find resource "http://testapp-1360837500661.rhcloud.com/health"
> at com.openshift.internal.client.httpclient.UrlConnectionHttpClient.get(UrlConnectionHttpClient.java:96)
> at com.openshift.internal.client.RestService.request(RestService.java:139)
> at com.openshift.internal.client.RestService.request(RestService.java:97)
> ... 5 more
> Caused by: java.io.FileNotFoundException: http://testapp-1360837500661.rhcloud.com/health
> at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1434)
> at com.openshift.internal.client.httpclient.UrlConnectionHttpClient.get(UrlConnectionHttpClient.java:94)
> ... 7 more
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month
[JBoss JIRA] (JBIDE-13569) Error when waiting for application to become reachable
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/JBIDE-13569?page=com.atlassian.jira.plugi... ]
RH Bugzilla Integration commented on JBIDE-13569:
-------------------------------------------------
zhangjing <jinzhang(a)redhat.com> made a comment on [bug 895507|https://bugzilla.redhat.com/show_bug.cgi?id=895507]
Verified this bug on build/OpenShiftEnterprise/1.2/2013-05-14.1 with JBDS 7.0.0 Alpha2, it works all when create jbosseap apps or other cartridges app.
> Error when waiting for application to become reachable
> ------------------------------------------------------
>
> Key: JBIDE-13569
> URL: https://issues.jboss.org/browse/JBIDE-13569
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 4.1.0.Alpha1
> Reporter: Stefan Bunciak
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.Alpha2
>
> Attachments: error-waiting-for-reachable.png, JBT_0219.png
>
>
> {code}
> com.openshift.client.NotFoundOpenShiftException: Could not find any OpenShift resource at "http://testapp-1360837500661.rhcloud.com/health"
> at com.openshift.internal.client.RestService.request(RestService.java:101)
> at com.openshift.internal.client.ApplicationResource.waitForPositiveHealthResponse(ApplicationResource.java:510)
> at com.openshift.internal.client.ApplicationResource.waitForAccessible(ApplicationResource.java:487)
> at org.jboss.tools.openshift.express.internal.ui.job.WaitForApplicationJob.doRun(WaitForApplicationJob.java:50)
> at org.jboss.tools.openshift.express.internal.ui.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:35)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
> Caused by: com.openshift.internal.client.httpclient.NotFoundException: Could not find resource "http://testapp-1360837500661.rhcloud.com/health"
> at com.openshift.internal.client.httpclient.UrlConnectionHttpClient.get(UrlConnectionHttpClient.java:96)
> at com.openshift.internal.client.RestService.request(RestService.java:139)
> at com.openshift.internal.client.RestService.request(RestService.java:97)
> ... 5 more
> Caused by: java.io.FileNotFoundException: http://testapp-1360837500661.rhcloud.com/health
> at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1434)
> at com.openshift.internal.client.httpclient.UrlConnectionHttpClient.get(UrlConnectionHttpClient.java:94)
> ... 7 more
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 1 month