[JBoss JIRA] (JBIDE-12620) openshift java client: should not load all applications when creating a new application
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12620?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-12620:
------------------------------------------
postponed to 4.2.x
> openshift java client: should not load all applications when creating a new application
> ---------------------------------------------------------------------------------------
>
> Key: JBIDE-12620
> URL: https://issues.jboss.org/browse/JBIDE-12620
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 3.3.0.Final
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Priority: Minor
> Fix For: 4.2.x
>
>
> When creating a new application, the openshift-java-client would lookup if the application name already exist. When doing that it'll load the existing apps from the backend if they're not cached yet:
> {code:title=stacktrace when creating a new application}
> at com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
> at com.openshift.internal.client.DomainResource.loadApplications(DomainResource.java:189)
> at com.openshift.internal.client.DomainResource.getApplications(DomainResource.java:179)
> at com.openshift.internal.client.DomainResource.getApplicationByName(DomainResource.java:141)
> at com.openshift.internal.client.DomainResource.hasApplicationByName(DomainResource.java:151)
> at com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:126)
> at com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:112)
> {code}
> {code:title=DomainResource looks applications up, to see if the name is already used. DomainResource#createApplication}
> if (hasApplicationByName(name)) {
> throw new OpenShiftException("Application with name \"{0}\" already exists.", name);
> }
> {code}
> {code:title=DomainResource#hasApplicationByName gets the available applications:}
> return getApplicationByName(name) != null;
> {code}
> {code:title=DomainResource#getApplicationByName}
> IApplication matchingApplication = null;
> for (IApplication application : getApplications()) {
> if (application.getName().equals(name)) {
> matchingApplication = application;
> break;
> }
> }
> return matchingApplication;
> {code}
> {code:title=DomainResource#getApplications would load the applications from the backend if they're not loaded yet}
> if (this.applications == null) {
> this.applications = loadApplications();
> }
> return CollectionUtils.toUnmodifiableCopy(applications);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] (JBIDE-12428) OpenShift Explorer fails to delete application on renamed domain
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12428?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-12428:
------------------------------------------
postponed to 4.2.x
> OpenShift Explorer fails to delete application on renamed domain
> ----------------------------------------------------------------
>
> Key: JBIDE-12428
> URL: https://issues.jboss.org/browse/JBIDE-12428
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 3.3.0.Final
> Reporter: Stefan Bunciak
> Assignee: Andre Dietisheim
> Fix For: 4.2.x
>
>
> {code}
> com.openshift.client.NotFoundOpenShiftException: Could not find any OpenShift Express resource at "https://openshift.redhat.com/broker/rest/domains/bunciak/applications/java7"
> at com.openshift.internal.client.RestService.request(RestService.java:99)
> at com.openshift.internal.client.RestService.request(RestService.java:89)
> at com.openshift.internal.client.RestService.request(RestService.java:74)
> at com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
> at com.openshift.internal.client.ApplicationResource.destroy(ApplicationResource.java:238)
> at org.jboss.tools.openshift.express.internal.ui.action.DeleteApplicationAction$1.run(DeleteApplicationAction.java:90)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
> Caused by: com.openshift.internal.client.httpclient.NotFoundException: Could not find resource https://openshift.redhat.com/broker/rest/domains/bunciak/applications/java7
> at com.openshift.internal.client.httpclient.UrlConnectionHttpClient.write(UrlConnectionHttpClient.java:149)
> at com.openshift.internal.client.httpclient.UrlConnectionHttpClient.delete(UrlConnectionHttpClient.java:133)
> at com.openshift.internal.client.httpclient.UrlConnectionHttpClient.delete(UrlConnectionHttpClient.java:124)
> at com.openshift.internal.client.RestService.request(RestService.java:142)
> at com.openshift.internal.client.RestService.request(RestService.java:95)
> ... 6 more
> Caused by: java.io.FileNotFoundException: https://openshift.redhat.com/broker/rest/domains/bunciak/applications/java7
> at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1610)
> at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:254)
> at com.openshift.internal.client.httpclient.UrlConnectionHttpClient.write(UrlConnectionHttpClient.java:147)
> ... 10 more
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] (JBIDE-12428) OpenShift Explorer fails to delete application on renamed domain
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12428?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-12428:
-------------------------------------
Fix Version/s: 4.2.x
(was: 4.1.x)
> OpenShift Explorer fails to delete application on renamed domain
> ----------------------------------------------------------------
>
> Key: JBIDE-12428
> URL: https://issues.jboss.org/browse/JBIDE-12428
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 3.3.0.Final
> Reporter: Stefan Bunciak
> Assignee: Andre Dietisheim
> Fix For: 4.2.x
>
>
> {code}
> com.openshift.client.NotFoundOpenShiftException: Could not find any OpenShift Express resource at "https://openshift.redhat.com/broker/rest/domains/bunciak/applications/java7"
> at com.openshift.internal.client.RestService.request(RestService.java:99)
> at com.openshift.internal.client.RestService.request(RestService.java:89)
> at com.openshift.internal.client.RestService.request(RestService.java:74)
> at com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
> at com.openshift.internal.client.ApplicationResource.destroy(ApplicationResource.java:238)
> at org.jboss.tools.openshift.express.internal.ui.action.DeleteApplicationAction$1.run(DeleteApplicationAction.java:90)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
> Caused by: com.openshift.internal.client.httpclient.NotFoundException: Could not find resource https://openshift.redhat.com/broker/rest/domains/bunciak/applications/java7
> at com.openshift.internal.client.httpclient.UrlConnectionHttpClient.write(UrlConnectionHttpClient.java:149)
> at com.openshift.internal.client.httpclient.UrlConnectionHttpClient.delete(UrlConnectionHttpClient.java:133)
> at com.openshift.internal.client.httpclient.UrlConnectionHttpClient.delete(UrlConnectionHttpClient.java:124)
> at com.openshift.internal.client.RestService.request(RestService.java:142)
> at com.openshift.internal.client.RestService.request(RestService.java:95)
> ... 6 more
> Caused by: java.io.FileNotFoundException: https://openshift.redhat.com/broker/rest/domains/bunciak/applications/java7
> at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1610)
> at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:254)
> at com.openshift.internal.client.httpclient.UrlConnectionHttpClient.write(UrlConnectionHttpClient.java:147)
> ... 10 more
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months