[JBoss JIRA] (JBIDE-12144) EGitUtils#push is throwing an exception if push fails. It should use the same semantics as EGit
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12144?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-12144:
------------------------------------------
postponed to 4.2.x
> EGitUtils#push is throwing an exception if push fails. It should use the same semantics as EGit
> -----------------------------------------------------------------------------------------------
>
> Key: JBIDE-12144
> URL: https://issues.jboss.org/browse/JBIDE-12144
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 3.3.0.CR1
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Priority: Minor
> Fix For: 4.2.x
>
>
> EgitUtils#push throws an exception if the push failed because of ex. "non fastforward push".
> {code}
> private static PushOperationResult push(Repository repository, RemoteConfig remoteConfig, boolean force, IProgressMonitor monitor) throws CoreException {
> ...
> PushOperationResult pushResult = op.getOperationResult();
> if (hasFailedEntries(pushResult)) {
> throw new CoreException(
> EGitCoreActivator.createErrorStatus(
> NLS.bind("Could not push repository {0}: {1}",
> repository.toString(), getErrors(pushResult))
> , null));
> }
> return pushResult;
> {code}
> EGit is not throwing an exception in this case. You simply get the failure in the PushResult object you'll have to look at.
> EGitUtils#push is thus changing the API semantics of EGit and it shouldn't.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] (JBIDE-12213) OpenShiftTimeoutException when embedding more cartridges
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-12213?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-12213:
-------------------------------------
Fix Version/s: 4.1.0.CR1
(was: 4.1.x)
> OpenShiftTimeoutException when embedding more cartridges
> --------------------------------------------------------
>
> Key: JBIDE-12213
> URL: https://issues.jboss.org/browse/JBIDE-12213
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Components: openshift
> Affects Versions: 3.3.0.Final
> Reporter: Stefan Bunciak
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.CR1
>
>
> Tried to embed mongodb, rockmongo, mysql, phpmyadmin and got:
> {code}
> com.openshift.client.OpenShiftTimeoutException: Could not request url https://openshift.redhat.com/broker/rest/domains/rhdomain/applications/rf..., connection timed out
> at com.openshift.internal.client.RestService.request(RestService.java:109)
> at com.openshift.internal.client.RestService.request(RestService.java:89)
> at com.openshift.internal.client.RestService.request(RestService.java:74)
> at com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
> at com.openshift.internal.client.ApplicationResource$AddEmbeddedCartridgeRequest.execute(ApplicationResource.java:889)
> at com.openshift.internal.client.ApplicationResource.addEmbeddableCartridge(ApplicationResource.java:338)
> at com.openshift.internal.client.ApplicationResource.addEmbeddableCartridges(ApplicationResource.java:354)
> at org.jboss.tools.openshift.express.internal.ui.job.EmbedCartridgesJob.addEmbeddedCartridges(EmbedCartridgesJob.java:102)
> at org.jboss.tools.openshift.express.internal.ui.job.EmbedCartridgesJob.doRun(EmbedCartridgesJob.java:64)
> at org.jboss.tools.openshift.express.internal.ui.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:35)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months